Skip to content

drm/panel infrastructure + backlight update

Sam Ravnborg dri-devel linux-arm-kernel linux-mediatek linux-renesas-soc linux-rockchip linux-samsung-soc linux-tegra lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest25 patches 6 repliesIn review
  2. v126 patches 31 repliesSuperseded

Changes in v2 from the cover letter

This is mostly addressing comments from Laurent.
- drop get_timings removal, we should start using it
- do not fail in drm_panel_of_backlight() if DT is not enabled
- updated changelogs and code comments in many places (thanks Laurent!)
- get_modes is a mandatory callback - return -EOPNOTSUPP if not specified
- log if backlight update fails
- added a-b/r-bs
o thanks to Laurent and Linus for the prompt reviews!

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25drm/drm_panel: no error when no callbackdrivers/gpu/drm/drm_panel.c include/drm/drm_panel.h+41 -123 replies
2/25drm/panel: add backlight supportdrivers/gpu/drm/drm_panel.c include/drm/drm_panel.h+82 -12 replies
3/25drm/panel: simple: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-simple.c+11 -390 replies
4/25drm: get drm_bridge_panel connector via helperdrivers/gpu/drm/bridge/panel.c drivers/gpu/drm/pl111/pl111_drv.c drivers/gpu/drm/tve200/tve200_drv.c +1 more+20 -23 replies
5/25drm/panel: add drm_connector argument to get_modes()drivers/gpu/drm/drm_panel.c drivers/gpu/drm/panel/panel-arm-versatile.c drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +38 more+143 -1300 replies
6/25drm/panel: decouple connector from drm_paneldrivers/gpu/drm/bridge/analogix/analogix-anx6345.c drivers/gpu/drm/bridge/analogix/analogix_dp_core.c drivers/gpu/drm/bridge/panel.c +23 more+31 -370 replies
7/25drm/panel: drop drm_device from drm_paneldrivers/gpu/drm/drm_panel.c drivers/gpu/drm/panel/panel-arm-versatile.c drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +35 more+63 -810 replies
8/25drm/panel: feiyang-fy07024di26a30d: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c+3 -70 replies
9/25drm/panel: ilitek-ili9881c: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-ilitek-ili9881c.c+3 -160 replies
10/25drm/panel: innolux-p079zca: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-innolux-p079zca.c+8 -200 replies
11/25drm/panel: kingdisplay-kd097d04: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c+8 -200 replies
12/25drm/panel: lvds: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-lvds.c+5 -350 replies
13/25drm/panel: olimex-lcd-olinuxino: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c+6 -120 replies
14/25drm/panel: osd-osd101t2587-53ts: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c+9 -150 replies
15/25drm/panel: panasonic-vvx10f034n00: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c+6 -390 replies
16/25drm/panel: raydium-rm68200: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-raydium-rm68200.c+5 -100 replies
17/25drm/panel: rocktech-jh057n00900: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-rocktech-jh057n00900.c+12 -120 replies
18/25drm/panel: ronbo-rb070d30: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-ronbo-rb070d30.c+3 -160 replies
19/25drm/panel: seiko-43wvf1g: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-seiko-43wvf1g.c+6 -300 replies
20/25drm/panel: sharp-lq101r1sx01: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c+7 -140 replies
21/25drm/panel: sharp-ls043t1le01: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-sharp-ls043t1le01.c+7 -130 replies
22/25drm/panel: sitronix-st7701: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-sitronix-st7701.c+4 -80 replies
23/25drm/panel: sitronix-st7789v: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-sitronix-st7789v.c+4 -330 replies
24/25drm/panel: tpo-td028ttec1: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-tpo-td028ttec1.c+4 -100 replies
25/25drm/panel: tpo-tpg110: use drm_panel backlight supportdrivers/gpu/drm/panel/panel-tpo-tpg110.c+6 -140 replies

Reviews trailers per patch

All 25 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartLinus WalleijJeffrey HugoGuido Günther
1/25R-b
2/25R-b R-b
3/25R-b
4/25R-b R-b R-b
5/25R-b R-b
6/25R-b R-b A-b
7/25R-b R-b
8/25R-b
9/25R-b
10/25R-b
11/25R-b
12/25R-b
13/25R-b
14/25R-b
15/25R-b
16/25R-b
17/25R-b R-b
18/25R-b
19/25R-b
20/25R-b
21/25R-b
22/25R-b
23/25R-b
24/25R-b
25/25R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/25] drm/panel infrastructure + backlight update

This patchset include a couple of different
things - all related to panels.

- The callbacks are optional - so drop error if
callback is not present.

- Add support for backlight in drm_panel.
This allows us to make much simpler backlight
support to most panels.
The patchset include conversion of most of the
trivial cases.

- Drop drm_connector from drm_panel.
This change required many changes to most
panels and many bridges and display drivers. This is by far the most invasive change in this patchset.

With this patchset drm_panel_(attach|detach) are nop's but they are kept for now.

A few of these patches has been sent out before - but versioning started again from v1 - as the most patches are new.

I have tested the panel-simple changes, and thus some of the infrastructure changes.
The testing was done on an earlier iteration - and I ended up submitting this as Laurent and others started to depend on it.

v2:
This is mostly addressing comments from Laurent.
- drop get_timings removal, we should start using it
- do not fail in drm_panel_of_backlight() if DT is not enabled
- updated changelogs and code comments in many places (thanks Laurent!)
- get_modes is a mandatory callback - return -EOPNOTSUPP if not specified
- log if backlight update fails
- added a-b/r-bs
o thanks to Laurent and Linus for the prompt reviews!

When "drm/panel: add backlight support" is reviewed I plan to apply the full series to drm-misc-next.

Sam

Sam Ravnborg (25):
drm/drm_panel: no error when no callback
drm/panel: add backlight support
drm/panel: simple: use drm_panel backlight support
drm: get drm_bridge_panel connector via helper drm/panel: add drm_connector argument to get_modes() drm/panel: decouple connector from drm_panel
drm/panel: drop drm_device from drm_panel
drm/panel: feiyang-fy07024di26a30d: use drm_panel backlight support drm/panel: ilitek-ili9881c: use drm_panel backlight support drm/panel: innolux-p079zca: use drm_panel backlight support drm/panel: kingdisplay-kd097d04: use drm_panel backlight support drm/panel: lvds: use drm_panel backlight support drm/panel: olimex-lcd-olinuxino: use drm_panel backlight support drm/panel: osd-osd101t2587-53ts: use drm_panel backlight support drm/panel: panasonic-vvx10f034n00: use drm_panel backlight support drm/panel: raydium-rm68200: use drm_panel backlight support drm/panel: rocktech-jh057n00900: use drm_panel backlight support drm/panel: ronbo-rb070d30: use drm_panel backlight support drm/panel: seiko-43wvf1g: use drm_panel backlight support drm/panel: sharp-lq101r1sx01: use drm_panel backlight support drm/panel: sharp-ls043t1le01: use drm_panel backlight support drm/panel: sitronix-st7701: use drm_panel backlight support drm/panel: sitronix-st7789v: use drm_panel backlight support drm/panel: tpo-td028ttec1: use drm_panel backlight support drm/panel: tpo-tpg110: use drm_panel backlight support

 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c |   2 +-
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c |   2 +-
 drivers/gpu/drm/bridge/panel.c                     |  19 +++-
 drivers/gpu/drm/bridge/parade-ps8622.c             |   2 +-
 drivers/gpu/drm/bridge/tc358764.c                  |   2 +-
 drivers/gpu/drm/bridge/tc358767.c                  |   2 +-
 drivers/gpu/drm/bridge/ti-sn65dsi86.c              |   2 +-
 drivers/gpu/drm/drm_panel.c                        | 107 +++++++++++++++++----
 drivers/gpu/drm/exynos/exynos_drm_dpi.c            |   2 +-
 drivers/gpu/drm/exynos/exynos_drm_dsi.c            |   2 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c          |   2 +-
 drivers/gpu/drm/imx/imx-ldb.c                      |   2 +-
 drivers/gpu/drm/imx/parallel-display.c             |   2 +-
 drivers/gpu/drm/mediatek/mtk_dsi.c                 |   2 +-
 .../gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c    |   2 +-
 drivers/gpu/drm/msm/dsi/dsi_manager.c              |   2 +-
 drivers/gpu/drm/mxsfb/mxsfb_out.c                  |   2 +-
 drivers/gpu/drm/omapdrm/omap_connector.c           |   3 +-
 drivers/gpu/drm/panel/panel-arm-versatile.c        |   6 +-
 .../gpu/drm/panel/panel-feiyang-fy07024di26a30d.c  |  16 ++-
 drivers/gpu/drm/panel/panel-ilitek-ili9322.c       |  19 ++--
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c      |  29 ++----
 drivers/gpu/drm/panel/panel-innolux-p079zca.c      |  45 +++------
 drivers/gpu/drm/panel/panel-jdi-lt070me05000.c     |  11 ++-
 drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c |  43 +++------
 drivers/gpu/drm/panel/panel-lg-lb035q02.c          |   6 +-
 drivers/gpu/drm/panel/panel-lg-lg4573.c            |  12 +--
 drivers/gpu/drm/panel/panel-lvds.c                 |  46 ++-------
 drivers/gpu/drm/panel/panel-nec-nl8048hl11.c       |   6 +-
 drivers/gpu/drm/panel/panel-novatek-nt39016.c      |   6 +-
 drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c |  27 ++----
 drivers/gpu/drm/panel/panel-orisetech-otm8009a.c   |  11 ++-
 drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c |  37 +++----
 .../gpu/drm/panel/panel-panasonic-vvx10f034n00.c   |  58 +++--------
 .../gpu/drm/panel/panel-raspberrypi-touchscreen.c  |   9 +-
 drivers/gpu/drm/panel/panel-raydium-rm67191.c      |   8 +-
 drivers/gpu/drm/panel/panel-raydium-rm68200.c      |  26 +++--
 drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c |  35 +++----
 drivers/gpu/drm/panel/panel-ronbo-rb070d30.c       |  31 ++----
 drivers/gpu/drm/panel/panel-samsung-ld9040.c       |   4 +-
 drivers/gpu/drm/panel/panel-samsung-s6d16d0.c      |   6 +-
 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c      |   6 +-
 drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c   |   6 +-
 drivers/gpu/drm/panel/panel-samsung-s6e63m0.c      |   6 +-
 drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c      |   4 +-
 drivers/gpu/drm/panel/panel-seiko-43wvf1g.c        |  54 +++--------
 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c    |  34 +++----
 drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c    |   6 +-
 drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c    |  33 +++----
 drivers/gpu/drm/panel/panel-simple.c               |  92 ++++++------------
 drivers/gpu/drm/panel/panel-sitronix-st7701.c      |  23 ++---
 drivers/gpu/drm/panel/panel-sitronix-st7789v.c     |  49 ++--------
 drivers/gpu/drm/panel/panel-sony-acx565akm.c       |   6 +-
 drivers/gpu/drm/panel/panel-tpo-td028ttec1.c       |  20 ++--
 drivers/gpu/drm/panel/panel-tpo-td043mtea1.c       |   6 +-
 drivers/gpu/drm/panel/panel-tpo-tpg110.c           |  26 ++---
 drivers/gpu/drm/panel/panel-truly-nt35597.c        |   4 +-
 drivers/gpu/drm/pl111/pl111_drv.c                  |   2 +-
 drivers/gpu/drm/rcar-du/rcar_lvds.c                |   2 +-
 drivers/gpu/drm/rockchip/rockchip_lvds.c           |   2 +-
 drivers/gpu/drm/sti/sti_dvo.c                      |   2 +-
 drivers/gpu/drm/sun4i/sun4i_lvds.c                 |   2 +-
 drivers/gpu/drm/sun4i/sun4i_rgb.c                  |   2 +-
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c             |   2 +-
 drivers/gpu/drm/tegra/output.c                     |   2 +-
 drivers/gpu/drm/tve200/tve200_drv.c                |   2 +-
 include/drm/drm_bridge.h                           |   1 +
 include/drm/drm_panel.h                            |  61 ++++++++----
 68 files changed, 491 insertions(+), 620 deletions(-)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel