Skip to content

crypto: api - remove crypto_tfm::crt_u

Eric Biggers linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto: compress - remove crt_u.compress (struct compress_tfm)crypto/api.c crypto/compress.c crypto/internal.h +1 more+19 -580 replies
2/2crypto: cipher - remove crt_u.cipher (struct cipher_tfm)crypto/api.c crypto/cipher.c crypto/internal.h +1 more+43 -1140 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArd Biesheuvel
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] crypto: api - remove crypto_tfm::crt_u

This series removes the per-algorithm-type union from struct crypto_tfm now that its only remaining users are the "compress" and "cipher" algorithm types, and it's not really needed for them.

This shrinks every crypto transform for every algorithm by 28 bytes on 64-bit platforms (12 bytes on 32-bit), and also removes some code.

Note that the new-style strongly-typed algorithms (i.e. everything other than "compress" and "cipher") don't need crt_u, since they embed struct crypto_tfm in a per-algorithm-type custom struct instead.

Eric Biggers (2):
crypto: compress - remove crt_u.compress (struct compress_tfm)
crypto: cipher - remove crt_u.cipher (struct cipher_tfm)

 crypto/api.c           | 15 +------
 crypto/cipher.c        | 92 +++++++++++++++++-------------------------
 crypto/compress.c      | 31 ++++++--------
 crypto/internal.h      |  3 --
 include/linux/crypto.h | 91 ++++++-----------------------------------
 5 files changed, 61 insertions(+), 171 deletions(-)
Signature · 1 line
2.24.0.393.g34dc348eaf-goog