Skip to content

Clean up drm_pci.{c,h}

Thomas Zimmermann dri-devel oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/pci: Only build drm_pci.c if CONFIG_PCI is setdrivers/gpu/drm/Makefile drivers/gpu/drm/drm_internal.h drivers/gpu/drm/drm_pci.c +1 more+55 -170 replies
2/12drm/pci: Hide legacy PCI functions from non-legacy codedrivers/gpu/drm/drm_pci.c include/drm/drm_legacy.h include/drm/drm_pci.h+32 -163 replies
3/12drm/ast: Don't include <drm/drm_pci.h>drivers/gpu/drm/ast/ast_drv.c+0 -10 replies
4/12drm/i810: Don't include <drm/drm_pci.h>drivers/gpu/drm/i810/i810_dma.c drivers/gpu/drm/i810/i810_drv.c+3 -20 replies
5/12drm/mga: Don't include <drm/drm_pci.h>drivers/gpu/drm/mga/mga_drv.h+1 -10 replies
6/12drm/mgag200: Don't include <drm/drm_pci.h>drivers/gpu/drm/mgag200/mgag200_cursor.c drivers/gpu/drm/mgag200/mgag200_i2c.c drivers/gpu/drm/mgag200/mgag200_main.c +2 more+6 -60 replies
7/12drm/r128: Don't include <drm/drm_pci.h>drivers/gpu/drm/r128/r128_drv.c+1 -10 replies
8/12drm/radeon: Don't include <drm/drm_pci.h>drivers/gpu/drm/radeon/atom.h drivers/gpu/drm/radeon/atombios_encoders.c drivers/gpu/drm/radeon/btc_dpm.c +37 more+54 -540 replies
9/12drm/savage: Don't include <drm/drm_pci.h>drivers/gpu/drm/savage/savage_drv.c+1 -10 replies
10/12drm/sis: Don't include <drm/drm_pci.h>drivers/gpu/drm/sis/sis_drv.c+1 -10 replies
11/12drm/tdfx: Don't include <drm/drm_pci.h>drivers/gpu/drm/tdfx/tdfx_drv.c+1 -10 replies
12/12drm/via: Don't include <drm/drm_pci.h>drivers/gpu/drm/via/via_dmablit.c drivers/gpu/drm/via/via_drv.c drivers/gpu/drm/via/via_map.c+4 -30 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEmil VelikovAlex Deucher
SeriesR-b R-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] Clean up drm_pci.{c,h}

This patchset cleans up drm_pci.{c,h}. Patch 1 removes drm_pci.c from non-PCI builds. Declarations of legacy functions are hidden in drm_legacy.h and their implementation is protected by CONFIG_PCI in patch 2. The rest of the patches replace unnecessary include statements for drm_pci.h. Most of the source files only require <linux/pci.h>.

The pathset was built on x86-64 and aarch64 with PCI support and arm without PCI support.

Thomas Zimmermann (12):
drm/pci: Only build drm_pci.c if CONFIG_PCI is set drm/pci: Hide legacy PCI functions from non-legacy code drm/ast: Don't include <drm/drm_pci.h> drm/i810: Don't include <drm/drm_pci.h> drm/mga: Don't include <drm/drm_pci.h> drm/mgag200: Don't include <drm/drm_pci.h> drm/r128: Don't include <drm/drm_pci.h> drm/radeon: Don't include <drm/drm_pci.h> drm/savage: Don't include <drm/drm_pci.h> drm/sis: Don't include <drm/drm_pci.h> drm/tdfx: Don't include <drm/drm_pci.h> drm/via: Don't include <drm/drm_pci.h>

 drivers/gpu/drm/Makefile                      |  3 +-
 drivers/gpu/drm/ast/ast_drv.c                 |  1 -
 drivers/gpu/drm/drm_internal.h                | 22 ++++++++++++++
 drivers/gpu/drm/drm_pci.c                     | 17 +++--------
 drivers/gpu/drm/i810/i810_dma.c               |  2 +-
 drivers/gpu/drm/i810/i810_drv.c               |  3 +-
 drivers/gpu/drm/mga/mga_drv.h                 |  2 +-
 drivers/gpu/drm/mgag200/mgag200_cursor.c      |  2 +-
 drivers/gpu/drm/mgag200/mgag200_i2c.c         |  3 +-
 drivers/gpu/drm/mgag200/mgag200_main.c        |  3 +-
 drivers/gpu/drm/mgag200/mgag200_mode.c        |  2 +-
 drivers/gpu/drm/mgag200/mgag200_ttm.c         |  2 +-
 drivers/gpu/drm/r128/r128_drv.c               |  2 +-
 drivers/gpu/drm/radeon/atom.h                 |  1 +
 drivers/gpu/drm/radeon/atombios_encoders.c    |  2 +-
 drivers/gpu/drm/radeon/btc_dpm.c              |  3 +-
 drivers/gpu/drm/radeon/ci_dpm.c               |  3 +-
 drivers/gpu/drm/radeon/cik.c                  |  4 +--
 drivers/gpu/drm/radeon/cypress_dpm.c          |  2 +-
 drivers/gpu/drm/radeon/evergreen.c            |  2 +-
 drivers/gpu/drm/radeon/kv_dpm.c               |  3 +-
 drivers/gpu/drm/radeon/ni.c                   |  4 +--
 drivers/gpu/drm/radeon/ni_dpm.c               |  3 +-
 drivers/gpu/drm/radeon/r100.c                 |  6 ++--
 drivers/gpu/drm/radeon/r300.c                 |  2 +-
 drivers/gpu/drm/radeon/r420.c                 |  2 +-
 drivers/gpu/drm/radeon/r600.c                 |  6 ++--
 drivers/gpu/drm/radeon/radeon_agp.c           |  3 +-
 drivers/gpu/drm/radeon/radeon_asic.c          |  2 +-
 drivers/gpu/drm/radeon/radeon_atombios.c      |  3 +-
 drivers/gpu/drm/radeon/radeon_bios.c          |  4 +--
 drivers/gpu/drm/radeon/radeon_clocks.c        |  3 +-
 drivers/gpu/drm/radeon/radeon_combios.c       |  3 +-
 drivers/gpu/drm/radeon/radeon_cs.c            |  2 +-
 drivers/gpu/drm/radeon/radeon_device.c        |  2 +-
 drivers/gpu/drm/radeon/radeon_display.c       |  2 +-
 drivers/gpu/drm/radeon/radeon_encoders.c      |  3 +-
 drivers/gpu/drm/radeon/radeon_fb.c            |  2 +-
 drivers/gpu/drm/radeon/radeon_gart.c          |  2 +-
 drivers/gpu/drm/radeon/radeon_gem.c           |  3 +-
 drivers/gpu/drm/radeon/radeon_i2c.c           |  2 +-
 drivers/gpu/drm/radeon/radeon_irq_kms.c       |  2 +-
 drivers/gpu/drm/radeon/radeon_kms.c           |  2 +-
 .../gpu/drm/radeon/radeon_legacy_encoders.c   |  2 +-
 drivers/gpu/drm/radeon/radeon_pm.c            |  2 +-
 drivers/gpu/drm/radeon/radeon_ttm.c           |  2 +-
 drivers/gpu/drm/radeon/rs600.c                |  2 +-
 drivers/gpu/drm/radeon/rs690.c                |  2 +-
 drivers/gpu/drm/radeon/rs780_dpm.c            |  3 +-
 drivers/gpu/drm/radeon/rv770.c                |  2 +-
 drivers/gpu/drm/radeon/si.c                   |  4 +--
 drivers/gpu/drm/radeon/si_dpm.c               |  3 +-
 drivers/gpu/drm/radeon/trinity_dpm.c          |  3 +-
 drivers/gpu/drm/savage/savage_drv.c           |  2 +-
 drivers/gpu/drm/sis/sis_drv.c                 |  2 +-
 drivers/gpu/drm/tdfx/tdfx_drv.c               |  2 +-
 drivers/gpu/drm/via/via_dmablit.c             |  2 +-
 drivers/gpu/drm/via/via_drv.c                 |  2 +-
 drivers/gpu/drm/via/via_map.c                 |  3 +-
 include/drm/drm_legacy.h                      | 29 ++++++++++++++++++-
 include/drm/drm_pci.h                         | 19 ++++++++++--
 61 files changed, 144 insertions(+), 89 deletions(-)

--
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel