Skip to content

Error handling fixes

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest18 patches 12 repliesIn review

Changes in v2 from the cover letter

* Old PATCH 01-03 have been merged for 4.2
* PATCH 05-15: Commit message rephrased [David], R-bys kept

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18crypto: Fix certificate file error handling crash bugcrypto/tlscredsx509.c+1 -11 reply
2/18crypto: Fix typo in QCryptoTLSSession's <example> commentinclude/crypto/tlssession.h+1 -11 reply
3/18io: Fix Error usage in a comment <example>include/io/task.h+1 -11 reply
4/18tests: Clean up initialization of Error *err variablestests/test-qobject-output-visitor.c tests/test-string-output-visitor.c+6 -62 replies
5/18exec: Fix file_ram_alloc() error API violationsexec.c+4 -21 reply
6/18hw/acpi: Fix legacy CPU plug error API violationshw/acpi/cpu_hotplug.c+3 -71 reply
7/18hw/core: Fix fit_load_fdt() error handling violationshw/core/loader-fit.c+8 -71 reply
8/18hw/ipmi: Fix realize() error API violationshw/ipmi/isa_ipmi_bt.c hw/ipmi/isa_ipmi_kcs.c hw/ipmi/pci_ipmi_bt.c +1 more+18 -80 replies
9/18qga: Fix guest-get-fsinfo error API violationsqga/commands-posix.c+4 -21 reply
10/18memory-device: Fix memory pre-plug error API violationshw/mem/memory-device.c+4 -20 replies
11/18s390x/event-facility: Fix realize() error API violationshw/s390x/event-facility.c+4 -20 replies
12/18s390x/cpumodel: Fix feature property error API violationstarget/s390x/cpu_models.c+8 -40 replies
13/18s390x/cpumodel: Fix realize() error API violationstarget/s390x/cpu_models.c+22 -150 replies
14/18s390x/cpumodel: Fix query-cpu-model-FOO error API violationstarget/s390x/cpu_models.c+27 -160 replies
15/18s390x/cpumodel: Fix query-cpu-definitions error API violationstarget/s390x/cpu_models.c+1 -50 replies
16/18error: Clean up unusual names of Error * variableshw/intc/s390_flic_kvm.c hw/ppc/spapr_pci.c hw/ppc/spapr_pci_nvlink2.c +1 more+26 -260 replies
17/18hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()hw/intc/s390_flic_kvm.c+4 -60 replies
18/18tests-blockjob: Use error_free_or_abort()tests/test-blockjob.c+1 -20 replies

Reviews trailers per patch

17 of 18 patches have a Reviewed-by or Acked-by.

PatchIgor MammedovCornelia HuckHalil PasicDavid HildenbrandEric BlakeDaniel P. BerrangéPhilippe Mathieu-DaudéMichael S. Tsirkin
1/18A-b
2/18A-b
3/18A-b
4/18R-b R-b
5/18R-b R-b
6/18R-b R-b
7/18R-b
8/18
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b A-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/18] Error handling fixes

v2:
* Old PATCH 01-03 have been merged for 4.2
* PATCH 05-15: Commit message rephrased [David], R-bys kept

Cc "Daniel P. Berrangé" <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc Christian Borntraeger <[email protected]>
Cc Corey Minyard <[email protected]>
Cc Cornelia Huck <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc Halil Pasic <[email protected]>
Cc Igor Mammedov <[email protected]>
Cc Michael Roth <[email protected]>

Markus Armbruster (18):
crypto: Fix certificate file error handling crash bug
crypto: Fix typo in QCryptoTLSSession's <example> comment
io: Fix Error usage in a comment <example>
tests: Clean up initialization of Error *err variables
exec: Fix file_ram_alloc() error API violations hw/acpi: Fix legacy CPU plug error API violations hw/core: Fix fit_load_fdt() error handling violations hw/ipmi: Fix realize() error API violations
qga: Fix guest-get-fsinfo error API violations
memory-device: Fix memory pre-plug error API violations s390x/event-facility: Fix realize() error API violations s390x/cpumodel: Fix feature property error API violations s390x/cpumodel: Fix realize() error API violations s390x/cpumodel: Fix query-cpu-model-FOO error API violations s390x/cpumodel: Fix query-cpu-definitions error API violations
error: Clean up unusual names of Error * variables hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()
tests-blockjob: Use error_free_or_abort()

 include/crypto/tlssession.h         |  2 +-
 include/io/task.h                   |  2 +-
 crypto/tlscredsx509.c               |  2 +-
 exec.c                              |  6 +-
 hw/acpi/cpu_hotplug.c               | 10 +--
 hw/core/loader-fit.c                | 15 ++---
 hw/intc/s390_flic_kvm.c             | 16 +++--
 hw/ipmi/isa_ipmi_bt.c               |  7 ++-
 hw/ipmi/isa_ipmi_kcs.c              |  7 ++-
 hw/ipmi/pci_ipmi_bt.c               |  6 +-
 hw/ipmi/pci_ipmi_kcs.c              |  6 +-
 hw/mem/memory-device.c              |  6 +-
 hw/ppc/spapr_pci.c                  | 16 ++---
 hw/ppc/spapr_pci_nvlink2.c          | 10 +--
 hw/s390x/event-facility.c           |  6 +-
 qga/commands-posix.c                |  6 +-
 target/s390x/cpu_models.c           | 98 +++++++++++++++++------------
 tests/test-blockjob.c               | 15 +++--
 tests/test-qobject-output-visitor.c |  8 +--
 tests/test-string-output-visitor.c  |  4 +-
 20 files changed, 139 insertions(+), 109 deletions(-)
Signature · 1 line
2.21.0