Skip to content

remove BUG_ON()s in btrfs_close_one_device()

Johannes Thumshirn linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest2 patches 1 replyIn review

Changes to v4 from the cover letter

- Clear dev_stat_ccnt on removal (Dave)
- Don't clear BTRFS_DEV_STATE_MISSING and BTRFS_DEV_STATE_FS_METADATA as they'll be handled elsewhere
- Release extent_io_tree (fstests)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: decrement number of open devices after closing the device not beforefs/btrfs/volumes.c+2 -30 replies
2/2btrfs: reset device back to allocation state when removingfs/btrfs/volumes.c+11 -170 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchQu Wenruo
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] remove BUG_ON()s in btrfs_close_one_device()

This series attempts to remove the BUG_ON()s in btrfs_close_one_device(). Therefore some reorganization of btrfs_close_one_device() was needed, to avoid the memory allocation.

This series has passed fstests without any deviation from the baseline.

Changes to v4:
- Clear dev_stat_ccnt on removal (Dave)
- Don't clear BTRFS_DEV_STATE_MISSING and BTRFS_DEV_STATE_FS_METADATA as they'll be handled elsewhere
- Release extent_io_tree (fstests)

Changes to v3:
- Clear BTRFS_DEV_STATE_WRITEABLE after calling btrfs_close_bdev() so btrfs_close_bdev() can call sync_blockdev() and invalidate_bdev() (Nikolay)

Changes to v2:
- Completly different approach to the origianl patchset, instead of handling eventual allocation failures.
- Dropped already merged patches for ' btrfs_fs_devices::rotating' and 'btrfs_fs_devices::seeding'
- Kept the 1st patch of the old series, as it's a nice cleanup

Changes to v1:
- Fixed the decremt of btrfs_fs_devices::seeding.
- In addition to this, I've added two patches changing btrfs_fs_devices::seeding and btrfs_fs_devices::rotating to bool, as they are in fact used as booleans.

Johannes Thumshirn (2):
btrfs: decrement number of open devices after closing the device not
before
btrfs: reset device back to allocation state when removing

 fs/btrfs/volumes.c | 31 ++++++++++++-------------------
 1 file changed, 12 insertions(+), 19 deletions(-)
Signature · 1 line
2.20.1 (Apple Git-117)