Skip to content

xfs: don't commit sunit/swidth updates to disk if that would cause repair failures

Darrick J. Wong linux-xfs 9 versions – In review

Get series with b4
b4 am 157669784202.117895.9984764081860081830.stgit@magnolia

Versions newest first · linked by author and title

  1. v4 posting 2/27 patches 18 repliesIn review
  2. v3 posting 2/26 patches 13 repliesSuperseded
  3. v2 posting 3/36 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v5 Latest3 patches5 repliesIn review
v4 posting 1/21 patch1 replySuperseded
v3 posting 1/21 patch2 repliesSuperseded
v2 posting 2/31 patch2 repliesSuperseded
v2 posting 1/36 patches14 repliesSuperseded
v11 patch4 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: refactor agfl length computation functionfs/xfs/libxfs/xfs_alloc.c+13 -52 replies
2/3xfs: split the sunit parameter update into two partsfs/xfs/xfs_mount.c+75 -511 reply
3/3xfs: don't commit sunit/swidth updates to disk if that would cause repair failuresfs/xfs/libxfs/xfs_ialloc.c fs/xfs/libxfs/xfs_ialloc.h fs/xfs/xfs_mount.c +1 more+136 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBrian Foster
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] xfs: don't commit sunit/swidth updates to disk if that would cause repair failures

Hi all,

Alex Lyakas discovered that it's possible to mount a filesystem with sunit/swidth options that will cause a subsequent xfs_repair run to fail to find the root directory. This series adds some code to strengthen the kernel's mount option checking to avoid updating the superblock if this happens.

If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=sunit-updates