Skip to content

Fix nits in the kunit

SeongJae Park linux-doc linux-kselftest lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest6 patches 9 repliesIn review

Changes in v5 from the cover letter

(https://lore.kernel.org/linux-doc/[email protected]/):
- Rebased on Heidi Fahim's patch[2]
- Fix failing kunit_tool_test test
- Add 'build_dir' option test in 'kunit_tool_test.py'

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6docs/kunit/start: Use in-tree 'kunit_defconfig'Documentation/dev-tools/kunit/start.rst+1 -20 replies
2/6kunit: Remove duplicated defconfig creationtools/testing/kunit/kunit.py+0 -30 replies
3/6kunit: Create default config in '--build_dir'tools/testing/kunit/kunit.py tools/testing/kunit/kunit_kernel.py+11 -41 reply
4/6kunit: Place 'test.log' under the 'build_dir'tools/testing/kunit/kunit.py tools/testing/kunit/kunit_kernel.py tools/testing/kunit/kunit_tool_test.py+4 -41 reply
5/6kunit: Rename 'kunitconfig' to '.kunitconfig'Documentation/dev-tools/kunit/start.rst tools/testing/kunit/kunit.py tools/testing/kunit/kunit_kernel.py+8 -100 replies
6/6kunit/kunit_tool_test: Test '--build_dir' option runtools/testing/kunit/kunit_tool_test.py+8 -01 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchBrendan Higgins
1/6R-b
2/6R-b
3/6R-b T-b
4/6R-b T-b
5/6R-b
6/6R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] Fix nits in the kunit

From: SeongJae Park <[email protected]>

This patchset contains trivial fixes for the kunit documentations and the wrapper python scripts.

This patchset is based on 'kselftest/test' branch of linux-kselftest[1] and depends on Heidi's patch[2]. A complete tree is available at my repo:
https://github.com/sjp38/linux/tree/kunit_fix/20191205_v5

Changes from v4
(https://lore.kernel.org/linux-doc/[email protected]/):
- Rebased on Heidi Fahim's patch[2]
- Fix failing kunit_tool_test test
- Add 'build_dir' option test in 'kunit_tool_test.py'

Changes from v3
(https://lore.kernel.org/linux-kselftest/[email protected]):
- Fix the 4th patch, "kunit: Place 'test.log' under the 'build_dir'" to set default value of 'build_dir' as '' instead of NULL so that kunit can run even though '--build_dir' option is not given.

Changes from v2
(https://lore.kernel.org/linux-kselftest/[email protected]):
- Make 'build_dir' if not exists (missed from v3 by mistake)

Changes from v1
(https://lore.kernel.org/linux-doc/[email protected]):
- Remove "docs/kunit/start: Skip wrapper run command" (A similar approach is ongoing)
- Make 'build_dir' if not exists

SeongJae Park (6):
docs/kunit/start: Use in-tree 'kunit_defconfig'
kunit: Remove duplicated defconfig creation
kunit: Create default config in '--build_dir'
kunit: Place 'test.log' under the 'build_dir'
kunit: Rename 'kunitconfig' to '.kunitconfig' kunit/kunit_tool_test: Test '--build_dir' option run

 Documentation/dev-tools/kunit/start.rst | 13 +++++--------
 tools/testing/kunit/kunit.py            | 18 +++++++++++-------
 tools/testing/kunit/kunit_kernel.py     | 10 +++++-----
 tools/testing/kunit/kunit_tool_test.py  | 10 +++++++++-
 4 files changed, 30 insertions(+), 21 deletions(-)
Signature · 5 lines
[1] git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
[2] "kunit: testing kunit: Bug fix in test_run_timeout function",
https://lore.kernel.org/linux-kselftest/CAFd5g47a7a8q7by+1ALBtepeegLvfkgwvC3nFd8n8V=hqkV+cg@mail.gmail.com/T/#t)

2.17.1