Skip to content

Use inode_lock/unlock class of provided APIs in filesystems

Ritesh Harjani ceph-devel linux-btrfs linux-fsdevel linux-nfs linux-unionfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/21 patch 5 repliesIn review
  2. v1 posting 1/21 patch 4 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1fs: Use inode_lock/unlock class of provided APIs in filesystemsfs/btrfs/delayed-inode.c fs/btrfs/ioctl.c fs/ceph/io.c +5 more+53 -320 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchMatthew Wilcox (Oracle)Jeff LaytonDavid Sterba
1/1R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RESEND PATCH 0/1] Use inode_lock/unlock class of provided APIs in filesystems

Al, any comments?
Resending this after adding Reviewed-by/Acked-by tags.

From previous version:-
Matthew Wilcox in [1] suggested that it will be a good idea to define some missing API instead of directly using i_rwsem in filesystems drivers for lock/unlock/downgrade purposes.

This patch does that work. No functionality change in this patch.

After this there are only lockdep class of APIs at certain places in filesystems which are directly using i_rwsem and second is XFS, but it seems to be anyway defining it's own xfs_ilock/iunlock set of APIs and 'iolock' naming convention for this lock.

[1]: https://www.spinics.net/lists/linux-ext4/msg68689.html

Ritesh Harjani (1):
fs: Use inode_lock/unlock class of provided APIs in filesystems

 fs/btrfs/delayed-inode.c |  2 +-
 fs/btrfs/ioctl.c         |  4 ++--
 fs/ceph/io.c             | 24 ++++++++++++------------
 fs/nfs/io.c              | 24 ++++++++++++------------
 fs/orangefs/file.c       |  4 ++--
 fs/overlayfs/readdir.c   |  2 +-
 fs/readdir.c             |  4 ++--
 include/linux/fs.h       | 21 +++++++++++++++++++++
 8 files changed, 53 insertions(+), 32 deletions(-)
Signature · 1 line
2.21.0