Skip to content

Misc fixes silencing false positives from cppcheck

Johannes Thumshirn linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: fix possible NULL-pointer dereference in integrity checksfs/btrfs/check-integrity.c+1 -20 replies
2/3btrfs: remove superfluous BUG_ON() in integrity checksfs/btrfs/check-integrity.c+0 -10 replies
3/3btrfs: remove impossible WARN_ON in btrfs_destroy_dev_replace_tgtdev()fs/btrfs/volumes.c+0 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Misc fixes silencing false positives from cppcheck

misc fixes provoked by https://bugzilla.kernel.org/show_bug.cgi?id=205003

The first patch removes an unneeded variable, which when removed silences a false positive warning generated by cppcheck.

The second patch removes a BUG_ON() which can't be hit, for the same reasons as there can't be no NULL-pointer dereference in patch 1.

Patch number three removes a WARN_ON() which can't be triggered. This WARN_ON() was also identified as a possible NULL-pointer dereference by cppcheck.

Johannes Thumshirn (3):
btrfs: fix possible NULL-pointer dereference in integrity checks
btrfs: remove superfluous BUG_ON() in integrity checks
btrfs: remove impossible WARN_ON in btrfs_destroy_dev_replace_tgtdev()

 fs/btrfs/check-integrity.c | 4 +---
 fs/btrfs/volumes.c         | 1 -
 2 files changed, 1 insertion(+), 4 deletions(-)
Signature · 1 line
2.21.0 (Apple Git-122)