Skip to content

Remove deprecated pc-0.x machine types and related hacks

Thomas Huth qemu-devel 2 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesApplied
  2. v13 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Minor updates to the first patch (fix comment, add deprecation_reason message for the pc-1.x machines)
- Keep the QEMU_PCI_CAP_SERR enum in the third patch
- Added fourth patch to remove the "rombar" hacks from the VGA devices

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4hw/i386: Remove the deprecated machines 0.12 up to 0.15hw/i386/pc_piix.c qemu-deprecated.texi tests/cpu-plug-test.c+4 -890 replies
2/4hw/audio: Remove the "use_broken_id" hack from the AC97 devicehw/audio/ac97.c+0 -90 replies
3/4hw/pci: Remove the "command_serr_enable" propertyhw/pci/pci.c include/hw/pci/pci.h+2 -60 replies
4/4hw/display: Remove "rombar" hack from vga-pci and vmware_vgahw/display/vga-pci.c hw/display/vga.c hw/display/vmware_vga.c+1 -134 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/4R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Remove deprecated pc-0.x machine types and related hacks

These have been on the deprecation list since a year now, so it's time to finally remove the pc-0.x machine types.

We then can also remove some compatibility hacks in the devices, i.e. the "use_broken_id" in ac97, the "command_serr_enable" in PCI devices and the "rombar" stuff in VGA devices.

v2:
- Minor updates to the first patch (fix comment, add deprecation_reason message for the pc-1.x machines)
- Keep the QEMU_PCI_CAP_SERR enum in the third patch
- Added fourth patch to remove the "rombar" hacks from the VGA devices

Thomas Huth (4):
hw/i386: Remove the deprecated machines 0.12 up to 0.15 hw/audio: Remove the "use_broken_id" hack from the AC97 device hw/pci: Remove the "command_serr_enable" property hw/display: Remove "rombar" hack from vga-pci and vmware_vga

 hw/audio/ac97.c         |  9 -----
 hw/display/vga-pci.c    |  5 ---
 hw/display/vga.c        |  4 +-
 hw/display/vmware_vga.c |  5 ---
 hw/i386/pc_piix.c       | 85 +----------------------------------------
 hw/pci/pci.c            |  6 +--
 include/hw/pci/pci.h    |  2 +-
 qemu-deprecated.texi    |  2 +-
 tests/cpu-plug-test.c   |  6 +--
 9 files changed, 7 insertions(+), 117 deletions(-)
Signature · 1 line
2.18.1