Skip to content

net: Drop legacy "name" from -net and remove NetLegacy

Thomas Huth qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 6 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Do not make "id" in Netdev optional, but rather assign a temporary "id" for -net before we call the options visitor function.
- Changed some "void *" to "Netdev *" now

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: Drop the legacy "name" parameter from the -net optiondocs/system/deprecated.rst net/net.c qapi/net.json+10 -180 replies
2/2net: Drop the NetLegacy structure, always use Netdev insteadnet/net.c qapi/net.json+13 -1101 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy

Since commit b4983c570c7a ("net: Remove deprecated [hub_id name] tuple of 'hostfwd_add' / 'hostfwd_remove'"), the "name" parameter is not used internally anymore. And it's been marked as deprecated since QEMU v3.1, so it is time to remove the "name" parameter from -net now. Once this has been done, we can also drop the obsolete NetLegacy structure since there is no major difference between Netdev and NetLegacy anymore.

v3:
- Do not make "id" in Netdev optional, but rather assign a temporary "id" for -net before we call the options visitor function.
- Changed some "void *" to "Netdev *" now

v2:
- Rebased to master (use the deprecated.rst instead of qemu-deprecated.texi)

Thomas Huth (2):
net: Drop the legacy "name" parameter from the -net option
net: Drop the NetLegacy structure, always use Netdev instead

 docs/system/deprecated.rst | 15 ++++---
 net/net.c                  | 87 ++++++--------------------------------
 qapi/net.json              | 49 ---------------------
 3 files changed, 23 insertions(+), 128 deletions(-)
Signature · 1 line
2.18.1