nvme specialized queue fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | nvme/pci: Fix write and poll queue typesdrivers/ | +4 | 0 replies | |
| 2/3 | nvme/pci Limit write queue sizes to possible cpusdrivers/ | +3 | 0 replies | |
| 3/3 | nvme/pci: Fix read queue countdrivers/ | +1 | 1 reply |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jens Axboe |
|---|---|
| Series | R-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] nvme specialized queue fixes
The nvme pci module had been allowing bad values to the specialized polled and write queues that could have caused the driver to allocate queues incorrectly or unoptimally.
For example, on a system with 16 CPUs, if I have module parameter nvme.write_queues=17, we would get only 1 read queue no matter how many the drive supported:
# dmesg | grep nvme | grep "poll queues" nvme nvme2: 16/1/2 default/read/poll queues nvme nvme1: 16/1/2 default/read/poll queues nvme nvme0: 16/1/2 default/read/poll queues nvme nvme3: 16/1/2 default/read/poll queues
But after fixing:
# dmesg | grep nvme | grep "poll queues" nvme nvme1: 16/16/2 default/read/poll queues nvme nvme2: 16/13/2 default/read/poll queues nvme nvme0: 16/16/2 default/read/poll queues nvme nvme3: 16/13/2 default/read/poll queues
We just need to fix the calculation so that we don't throttle the total number of possible desired queues incorrectly. The first two patches ensure the module parameters are withing reasonable boundaries to simplify counting the number of interrupts we want to allocate.
Keith Busch (3):
nvme/pci: Fix write and poll queue types nvme/pci Limit write queue sizes to possible cpus nvme/pci: Fix read queue count
drivers/nvme/host/pci.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
Signature · 7 lines
2.21.0 _______________________________________________ linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme