Skip to content

PCI: amlogic: Make PCIe working reliably on AXG platforms

Remi Pommarel linux-amlogic linux-devicetree linux-pci lkml 6 versions – Applied

Status from this message: Applied patches [1,2,3,5,6,7] to pci/amlogic for v5.7, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 21 repliesApplied
  2. v57 patches 10 repliesSuperseded
  3. v47 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches5 repliesSuperseded
v23 patches9 repliesSuperseded
v12 patches7 repliesSuperseded

Changes in v6 from the cover letter

- Add additionalProperties in device tree binding documentation
- Make analog PHY required

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/7dt-bindings: Add AXG PCIE PHY bindingsDocumentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml+52 -01 reply
2/7dt-bindings: Add AXG shared MIPI/PCIE analog PHY bindingsDocumentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml+35 -01 reply
3/7dt-bindings: PCI: meson: Update PCIE bindings documentationDocumentation/devicetree/bindings/pci/amlogic,meson-pcie.txt+9 -131 reply
4/7arm64: dts: meson-axg: Add PCIE PHY nodesarch/arm64/boot/dts/amlogic/meson-axg.dtsi+16 -01 reply
5/7phy: amlogic: Add Amlogic AXG MIPI/PCIE analog PHY Driverdrivers/phy/amlogic/Kconfig drivers/phy/amlogic/Makefile drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c+205 -54 replies
6/7phy: amlogic: Add Amlogic AXG PCIE PHY Driverdrivers/phy/amlogic/Kconfig drivers/phy/amlogic/Makefile drivers/phy/amlogic/phy-meson-axg-pcie.c+204 -05 replies
7/7PCI: amlogic: Use AXG PCIEdrivers/pci/controller/dwc/pci-meson.c+22 -941 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchRob HerringJerome BrunetNeil ArmstrongKishon Vijay Abraham I
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7A-b R-b
6/7R-b A-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/7] PCI: amlogic: Make PCIe working reliably on AXG platforms

PCIe device probing failures have been seen on AXG platforms and were due to unreliable clock signal output. Setting HHI_MIPI_CNTL0[26] bit in MIPI's PHY registers solved the problem. This bit controls band gap reference.

As discussed here [1] one of these shared MIPI/PCIE analog PHY register bits was implemented in the clock driver as CLKID_MIPI_ENABLE. This adds a PHY driver to control this bit instead, as well as setting the band gap one in order to get reliable PCIE communication.

While at it add another PHY driver to control PCIE only PHY registers, making AXG code more similar to G12A platform thus allowing to remove some specific platform handling in pci-meson driver.

Please note that CLKID_MIPI_ENABLE removable will be done in a different serie.

Changes since v5:
- Add additionalProperties in device tree binding documentation
- Make analog PHY required

Changes since v4:
- Rename the shared MIPI/PCIe PHY to analog
- Chain the MIPI/PCIe PHY to the PCIe one

Changes since v3:
- Go back to the shared MIPI/PCIe phy driver solution from v2
- Remove syscon usage
- Add all dt-bindings documentation

Changes since v2:
- Remove shared MIPI/PCIE device driver and use syscon to access register in PCIE only driver instead
- Include devicetree documentation

Changes sinve v1:
- Move HHI_MIPI_CNTL0 bit control in its own PHY driver
- Add a PHY driver for PCIE_PHY registers
- Modify pci-meson.c to make use of both PHYs and remove specific handling for AXG and G12A

[1] https://lkml.org/lkml/2019/12/16/119

Remi Pommarel (7):
dt-bindings: Add AXG PCIE PHY bindings
dt-bindings: Add AXG shared MIPI/PCIE analog PHY bindings
dt-bindings: PCI: meson: Update PCIE bindings documentation
arm64: dts: meson-axg: Add PCIE PHY nodes
phy: amlogic: Add Amlogic AXG MIPI/PCIE analog PHY Driver
phy: amlogic: Add Amlogic AXG PCIE PHY Driver
PCI: amlogic: Use AXG PCIE

 .../bindings/pci/amlogic,meson-pcie.txt       |  22 +-
 .../amlogic,meson-axg-mipi-pcie-analog.yaml   |  35 ++++
 .../bindings/phy/amlogic,meson-axg-pcie.yaml  |  52 +++++
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi    |  16 ++
 drivers/pci/controller/dwc/pci-meson.c        | 116 ++---------
 drivers/phy/amlogic/Kconfig                   |  22 ++
 drivers/phy/amlogic/Makefile                  |  12 +-
 .../amlogic/phy-meson-axg-mipi-pcie-analog.c  | 188 +++++++++++++++++
 drivers/phy/amlogic/phy-meson-axg-pcie.c      | 192 ++++++++++++++++++
 9 files changed, 543 insertions(+), 112 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml
 create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
 create mode 100644 drivers/phy/amlogic/phy-meson-axg-pcie.c
Signature · 1 line
2.24.1