Skip to content

USB: fix NULL-deref and alternate settings bugs

Johan Hovold linux-usb stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4USB: atm: ueagle-atm: add missing endpoint checkdrivers/usb/atm/ueagle-atm.c+12 -60 replies
2/4USB: adutux: fix interface sanity checkdrivers/usb/misc/adutux.c+1 -10 replies
3/4USB: idmouse: fix interface sanity checksdrivers/usb/misc/idmouse.c+1 -10 replies
4/4USB: serial: io_edgeport: fix epic endpoint lookupdrivers/usb/serial/io_edgeport.c+6 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] USB: fix NULL-deref and alternate settings bugs

I stumbled over a couple potential NULL-pointer dereferences due to drivers using the first altsetting instead of the current one when doing descriptor sanity checks.

Turns out we have a quite a few drivers getting this wrong even if this would mostly be an issue on kernels with panic_on_warn set due to the WARN() in usb_submit_urb().

Since we've started backporting fixes for such warnings (e.g. as reported by syzbot), I've marked these for stable as well.

Johan

Johan Hovold (4):
USB: atm: ueagle-atm: add missing endpoint check
USB: adutux: fix interface sanity check
USB: idmouse: fix interface sanity checks
USB: serial: io_edgeport: fix epic endpoint lookup

 drivers/usb/atm/ueagle-atm.c     | 18 ++++++++++++------
 drivers/usb/misc/adutux.c        |  2 +-
 drivers/usb/misc/idmouse.c       |  2 +-
 drivers/usb/serial/io_edgeport.c | 10 ++++++----
 4 files changed, 20 insertions(+), 12 deletions(-)
Signature · 1 line
2.24.0