Skip to content

can: fix USB altsetting bugs

Johan Hovold linux-can linux-usb lkml netdev stable 1 version Applied

Status from this message: Applied both to linux-can.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2can: kvaser_usb: fix interface sanity checkdrivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+2 -20 replies
2/2can: gs_usb: use descriptors of current altsettingdrivers/net/can/usb/gs_usb.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] can: fix USB altsetting bugs

We had quite a few driver using the first alternate setting instead of the current one when doing descriptor sanity checks. This is mostly an issue on kernels with panic_on_warn set due to a WARN() in usb_submit_urn(). Since we've started backporting such fixes (e.g. as reported by syzbot), I've marked these for stable as well.

The second patch here is a related cleanup to prevent future issues.

Johan

Johan Hovold (2):
can: kvaser_usb: fix interface sanity check
can: gs_usb: use descriptors of current altsetting

 drivers/net/can/usb/gs_usb.c                      | 4 ++--
 drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 2 +-
 drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.24.0