Skip to content

reset: Add Broadcom STB RESCAL reset controller

Florian Fainelli linux-arm-kernel linux-devicetree lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- indented "base" variable with a space
- return ret directly out of readl_poll_timeout()
- removed additional register read after write, not necessary
- removed call to platform_set_drvdata, unnecessary either
- corrected Jim's email in Signed-off-by in patch #2

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: reset: Document BCM7216 RESCAL reset controllerDocumentation/devicetree/bindings/reset/brcm,bcm7216-pcie-sata-rescal.yaml+37 -01 reply
2/2reset: Add Broadcom STB RESCAL reset controllerdrivers/reset/Kconfig drivers/reset/Makefile drivers/reset/reset-brcmstb-rescal.c+115 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] reset: Add Broadcom STB RESCAL reset controller

Hi Philipp,

This patch series adds support for the BCM7216 RESCAL reset controller which is necessary to initialize SATA and PCIe0/1 on that chip.

Please let us know if you have any comments. Thanks!

Changes in v3:

- indented "base" variable with a space
- return ret directly out of readl_poll_timeout()
- removed additional register read after write, not necessary
- removed call to platform_set_drvdata, unnecessary either
- corrected Jim's email in Signed-off-by in patch #2

Changes in v2:

- binding document is in YAML format per Rob's suggestion
- indented bit definitions the same way for all definitions
- moved reset logic to the .reset() callback
- removed the XOR operation which is not necessary after clarifying with Jim that this was not necessary
- use readl_poll_timeout()

Jim Quinlan (2):
dt-bindings: reset: Document BCM7216 RESCAL reset controller
reset: Add Broadcom STB RESCAL reset controller

 .../reset/brcm,bcm7216-pcie-sata-rescal.yaml  |  37 ++++++
 drivers/reset/Kconfig                         |   7 ++
 drivers/reset/Makefile                        |   1 +
 drivers/reset/reset-brcmstb-rescal.c          | 107 ++++++++++++++++++
 4 files changed, 152 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm7216-pcie-sata-rescal.yaml
 create mode 100644 drivers/reset/reset-brcmstb-rescal.c
Signature · 1 line
2.17.1