Ensure extractor dependencies are taken into account
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 0 repliesNew
- v112 patches 0 repliesSuperseded
Changes in v2 from the cover letter
- Instead of fixing manually individual packages, directly derive extractor dependencies of EXTRA_DOWNLOADS files inside the generic-package infrastructure. Suggested by Yann. This allowed to greatly removed the number of patches in the series.
- Added Reviewed-by from Romain Naour on patches 1 and 4.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | package/pkg-utils.mk: rename extractor-dependency to extractor-system-dependencypackage/ package/ | +10 | 1 reply | |
| 2/5 | package/pkg-utils.mk: add extractor-pkg-dependency macropackage/ | +8 | 0 replies | |
| 3/5 | package/pkg-utils.mk: rework implementation of extractor-system-dependencypackage/ support/ support/ | +2 | 0 replies | |
| 4/5 | package/pkg-generic.mk: use extractor-pkg-dependency macropackage/ | +1 | 0 replies | |
| 5/5 | package/pkg-generic.mk: also apply extractor-pkg-dependency to <pkg>_EXTRA_DOWNLOADSpackage/ | +3 | 0 replies |
Reviews trailers per patch
2 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Romain Naour |
|---|---|
| 1/5 | R-b |
| 2/5 | |
| 3/5 | |
| 4/5 | R-b |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH v2 0/5] Ensure extractor dependencies are taken into account
Hello,
The starting point for this series is to fix the following build failure:
http://autobuild.buildroot.net/results/83c/83c6d47c06334bef27791a59bdd491b1de124c49/build-end.log
The problem is the following:
- The _SOURCE for gettext-tiny is a .tar.gz
- In addition to this _SOURCE tarball, we also extract the gettext-gnu source code, which is a .tar.xz
- Extracting .tar.xz may require building host-xzcat, is xzcat is not available system-wide
- The build fails because host-xzcat is not added in the dependencies of gettext-tiny. Indeed, while generic-package takes care of adding the extract dependencies needed for _SOURCE, it does not know about other extract dependencies.
This issue appears in
http://autobuild.buildroot.net/results/83c/83c6d47c06334bef27791a59bdd491b1de124c49/build-end.log
because BR2_PER_PACKAGE_DIRECTORIES=y and therefore any missing dependency is immediately visible. But in theory, it could appear without per-package support.
This series solves that by introducing an extractor-pkg-dependency that returns the list of packages that must be added to <pkg>_EXTRACT_DEPENDENCIES to extract the archive passed as argument. It is then used in package/pkg-generic.mk to replace the existing logic to calculate <pkg>_EXTRACT_DEPENDENCIES, and extended to take into account the extractor dependencies needed by _EXTRA_DOWNLOADS instead of just _SOURCE.
We also rename extractor-dependency to extractor-system-dependency to clarify its difference from extractor-pkg-dependency, and we rework the implementation of extractor-system-dependency.
Changes since v1:
- Instead of fixing manually individual packages, directly derive extractor dependencies of EXTRA_DOWNLOADS files inside the generic-package infrastructure. Suggested by Yann. This allowed to greatly removed the number of patches in the series.
- Added Reviewed-by from Romain Naour on patches 1 and 4.
Best regards,
Thomas Petazzoni
Thomas Petazzoni (5):
package/pkg-utils.mk: rename extractor-dependency to
extractor-system-dependency
package/pkg-utils.mk: add extractor-pkg-dependency macro package/pkg-utils.mk: rework implementation of
extractor-system-dependency
package/pkg-generic.mk: use extractor-pkg-dependency macro package/pkg-generic.mk: also apply extractor-pkg-dependency to
<pkg>_EXTRA_DOWNLOADS
package/pkg-generic.mk | 14 ++++---------- package/pkg-utils.mk | 24 ++++++++++++++++++------ support/dependencies/check-host-lzip.mk | 1 - support/dependencies/check-host-xzcat.mk | 1 - 4 files changed, 22 insertions(+), 18 deletions(-)
Signature · 1 line
2.23.0