btrfs: fixes for relocation to avoid KASAN reports
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: relocation: Fix a KASAN use-after-free bug due to extended reloc tree lifespanfs/ | +4 | 1 reply | |
| 2/3 | btrfs: relocation: Fix KASAN report on create_reloc_tree due to extended reloc tree lifepsanfs/ | +8 | 2 replies | |
| 3/3 | btrfs: relocation: Fix a KASAN report on btrfs_reloc_pre_snapshot() due to extended reloc root lifespanfs/ | +2 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Josef Bacik |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] btrfs: fixes for relocation to avoid KASAN reports
Due to commit d2311e698578 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots"), reloc tree lifespan is extended.
Although we always set root->reloc_root to NULL before we drop the reloc tree, but that's not multi-core safe since we have no proper memory barrier to ensure other cores can see the same root->reloc_root.
The proper root fix should be some proper root refcount, and make btrfs_drop_snapshot() to wait for all other root owner to release the root before dropping it.
But for now, let's just check the DEAD_RELOC_ROOT bit before accessing root->reloc_root.
Qu Wenruo (3):
btrfs: relocation: Fix a KASAN use-after-free bug due to extended
reloc tree lifespan
btrfs: relocation: Fix KASAN report on create_reloc_tree due to
extended reloc tree lifepsan
btrfs: relocation: Fix a KASAN report on btrfs_reloc_pre_snapshot()
due to extended reloc root lifespan
fs/btrfs/relocation.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
Signature · 1 line
2.24.0