Skip to content

sched: Get rid of select_task_rq()'s sd_flag parameter

Valentin Schneider lkml 4 versions – Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyApplied
  2. v39 patches 16 repliesApplied
  3. v29 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC7 patches2 repliesSuperseded

Changes in v4 from the cover letter

--------
o Dropped want_affine related patches
o Made WF_{TTWU, FORK, EXEC} and SD_BALANCE_{WAKE, FORK, EXEC} share a nibble (Peter)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3sched: Add WF_TTWU, WF_EXEC wakeup flagskernel/sched/sched.h+14 -70 replies
2/3sched: Remove select_task_rq()'s sd_flag parameterkernel/sched/core.c kernel/sched/deadline.c kernel/sched/fair.c +4 more+17 -150 replies
3/3sched/fair: Dissociate wakeup decisions from SD flag valuekernel/sched/fair.c+2 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] sched: Get rid of select_task_rq()'s sd_flag parameter

Hi folks,

This is v4 of that one series I've had stashed for a while [1]. I haven't revisited the outstanding discussion bits, the most interesting part being that we could get rid of the for_each_domain() loop in select_task_rq_fair() (or at the very least simplify it). In any case, the first few patches are IMO a decent cleanup on their own, hence me resubmitting them.

Links
=====

[1]: https://lore.kernel.org/lkml/[email protected]/

Revisions
=========

v3 -> v4
--------
o Dropped want_affine related patches
o Made WF_{TTWU, FORK, EXEC} and SD_BALANCE_{WAKE, FORK, EXEC} share a nibble (Peter)

v2 -> v3
--------
o Rebased on top of v5.7-rc1 (didn't re-run performance tests)
o Collected Reviewed-by (Dietmar)
o Updated changelog of 3/9 (Dietmar)

v1 -> v2
--------
o Removed the 'RFC' tag
o Made the sd_flags syctl read-only
o Removed the SD_LOAD_BALANCE flag
o Cleaned up ugly changes thanks to the above

Valentin Schneider (3):
sched: Add WF_TTWU, WF_EXEC wakeup flags
sched: Remove select_task_rq()'s sd_flag parameter sched/fair: Dissociate wakeup decisions from SD flag value

 kernel/sched/core.c      | 10 +++++-----
 kernel/sched/deadline.c  |  4 ++--
 kernel/sched/fair.c      | 13 +++++++------
 kernel/sched/idle.c      |  2 +-
 kernel/sched/rt.c        |  4 ++--
 kernel/sched/sched.h     | 23 +++++++++++++++--------
 kernel/sched/stop_task.c |  2 +-
 7 files changed, 33 insertions(+), 25 deletions(-)

--
2.27.0