virtiofs daemon [all]
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest109 patches 30 repliesIn review
- v1104 patches 201 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/109 | virtiofsd: Pull in upstream headerstools/ tools/ tools/ +5 more | +4814 | 0 replies | |
| 2/109 | virtiofsd: Pull in kernel's fuse.hinclude/ scripts/ | +892 | 0 replies | |
| 3/109 | virtiofsd: Add auxiliary .c'stools/ tools/ tools/ +2 more | +1315 | 0 replies | |
| 4/109 | virtiofsd: Add fuse_lowlevel.ctools/ | +3129 | 0 replies | |
| 5/109 | virtiofsd: Add passthrough_lltools/ | +1338 | 0 replies | |
| 6/109 | virtiofsd: Trim down imported filestools/ tools/ tools/ +8 more | +7 | 2 replies | |
| 7/109 | virtiofsd: Format imported files to qemu styletools/ tools/ tools/ +12 more | +6401 | 0 replies | |
| 8/109 | virtiofsd: remove mountpoint dummy argumenttools/ tools/ tools/ +1 more | +7 | 0 replies | |
| 9/109 | virtiofsd: remove unused notify reply supporttools/ tools/ | +1 | 0 replies | |
| 10/109 | virtiofsd: Fix fuse_daemonize ignored return valuestools/ | +22 | 1 reply | |
| 11/109 | virtiofsd: Fix common header and define for QEMU buildstools/ tools/ tools/ +3 more | +5 | 3 replies | |
| 12/109 | virtiofsd: Trim out compatibility codetools/ | +119 | 0 replies | |
| 13/109 | vitriofsd/passthrough_ll: fix fallocate() ifdefstools/ | +2 | 0 replies | |
| 14/109 | virtiofsd: Make fsync work even if only inode is passed intools/ tools/ | +31 | 0 replies | |
| 15/109 | virtiofsd: Add options for virtiotools/ tools/ tools/ | +19 | 1 reply | |
| 16/109 | virtiofsd: add -o source=PATH to help outputtools/ | +1 | 0 replies | |
| 17/109 | virtiofsd: Open vhost connection instead of mountingtools/ tools/ tools/ +1 more | +114 | 0 replies | |
| 18/109 | virtiofsd: Start wiring up vhost-usertools/ tools/ tools/ +3 more | +106 | 0 replies | |
| 19/109 | virtiofsd: Add main virtio looptools/ | +39 | 0 replies | |
| 20/109 | virtiofsd: get/set features callbackstools/ | +14 | 0 replies | |
| 21/109 | virtiofsd: Start queue threadstools/ | +89 | 0 replies | |
| 22/109 | virtiofsd: Poll kick_fd for queuetools/ | +39 | 0 replies | |
| 23/109 | virtiofsd: Start reading commands from queuetools/ tools/ | +98 | 0 replies | |
| 24/109 | virtiofsd: Send replies to messagestools/ tools/ tools/ | +111 | 0 replies | |
| 25/109 | virtiofsd: Keep track of repliestools/ | +20 | 0 replies | |
| 26/109 | virtiofsd: Add Makefile wiring for virtiofsd contribMakefile Makefile.objs tools/ | +20 | 0 replies | |
| 27/109 | virtiofsd: Fast path for virtio readtools/ tools/ tools/ | +171 | 0 replies | |
| 28/109 | virtiofsd: add --fd=FDNUM fd passing optiontools/ tools/ tools/ | +37 | 0 replies | |
| 29/109 | virtiofsd: make -f (foreground) the defaulttools/ | +8 | 0 replies | |
| 30/109 | virtiofsd: add vhost-user.json file.gitignore Makefile tools/ | +7 | 0 replies | |
| 31/109 | virtiofsd: add --print-capabilities optiondocs/ tools/ tools/ +1 more | +18 | 0 replies | |
| 32/109 | virtiofs: Add maintainers entryMAINTAINERS | +8 | 0 replies | |
| 33/109 | virtiofsd: passthrough_ll: create new files in caller's contexttools/ | +91 | 0 replies | |
| 34/109 | virtiofsd: passthrough_ll: add lo_map for ino/fh indirectiontools/ | +124 | 0 replies | |
| 35/109 | virtiofsd: passthrough_ll: add ino_map to hide lo_inode pointerstools/ | +114 | 0 replies | |
| 36/109 | virtiofsd: passthrough_ll: add dirp_map to hide lo_dirp pointerstools/ | +76 | 0 replies | |
| 37/109 | virtiofsd: passthrough_ll: add fd_map to hide file descriptorstools/ | +94 | 0 replies | |
| 38/109 | virtiofsd: passthrough_ll: add fallback for racy opstools/ tools/ | +145 | 0 replies | |
| 39/109 | virtiofsd: validate path componentstools/ | +53 | 0 replies | |
| 40/109 | virtiofsd: Plumb fuse_bufvec through to do_write_buftools/ tools/ tools/ | +44 | 0 replies | |
| 41/109 | virtiofsd: Pass write iov's all the way throughtools/ | +73 | 0 replies | |
| 42/109 | virtiofsd: add fuse_mbuf_iter APItools/ tools/ | +76 | 0 replies | |
| 43/109 | virtiofsd: validate input buffer sizes in do_write_buf()tools/ | +30 | 0 replies | |
| 44/109 | virtiofsd: check input buffer size in fuse_lowlevel.c opstools/ | +456 | 0 replies | |
| 45/109 | virtiofsd: prevent ".." escape in lo_do_lookup()tools/ | +6 | 0 replies | |
| 46/109 | virtiofsd: prevent ".." escape in lo_do_readdir()tools/ | +22 | 0 replies | |
| 47/109 | virtiofsd: use /proc/self/fd/ O_PATH file descriptortools/ | +103 | 0 replies | |
| 48/109 | virtiofsd: sandbox mount namespacetools/ | +89 | 0 replies | |
| 49/109 | virtiofsd: move to an empty network namespacetools/ | +14 | 0 replies | |
| 50/109 | virtiofsd: move to a new pid namespacetools/ | +86 | 0 replies | |
| 51/109 | virtiofsd: add seccomp whitelistMakefile tools/ tools/ +2 more | +171 | 7 replies | |
| 52/109 | virtiofsd: Parse flag FUSE_WRITE_KILL_PRIVtools/ tools/ | +8 | 0 replies | |
| 53/109 | virtiofsd: cap-ng helpersMakefile tools/ | +73 | 0 replies | |
| 54/109 | virtiofsd: Drop CAP_FSETID if client asked for ittools/ | +105 | 0 replies | |
| 55/109 | virtiofsd: set maximum RLIMIT_NOFILE limittools/ | +32 | 0 replies | |
| 56/109 | virtiofsd: fix libfuse information leakstools/ | +76 | 0 replies | |
| 57/109 | docs: Add docs/toolsMakefile docs/ docs/ +1 more | +37 | 1 reply | |
| 58/109 | virtiofsd: add security guide documentdocs/ docs/ | +120 | 0 replies | |
| 59/109 | virtiofsd: add --syslog command-line optiontools/ tools/ tools/ +2 more | +76 | 0 replies | |
| 60/109 | virtiofsd: print log only when priority is high enoughtools/ tools/ tools/ +1 more | +87 | 0 replies | |
| 61/109 | virtiofsd: Add ID to the log with FUSE_LOG_DEBUG leveltools/ | +8 | 1 reply | |
| 62/109 | virtiofsd: Add timestamp to the log with FUSE_LOG_DEBUG leveltools/ | +9 | 2 replies | |
| 63/109 | virtiofsd: Handle reinittools/ | +2 | 0 replies | |
| 64/109 | virtiofsd: Handle hard reboottools/ | +15 | 0 replies | |
| 65/109 | virtiofsd: Kill threads when queues are stoppedtools/ | +44 | 0 replies | |
| 66/109 | vhost-user: Print unexpected slave message typeshw/ | +1 | 2 replies | |
| 67/109 | contrib/libvhost-user: Protect slave fd with mutexcontrib/ contrib/ | +23 | 0 replies | |
| 68/109 | virtiofsd: passthrough_ll: add renameat2 supporttools/ | +10 | 0 replies | |
| 69/109 | virtiofsd: passthrough_ll: disable readdirplus on cache=nevertools/ | +4 | 0 replies | |
| 70/109 | virtiofsd: passthrough_ll: control readdirplustools/ tools/ | +9 | 2 replies | |
| 71/109 | virtiofsd: rename unref_inode() to unref_inode_lolocked()tools/ | +8 | 0 replies | |
| 72/109 | virtiofsd: fail when parent inode isn't known in lo_do_lookup()tools/ | +12 | 0 replies | |
| 73/109 | virtiofsd: extract root inode init into setup_root()tools/ | +25 | 1 reply | |
| 74/109 | virtiofsd: passthrough_ll: clean up cache related optionstools/ tools/ | +13 | 0 replies | |
| 75/109 | virtiofsd: passthrough_ll: use hashtabletools/ | +45 | 0 replies | |
| 76/109 | virtiofsd: Clean up inodes on destroytools/ | +26 | 0 replies | |
| 77/109 | virtiofsd: support nanosecond resolution for file timestampconfigure tools/ | +17 | 0 replies | |
| 78/109 | virtiofsd: fix error handling in main()tools/ | +3 | 0 replies | |
| 79/109 | virtiofsd: cleanup allocated resource in setools/ tools/ tools/ | +15 | 0 replies | |
| 80/109 | virtiofsd: fix memory leak on lo.sourcetools/ | +4 | 1 reply | |
| 81/109 | virtiofsd: add helper for lo_data cleanuptools/ | +21 | 0 replies | |
| 82/109 | virtiofsd: Prevent multiply running with same vhost_user_sockettools/ tools/ | +49 | 0 replies | |
| 83/109 | virtiofsd: enable PARALLEL_DIROPS during INITtools/ | +3 | 0 replies | |
| 84/109 | virtiofsd: fix incorrect error handling in lo_do_lookuptools/ | +0 | 0 replies | |
| 85/109 | Virtiofsd: fix memory leak on fuse queueinfotools/ | +8 | 0 replies | |
| 86/109 | virtiofsd: Support remote posix lockstools/ tools/ | +192 | 0 replies | |
| 87/109 | virtiofsd: use fuse_lowlevel_is_virtio() in fuse_session_destroy()tools/ | +4 | 0 replies | |
| 88/109 | virtiofsd: prevent fv_queue_thread() vs virtio_loop() racestools/ | +33 | 0 replies | |
| 89/109 | virtiofsd: make lo_release() atomictools/ | +8 | 0 replies | |
| 90/109 | virtiofsd: prevent races with lo_dirp_put()tools/ | +35 | 0 replies | |
| 91/109 | virtiofsd: rename inode->refcount to inode->nlookuptools/ | +25 | 0 replies | |
| 92/109 | libvhost-user: Fix some memtable remap casescontrib/ contrib/ | +28 | 0 replies | |
| 93/109 | virtiofsd: add man pageMakefile tools/ | +111 | 1 reply | |
| 94/109 | virtiofsd: passthrough_ll: fix refcounting on remove/renametools/ | +49 | 0 replies | |
| 95/109 | virtiofsd: introduce inode refcount to prevent use-after-freetools/ | +146 | 0 replies | |
| 96/109 | virtiofsd: do not always set FUSE_FLOCK_LOCKStools/ | +8 | 0 replies | |
| 97/109 | virtiofsd: convert more fprintf and perror to use fuse log infratools/ tools/ | +11 | 1 reply | |
| 98/109 | virtiofsd: Reset O_DIRECT flag during file opentools/ | +14 | 0 replies | |
| 99/109 | virtiofsd: Fix data corruption with O_APPEND write in writeback modetools/ | +33 | 0 replies | |
| 100/109 | virtiofsd: add definition of fuse_buf_writev()tools/ | +38 | 0 replies | |
| 101/109 | virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better performancetools/ | +18 | 0 replies | |
| 102/109 | virtiofsd: process requests in a thread pooltools/ | +201 | 0 replies | |
| 103/109 | virtiofsd: prevent FUSE_INIT/FUSE_DESTROY racestools/ tools/ | +19 | 0 replies | |
| 104/109 | virtiofsd: fix lo_destroy() resource leakstools/ | +20 | 0 replies | |
| 105/109 | virtiofsd: add --thread-pool-size=NUM optiontools/ tools/ tools/ | +10 | 0 replies | |
| 106/109 | virtiofsd: Convert lo_destroy to take the lo->mutex lock itselftools/ | +17 | 0 replies | |
| 107/109 | virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()tools/ | +1 | 0 replies | |
| 108/109 | virtiofsd: stop all queue threads on exit in virtio_loop()tools/ | +12 | 0 replies | |
| 109/109 | virtiofsd: add some options to the help messagetools/ | +9 | 2 replies |
Reviews trailers per patch
103 of 109 patches have a Reviewed-by or Acked-by.
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.
Cover letter [PATCH v2 000/109] virtiofs daemon [all]
From: "Dr. David Alan Gilbert" <[email protected]>
Hi,
This is a full set for virtiofsd - a daemon
that implements the user space side of virtiofs.
I've addressed most review comments from V1; we've got 95 Reviewed-by's out of 110 - I'd like to get a PULL out ASAP.
The set pulls in a big chunk of the upstream libfuse library (unmodified so that it's easy to check it really is upstream), chops all the stuff out we don't need and then adds the
new transport we need. I've formatted everything into qemu's code style - using indent and the clang tools for the files I've imported.
We can't just link with libfuse, since we have to make ABI incompatible changes for the new transport and it's quite invasive; the library is designed to be the basis for multiple filesystems, but all on the same transport.
Running this daemon is typically done with:
./virtiofsd --socket-path=/path/socket -o source=/path/to/fs
connected to a qemu that's then started with:
-chardev socket,id=char0,path=/path/socket -device vhost-user-fs-pci,queue-size=1024,chardev=char0,tag=myfs
and then in the guest mount with:
mount -t virtiofs myfs /mnt
Our development branch is: https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev
This code is going into tools/virtiofsd based on the previous long discussion.
Thank you to all those who have contributed code and to those who have reviewed the previous version.
Dave
Dr. David Alan Gilbert (35):
virtiofsd: Pull in upstream headers
virtiofsd: Pull in kernel's fuse.h
virtiofsd: Add auxiliary .c's
virtiofsd: Add fuse_lowlevel.c
virtiofsd: Add passthrough_ll
virtiofsd: Trim down imported files
virtiofsd: Format imported files to qemu style
virtiofsd: Fix fuse_daemonize ignored return values
virtiofsd: Fix common header and define for QEMU builds
virtiofsd: Trim out compatibility code
virtiofsd: Add options for virtio
virtiofsd: Open vhost connection instead of mounting
virtiofsd: Start wiring up vhost-user
virtiofsd: Add main virtio loop
virtiofsd: get/set features callbacks
virtiofsd: Start queue threads
virtiofsd: Poll kick_fd for queue
virtiofsd: Start reading commands from queue
virtiofsd: Send replies to messages
virtiofsd: Keep track of replies
virtiofsd: Add Makefile wiring for virtiofsd contrib
virtiofsd: Fast path for virtio read
virtiofs: Add maintainers entry
virtiofsd: Plumb fuse_bufvec through to do_write_buf
virtiofsd: Pass write iov's all the way through
virtiofsd: cap-ng helpers
docs: Add docs/tools
virtiofsd: Handle reinit
virtiofsd: Handle hard reboot
virtiofsd: Kill threads when queues are stopped
vhost-user: Print unexpected slave message types contrib/libvhost-user: Protect slave fd with mutex
virtiofsd: Clean up inodes on destroy
libvhost-user: Fix some memtable remap cases
virtiofsd: Convert lo_destroy to take the lo->mutex lock itself
Eric Ren (1):
virtiofsd: fix incorrect error handling in lo_do_lookup
Eryu Guan (3):
virtiofsd: print log only when priority is high enough
virtiofsd: convert more fprintf and perror to use fuse log infra
virtiofsd: stop all queue threads on exit in virtio_loop()
Jiufei Xue (1):
virtiofsd: support nanosecond resolution for file timestamp
Liu Bo (6):
virtiofsd: fix error handling in main()
virtiofsd: cleanup allocated resource in se
virtiofsd: fix memory leak on lo.source
virtiofsd: add helper for lo_data cleanup
virtiofsd: enable PARALLEL_DIROPS during INIT
Virtiofsd: fix memory leak on fuse queueinfo
Masayoshi Mizuma (4):
virtiofsd: Add ID to the log with FUSE_LOG_DEBUG level
virtiofsd: Add timestamp to the log with FUSE_LOG_DEBUG level
virtiofsd: Prevent multiply running with same vhost_user_socket
virtiofsd: add some options to the help message
Miklos Szeredi (10):
virtiofsd: passthrough_ll: add fallback for racy ops
virtiofsd: passthrough_ll: add renameat2 support
virtiofsd: passthrough_ll: disable readdirplus on cache=never
virtiofsd: passthrough_ll: control readdirplus
virtiofsd: rename unref_inode() to unref_inode_lolocked()
virtiofsd: fail when parent inode isn't known in lo_do_lookup()
virtiofsd: extract root inode init into setup_root()
virtiofsd: passthrough_ll: clean up cache related options
virtiofsd: passthrough_ll: use hashtable
virtiofsd: passthrough_ll: fix refcounting on remove/rename
Misono Tomohiro (1):
virtiofsd: Fix data corruption with O_APPEND write in writeback mode
Peng Tao (1):
virtiofsd: do not always set FUSE_FLOCK_LOCKS
Stefan Hajnoczi (37):
virtiofsd: remove mountpoint dummy argument
virtiofsd: remove unused notify reply support
virtiofsd: add -o source=PATH to help output
virtiofsd: add --fd=FDNUM fd passing option
virtiofsd: make -f (foreground) the default
virtiofsd: add vhost-user.json file
virtiofsd: add --print-capabilities option
virtiofsd: passthrough_ll: add lo_map for ino/fh indirection
virtiofsd: passthrough_ll: add ino_map to hide lo_inode pointers
virtiofsd: passthrough_ll: add dirp_map to hide lo_dirp pointers
virtiofsd: passthrough_ll: add fd_map to hide file descriptors
virtiofsd: validate path components
virtiofsd: add fuse_mbuf_iter API
virtiofsd: validate input buffer sizes in do_write_buf()
virtiofsd: check input buffer size in fuse_lowlevel.c ops
virtiofsd: prevent ".." escape in lo_do_lookup()
virtiofsd: prevent ".." escape in lo_do_readdir()
virtiofsd: use /proc/self/fd/ O_PATH file descriptor
virtiofsd: sandbox mount namespace
virtiofsd: move to an empty network namespace
virtiofsd: move to a new pid namespace
virtiofsd: add seccomp whitelist
virtiofsd: set maximum RLIMIT_NOFILE limit
virtiofsd: fix libfuse information leaks
virtiofsd: add security guide document
virtiofsd: add --syslog command-line option
virtiofsd: use fuse_lowlevel_is_virtio() in fuse_session_destroy()
virtiofsd: prevent fv_queue_thread() vs virtio_loop() races
virtiofsd: make lo_release() atomic
virtiofsd: prevent races with lo_dirp_put()
virtiofsd: rename inode->refcount to inode->nlookup
virtiofsd: add man page
virtiofsd: introduce inode refcount to prevent use-after-free
virtiofsd: process requests in a thread pool
virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races
virtiofsd: fix lo_destroy() resource leaks
virtiofsd: add --thread-pool-size=NUM option
Vivek Goyal (6):
virtiofsd: Make fsync work even if only inode is passed in
virtiofsd: passthrough_ll: create new files in caller's context
virtiofsd: Parse flag FUSE_WRITE_KILL_PRIV
virtiofsd: Drop CAP_FSETID if client asked for it
virtiofsd: Support remote posix locks
virtiofsd: Reset O_DIRECT flag during file open
Xiao Yang (2):
vitriofsd/passthrough_ll: fix fallocate() ifdefs virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()
piaojun (2):
virtiofsd: add definition of fuse_buf_writev()
virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better
performance
.gitignore | 1 + MAINTAINERS | 8 + Makefile | 27 +- Makefile.objs | 1 + configure | 16 + contrib/libvhost-user/libvhost-user.c | 57 +- contrib/libvhost-user/libvhost-user.h | 6 + docs/index.rst | 1 + docs/interop/vhost-user.json | 4 +- docs/tools/conf.py | 16 + docs/tools/index.rst | 14 + docs/tools/virtiofsd-security.rst | 118 + hw/virtio/vhost-user.c | 2 +- include/standard-headers/linux/fuse.h | 891 ++++++ scripts/update-linux-headers.sh | 1 + tools/virtiofsd/50-qemu-virtiofsd.json.in | 5 + tools/virtiofsd/Makefile.objs | 12 + tools/virtiofsd/buffer.c | 351 +++ tools/virtiofsd/fuse.h | 1249 +++++++++ tools/virtiofsd/fuse_common.h | 860 ++++++ tools/virtiofsd/fuse_i.h | 115 + tools/virtiofsd/fuse_log.c | 40 + tools/virtiofsd/fuse_log.h | 74 + tools/virtiofsd/fuse_lowlevel.c | 2779 +++++++++++++++++++ tools/virtiofsd/fuse_lowlevel.h | 2023 ++++++++++++++ tools/virtiofsd/fuse_misc.h | 60 + tools/virtiofsd/fuse_opt.c | 449 +++ tools/virtiofsd/fuse_opt.h | 272 ++ tools/virtiofsd/fuse_signals.c | 97 + tools/virtiofsd/fuse_virtio.c | 985 +++++++ tools/virtiofsd/fuse_virtio.h | 33 + tools/virtiofsd/helper.c | 349 +++ tools/virtiofsd/passthrough_helpers.h | 51 + tools/virtiofsd/passthrough_ll.c | 3006 +++++++++++++++++++++ tools/virtiofsd/seccomp.c | 164 ++ tools/virtiofsd/seccomp.h | 16 + tools/virtiofsd/virtiofsd.texi | 104 + 37 files changed, 14242 insertions(+), 15 deletions(-) create mode 100644 docs/tools/conf.py create mode 100644 docs/tools/index.rst create mode 100644 docs/tools/virtiofsd-security.rst create mode 100644 include/standard-headers/linux/fuse.h create mode 100644 tools/virtiofsd/50-qemu-virtiofsd.json.in create mode 100644 tools/virtiofsd/Makefile.objs create mode 100644 tools/virtiofsd/buffer.c create mode 100644 tools/virtiofsd/fuse.h create mode 100644 tools/virtiofsd/fuse_common.h create mode 100644 tools/virtiofsd/fuse_i.h create mode 100644 tools/virtiofsd/fuse_log.c create mode 100644 tools/virtiofsd/fuse_log.h create mode 100644 tools/virtiofsd/fuse_lowlevel.c create mode 100644 tools/virtiofsd/fuse_lowlevel.h create mode 100644 tools/virtiofsd/fuse_misc.h create mode 100644 tools/virtiofsd/fuse_opt.c create mode 100644 tools/virtiofsd/fuse_opt.h create mode 100644 tools/virtiofsd/fuse_signals.c create mode 100644 tools/virtiofsd/fuse_virtio.c create mode 100644 tools/virtiofsd/fuse_virtio.h create mode 100644 tools/virtiofsd/helper.c create mode 100644 tools/virtiofsd/passthrough_helpers.h create mode 100644 tools/virtiofsd/passthrough_ll.c create mode 100644 tools/virtiofsd/seccomp.c create mode 100644 tools/virtiofsd/seccomp.h create mode 100644 tools/virtiofsd/virtiofsd.texi
Signature · 1 line
2.24.1