Skip to content

tcp: take care of empty skbs in write queue

Eric Dumazet netdev 1 version Applied

Status from this message: Applied, thank you!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3tcp: do not send empty skb from tcp_write_xmit()net/ipv4/tcp_output.c+8 -01 reply
2/3tcp: refine tcp_write_queue_empty() implementationinclude/net/tcp.h net/ipv4/tcp_output.c+13 -31 reply
3/3tcp: refine rule to allow EPOLLOUT generation under mem pressurenet/ipv4/tcp.c+2 -41 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNeal CardwellSoheil Hassas Yeganeh
1/3A-b A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] tcp: take care of empty skbs in write queue

We understood recently that TCP sockets could have an empty skb at the tail of the write queue, leading to various problems.

This patch series :

1) Make sure we do not send an empty packet since this was unintended and causing crashes in old kernels.

2) Change tcp_write_queue_empty() to not be fooled by the presence of an empty skb.

3) Fix a bug that could trigger suboptimal epoll() application behavior under memory pressure.

Eric Dumazet (3):
tcp: do not send empty skb from tcp_write_xmit()
tcp: refine tcp_write_queue_empty() implementation
tcp: refine rule to allow EPOLLOUT generation under mem pressure

 include/net/tcp.h     | 11 ++++++++++-
 net/ipv4/tcp.c        |  6 ++----
 net/ipv4/tcp_output.c | 13 +++++++++++--
 3 files changed, 23 insertions(+), 7 deletions(-)
Signature · 1 line
2.24.1.735.g03f4e72817-goog