tcp: take care of empty skbs in write queue
Status from this message: Applied, thank you!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tcp: do not send empty skb from tcp_write_xmit()net/ | +8 | 1 reply | |
| 2/3 | tcp: refine tcp_write_queue_empty() implementationinclude/ net/ | +13 | 1 reply | |
| 3/3 | tcp: refine rule to allow EPOLLOUT generation under mem pressurenet/ | +2 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Neal Cardwell | Soheil Hassas Yeganeh |
|---|---|---|
| 1/3 | A-b | A-b |
| 2/3 | A-b | |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/3] tcp: take care of empty skbs in write queue
We understood recently that TCP sockets could have an empty skb at the tail of the write queue, leading to various problems.
This patch series :
1) Make sure we do not send an empty packet since this was unintended and causing crashes in old kernels.
2) Change tcp_write_queue_empty() to not be fooled by the presence of an empty skb.
3) Fix a bug that could trigger suboptimal epoll() application behavior under memory pressure.
Eric Dumazet (3):
tcp: do not send empty skb from tcp_write_xmit()
tcp: refine tcp_write_queue_empty() implementation
tcp: refine rule to allow EPOLLOUT generation under mem pressure
include/net/tcp.h | 11 ++++++++++- net/ipv4/tcp.c | 6 ++---- net/ipv4/tcp_output.c | 13 +++++++++++-- 3 files changed, 23 insertions(+), 7 deletions(-)
Signature · 1 line
2.24.1.735.g03f4e72817-goog