serial/sysrq: Cleanup ifdeffery
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest58 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/58 | sysrq: Remove sysrq_handler_registereddrivers/ | +1 | 0 replies | |
| 2/58 | serial: Move sysrq members aboveinclude/ | +6 | 1 reply | |
| 3/58 | serial_core: Un-ifdef sysrq SUPPORT_SYSRQinclude/ | +43 | 3 replies | |
| 4/58 | tty/serial: Migrate aspeed_vuart to use has_sysrqdrivers/ | +1 | 1 reply | |
| 5/58 | tty/serial: Migrate 8250_fsl to use has_sysrqarch/ drivers/ drivers/ | +6 | 0 replies | |
| 6/58 | tty/serial: Migrate bcm63xx_uart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 7/58 | tty/serial: Migrate 8250_omap to use has_sysrqdrivers/ | +1 | 0 replies | |
| 8/58 | tty/serial: Migrate 8250_port to use has_sysrqdrivers/ | +1 | 0 replies | |
| 9/58 | tty/serial: Migrate amba-pl01* to use has_sysrqdrivers/ drivers/ | +2 | 0 replies | |
| 10/58 | tty/serial: Migrate apbuart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 11/58 | tty/serial: Migrate arc_uart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 12/58 | tty/serial: Migrate atmel_serial to use has_sysrqdrivers/ | +1 | 0 replies | |
| 13/58 | tty/serial: Migrate clps711x to use has_sysrqdrivers/ | +1 | 0 replies | |
| 14/58 | tty/serial: Migrate cpm_uart to use has_sysrqdrivers/ | +2 | 0 replies | |
| 15/58 | tty/serial: Migrate dz to use has_sysrqdrivers/ | +1 | 0 replies | |
| 16/58 | tty/serial: Migrate efm32-uart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 17/58 | tty/serial: Migrate fsl_linflexuart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 18/58 | tty/serial: Migrate fsl_lpuart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 19/58 | tty/serial: Migrate imx to use has_sysrqdrivers/ | +1 | 0 replies | |
| 20/58 | tty/serial: Migrate ip22zilog to use has_sysrqdrivers/ | +3 | 0 replies | |
| 21/58 | tty/serial: Migrate meson_uart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 22/58 | tty/serial: Migrate milbeaut_usio to use has_sysrqdrivers/ | +1 | 0 replies | |
| 23/58 | tty/serial: Migrate mpc52xx_uart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 24/58 | tty/serial: Don't zero port->sysrqdrivers/ | +1 | 0 replies | |
| 25/58 | tty/serial: Migrate msm_serial to use has_sysrqdrivers/ | +1 | 0 replies | |
| 26/58 | tty/serial: Migrate mux to use has_sysrqdrivers/ | +1 | 0 replies | |
| 27/58 | tty/serial: Migrate mxs-auart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 28/58 | tty/serial: Migrate omap-serial to use has_sysrqdrivers/ | +1 | 0 replies | |
| 29/58 | tty/serial: Migrate pch_uart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 30/58 | tty/serial: Don't check port->sysrqdrivers/ | +2 | 0 replies | |
| 31/58 | tty/serial: Migrate pmac_zilog to use has_sysrqdrivers/ | +1 | 0 replies | |
| 32/58 | tty/serial: Migrate pnx8xxx_uart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 33/58 | serial/f81534: Don't check port->sysrqdrivers/ | +2 | 2 replies | |
| 34/58 | tty/serial: Migrate pxa to use has_sysrqdrivers/ | +1 | 0 replies | |
| 35/58 | tty/serial: Migrate qcom_geni_serial to use has_sysrqdrivers/ | +1 | 0 replies | |
| 36/58 | tty/serial: Migrate sa1100 to use has_sysrqdrivers/ | +1 | 0 replies | |
| 37/58 | tty/serial: Migrate samsung_tty to use has_sysrqdrivers/ | +1 | 0 replies | |
| 38/58 | tty/serial: Migrate sb1250-duart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 39/58 | tty/serial: Migrate sccnxp to use has_sysrqdrivers/ | +1 | 0 replies | |
| 40/58 | tty/serial: Migrate serial_txx9 to use has_sysrqdrivers/ | +1 | 0 replies | |
| 41/58 | tty/serial: Migrate sh-sci to use has_sysrqdrivers/ | +2 | 0 replies | |
| 42/58 | tty/serial: Migrate sprd_serial to use has_sysrqdrivers/ | +1 | 1 reply | |
| 43/58 | tty/serial: Migrate st-asc to use has_sysrqdrivers/ | +1 | 0 replies | |
| 44/58 | tty/serial: Migrate stm32-usart to use has_sysrqdrivers/ | +1 | 0 replies | |
| 45/58 | tty/serial: Migrate sunhv to use has_sysrqdrivers/ | +1 | 0 replies | |
| 46/58 | tty/serial: Migrate sunsab to use has_sysrqdrivers/ | +1 | 0 replies | |
| 47/58 | tty/serial: Migrate sunsu to use has_sysrqdrivers/ | +1 | 0 replies | |
| 48/58 | tty/serial: Migrate sunzilog to use has_sysrqdrivers/ | +2 | 0 replies | |
| 49/58 | serial/ucc_uart: Remove ifdef SUPPORT_SYSRQdrivers/ | +0 | 0 replies | |
| 50/58 | tty/serial: Migrate vr41xx_siu to use has_sysrqdrivers/ | +1 | 0 replies | |
| 51/58 | tty/serial: Migrate vt8500_serial to use has_sysrqdrivers/ | +1 | 0 replies | |
| 52/58 | tty/serial: Migrate xilinx_uartps to use has_sysrqdrivers/ | +1 | 0 replies | |
| 53/58 | tty/serial: Migrate zs to use has_sysrqdrivers/ | +1 | 0 replies | |
| 54/58 | serial_core: Remove SUPPORT_SYSRQ ifdefferyinclude/ | +4 | 2 replies | |
| 55/58 | usb/serial: Don't handle break when CONFIG_MAGIC_SYSRQ is disableddrivers/ | +3 | 0 replies | |
| 56/58 | serial_core: Move sysrq functions from header filedrivers/ include/ | +88 | 0 replies | |
| 57/58 | sysctl/sysrq: Remove __sysrq_enabled copydrivers/ include/ kernel/ | +30 | 0 replies | |
| 58/58 | serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCEdrivers/ include/ lib/ | +55 | 0 replies |
Reviews trailers per patch
2 of 58 patches have a Reviewed-by or Acked-by.
| Patch | Vasiliy Khoruzhick | Andrew Jeffery | Chunyan Zhang |
|---|---|---|---|
| 1/58 | |||
| 2/58 | |||
| 3/58 | |||
| 4/58 | A-b | ||
| 5/58 | |||
| 6/58 | |||
| 7/58 | |||
| 8/58 | |||
| 9/58 | |||
| 10/58 | |||
| 11/58 | |||
| 12/58 | |||
| 13/58 | |||
| 14/58 | |||
| 15/58 | |||
| 16/58 | |||
| 17/58 | |||
| 18/58 | |||
| 19/58 | |||
| 20/58 | |||
| 21/58 | |||
| 22/58 | |||
| 23/58 | |||
| 24/58 | |||
| 25/58 | |||
| 26/58 | |||
| 27/58 | |||
| 28/58 | |||
| 29/58 | |||
| 30/58 | |||
| 31/58 | |||
| 32/58 | |||
| 33/58 | |||
| 34/58 | |||
| 35/58 | |||
| 36/58 | |||
| 37/58 | |||
| 38/58 | |||
| 39/58 | |||
| 40/58 | |||
| 41/58 | |||
| 42/58 | A-b | ||
| 43/58 | |||
| 44/58 | |||
| 45/58 | |||
| 46/58 | |||
| 47/58 | |||
| 48/58 | |||
| 49/58 | |||
| 50/58 | |||
| 51/58 | |||
| 52/58 | |||
| 53/58 | |||
| 54/58 | |||
| 55/58 | |||
| 56/58 | |||
| 57/58 | |||
| 58/58 | Based-on-patch-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/58] serial/sysrq: Cleanup ifdeffery
The original purpose of the patches set was to add a way to enable sysrq on a uart where currently it can be constantly either on or off (CONFIG_MAGIC_SYSRQ_SERIAL), see the last patch:
"serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE"
But to do that, I had to add uart_try_toggle_sysrq() and I didn't want to bloat serial_core.h even more. So, I did cleanup by removing SUPPORT_SYSRQ resulting in a nice diff-stat and lesser ifdeffery.
Most patches are one-liners, I decided to keep them separated per-driver to let reviewers easier follow the purpose.
Dmitry Safonov (58):
sysrq: Remove sysrq_handler_registered
serial: Move sysrq members above
serial_core: Un-ifdef sysrq SUPPORT_SYSRQ
tty/serial: Migrate aspeed_vuart to use has_sysrq tty/serial: Migrate 8250_fsl to use has_sysrq tty/serial: Migrate bcm63xx_uart to use has_sysrq tty/serial: Migrate 8250_omap to use has_sysrq tty/serial: Migrate 8250_port to use has_sysrq tty/serial: Migrate amba-pl01* to use has_sysrq tty/serial: Migrate apbuart to use has_sysrq tty/serial: Migrate arc_uart to use has_sysrq tty/serial: Migrate atmel_serial to use has_sysrq tty/serial: Migrate clps711x to use has_sysrq tty/serial: Migrate cpm_uart to use has_sysrq tty/serial: Migrate dz to use has_sysrq
tty/serial: Migrate efm32-uart to use has_sysrq tty/serial: Migrate fsl_linflexuart to use has_sysrq tty/serial: Migrate fsl_lpuart to use has_sysrq tty/serial: Migrate imx to use has_sysrq
tty/serial: Migrate ip22zilog to use has_sysrq tty/serial: Migrate meson_uart to use has_sysrq tty/serial: Migrate milbeaut_usio to use has_sysrq tty/serial: Migrate mpc52xx_uart to use has_sysrq tty/serial: Don't zero port->sysrq
tty/serial: Migrate msm_serial to use has_sysrq tty/serial: Migrate mux to use has_sysrq
tty/serial: Migrate mxs-auart to use has_sysrq tty/serial: Migrate omap-serial to use has_sysrq tty/serial: Migrate pch_uart to use has_sysrq tty/serial: Don't check port->sysrq
tty/serial: Migrate pmac_zilog to use has_sysrq tty/serial: Migrate pnx8xxx_uart to use has_sysrq serial/f81534: Don't check port->sysrq
tty/serial: Migrate pxa to use has_sysrq
tty/serial: Migrate qcom_geni_serial to use has_sysrq tty/serial: Migrate sa1100 to use has_sysrq
tty/serial: Migrate samsung_tty to use has_sysrq tty/serial: Migrate sb1250-duart to use has_sysrq tty/serial: Migrate sccnxp to use has_sysrq
tty/serial: Migrate serial_txx9 to use has_sysrq tty/serial: Migrate sh-sci to use has_sysrq
tty/serial: Migrate sprd_serial to use has_sysrq tty/serial: Migrate st-asc to use has_sysrq
tty/serial: Migrate stm32-usart to use has_sysrq tty/serial: Migrate sunhv to use has_sysrq
tty/serial: Migrate sunsab to use has_sysrq
tty/serial: Migrate sunsu to use has_sysrq
tty/serial: Migrate sunzilog to use has_sysrq serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ
tty/serial: Migrate vr41xx_siu to use has_sysrq tty/serial: Migrate vt8500_serial to use has_sysrq tty/serial: Migrate xilinx_uartps to use has_sysrq tty/serial: Migrate zs to use has_sysrq
serial_core: Remove SUPPORT_SYSRQ ifdeffery
usb/serial: Don't handle break when CONFIG_MAGIC_SYSRQ is disabled
serial_core: Move sysrq functions from header file sysctl/sysrq: Remove __sysrq_enabled copy
serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
arch/powerpc/kernel/legacy_serial.c | 4 +- drivers/tty/serial/8250/8250_aspeed_vuart.c | 5 +- drivers/tty/serial/8250/8250_fsl.c | 4 - drivers/tty/serial/8250/8250_of.c | 4 +- drivers/tty/serial/8250/8250_omap.c | 5 +- drivers/tty/serial/8250/8250_port.c | 5 +- drivers/tty/serial/amba-pl010.c | 5 +- drivers/tty/serial/amba-pl011.c | 6 +- drivers/tty/serial/apbuart.c | 5 +- drivers/tty/serial/arc_uart.c | 5 +- drivers/tty/serial/atmel_serial.c | 9 +- drivers/tty/serial/bcm63xx_uart.c | 5 +- drivers/tty/serial/clps711x.c | 5 +- drivers/tty/serial/cpm_uart/cpm_uart_core.c | 9 +- drivers/tty/serial/dz.c | 5 +- drivers/tty/serial/efm32-uart.c | 5 +- drivers/tty/serial/fsl_linflexuart.c | 8 +- drivers/tty/serial/fsl_lpuart.c | 9 +- drivers/tty/serial/imx.c | 7 +- drivers/tty/serial/ip22zilog.c | 7 +- drivers/tty/serial/meson_uart.c | 5 +- drivers/tty/serial/milbeaut_usio.c | 5 +- drivers/tty/serial/mpc52xx_uart.c | 11 +- drivers/tty/serial/msm_serial.c | 5 +- drivers/tty/serial/mux.c | 5 +- drivers/tty/serial/mxs-auart.c | 5 +- drivers/tty/serial/omap-serial.c | 5 +- drivers/tty/serial/pch_uart.c | 12 +- drivers/tty/serial/pmac_zilog.c | 5 +- drivers/tty/serial/pnx8xxx_uart.c | 7 +- drivers/tty/serial/pxa.c | 5 +- drivers/tty/serial/qcom_geni_serial.c | 5 +- drivers/tty/serial/sa1100.c | 7 +- drivers/tty/serial/samsung_tty.c | 5 +- drivers/tty/serial/sb1250-duart.c | 5 +- drivers/tty/serial/sccnxp.c | 5 +- drivers/tty/serial/serial_core.c | 123 ++++++++++++++++++++ drivers/tty/serial/serial_txx9.c | 5 +- drivers/tty/serial/sh-sci.c | 10 +- drivers/tty/serial/sprd_serial.c | 5 +- drivers/tty/serial/st-asc.c | 5 +- drivers/tty/serial/stm32-usart.c | 5 +- drivers/tty/serial/sunhv.c | 5 +- drivers/tty/serial/sunsab.c | 5 +- drivers/tty/serial/sunsu.c | 5 +- drivers/tty/serial/sunzilog.c | 6 +- drivers/tty/serial/ucc_uart.c | 2 - drivers/tty/serial/vr41xx_siu.c | 5 +- drivers/tty/serial/vt8500_serial.c | 5 +- drivers/tty/serial/xilinx_uartps.c | 5 +- drivers/tty/serial/zs.c | 5 +- drivers/tty/sysrq.c | 16 +-- drivers/usb/serial/f81534.c | 6 +- drivers/usb/serial/generic.c | 10 +- include/linux/serial_core.h | 92 ++------------- include/linux/sysrq.h | 1 + kernel/sysctl.c | 41 ++++--- lib/Kconfig.debug | 8 ++ 58 files changed, 238 insertions(+), 346 deletions(-)
Signature · 1 line
2.24.0