Skip to content

rtc: Unify RTC_VL_READ meaning

Alexandre Belloni linux-rtc lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17rtc: define RTC_VL_READ valuesinclude/uapi/linux/rtc.h+6 -10 replies
2/17rtc: Document RTC_VL_READ and RTC_VL_CLR ioctlsDocumentation/ABI/testing/rtc-cdev+8 -00 replies
3/17rtc: abx80x: return meaningful value for RTC_VL_READdrivers/rtc/rtc-abx80x.c+2 -50 replies
4/17rtc: pcf2127: return meaningful value for RTC_VL_READdrivers/rtc/rtc-pcf2127.c+2 -40 replies
5/17rtc: pcf8523: return meaningful value for RTC_VL_READdrivers/rtc/rtc-pcf8523.c+3 -30 replies
6/17rtc: pcf8563: remove RTC_VL_CLR handlingdrivers/rtc/rtc-pcf8563.c+0 -150 replies
7/17rtc: pcf8563: remove conditional compilationdrivers/rtc/rtc-pcf8563.c+0 -50 replies
8/17rtc: pcf8563: stop caching voltage_lowdrivers/rtc/rtc-pcf8563.c+9 -70 replies
9/17rtc: pcf8563: return meaningful value for RTC_VL_READdrivers/rtc/rtc-pcf8563.c+3 -70 replies
10/17rtc: pcf85063: remove RTC_VL_CLR handlingdrivers/rtc/rtc-pcf85063.c+0 -60 replies
11/17rtc: pcf85063: return meaningful value for RTC_VL_READdrivers/rtc/rtc-pcf85063.c+2 -80 replies
12/17rtc: rv3028: remove RTC_VL_CLR handlingdrivers/rtc/rtc-rv3028.c+0 -60 replies
13/17rtc: rv3028: return meaningful value for RTC_VL_READdrivers/rtc/rtc-rv3028.c+2 -90 replies
14/17rtc: rv8803: avoid clearing RV8803_FLAG_V2F in RTC_VL_CLRdrivers/rtc/rtc-rv8803.c+1 -10 replies
15/17rtc: rv8803: return meaningful value for RTC_VL_READdrivers/rtc/rtc-rv8803.c+6 -80 replies
16/17rtc: rx8010: remove RTC_VL_CLR handlingdrivers/rtc/rtc-rx8010.c+1 -150 replies
17/17rtc: rx8010: return meaningful value for RTC_VL_READdrivers/rtc/rtc-rx8010.c+2 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/17] rtc: Unify RTC_VL_READ meaning

Hi,

This series unifies the meaning of RTC_VL_READ by redefining it as a bitfield and defining the values of the various bits. This doesn't break compatibility with userspaceas long as the return value was used as a boolean, which should be the case.

The series also ensures RTC_VL_CLR doesn't clear the information when it is about the data being invalid so the following rtc reads will properly fail.

Alexandre Belloni (17):
rtc: define RTC_VL_READ values
rtc: Document RTC_VL_READ and RTC_VL_CLR ioctls
rtc: abx80x: return meaningful value for RTC_VL_READ
rtc: pcf2127: return meaningful value for RTC_VL_READ
rtc: pcf8523: return meaningful value for RTC_VL_READ
rtc: pcf8563: remove RTC_VL_CLR handling
rtc: pcf8563: remove conditional compilation
rtc: pcf8563: stop caching voltage_low
rtc: pcf8563: return meaningful value for RTC_VL_READ
rtc: pcf85063: remove RTC_VL_CLR handling
rtc: pcf85063: return meaningful value for RTC_VL_READ
rtc: rv3028: remove RTC_VL_CLR handling
rtc: rv3028: return meaningful value for RTC_VL_READ
rtc: rv8803: avoid clearing RV8803_FLAG_V2F in RTC_VL_CLR
rtc: rv8803: return meaningful value for RTC_VL_READ
rtc: rx8010: remove RTC_VL_CLR handling
rtc: rx8010: return meaningful value for RTC_VL_READ

 Documentation/ABI/testing/rtc-cdev |  8 +++++++
 drivers/rtc/rtc-abx80x.c           |  7 ++----
 drivers/rtc/rtc-pcf2127.c          |  6 ++---
 drivers/rtc/rtc-pcf85063.c         | 16 ++-----------
 drivers/rtc/rtc-pcf8523.c          |  6 ++---
 drivers/rtc/rtc-pcf8563.c          | 36 ++++++------------------------
 drivers/rtc/rtc-rv3028.c           | 17 ++------------
 drivers/rtc/rtc-rv8803.c           | 16 ++++++-------
 drivers/rtc/rtc-rx8010.c           | 23 +++----------------
 include/uapi/linux/rtc.h           |  7 +++++-
 10 files changed, 42 insertions(+), 100 deletions(-)
Signature · 1 line
2.23.0