arm/arm64: Add ITS tests
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest13 patches 0 repliesNew
- v713 patches 20 repliesSuperseded
- v613 patches 7 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 13 patches | 14 replies | Superseded | |
| v4 | 13 patches | 14 replies | Superseded | |
| v3 | 14 patches | 32 replies | Superseded | |
| v2 | 16 patches | 18 replies | Superseded | |
| v1 | 16 patches | 11 replies | Superseded |
Changes in v8 from the cover letter
- take into account last comments from Zenghui and collected his R-bs
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | libcflat: Add other size defineslib/ | +3 | 0 replies | |
| 2/13 | page_alloc: Introduce get_order()lib/ lib/ | +7 | 0 replies | |
| 3/13 | arm/arm64: gic: Introduce setup_irq() helperarm/ lib/ | +8 | 0 replies | |
| 4/13 | arm/arm64: gicv3: Add some re-distributor defineslib/ | +6 | 0 replies | |
| 5/13 | arm/arm64: gicv3: Set the LPI config and pending tableslib/ lib/ | +70 | 0 replies | |
| 6/13 | arm/arm64: ITS: Introspection testsarm/ arm/ arm/ +5 more | +311 | 0 replies | |
| 7/13 | arm/arm64: ITS: its_enable_defaultslib/ lib/ lib/ +1 more | +45 | 0 replies | |
| 8/13 | arm/arm64: ITS: Device and collection Initializationlib/ lib/ | +57 | 0 replies | |
| 9/13 | arm/arm64: ITS: Commandsarm/ lib/ lib/ | +515 | 0 replies | |
| 10/13 | arm/arm64: ITS: INT functional testsarm/ arm/ | +213 | 0 replies | |
| 11/13 | arm/run: Allow Migration testsarm/ arm/ lib/ | +30 | 0 replies | |
| 12/13 | arm/arm64: ITS: migration testsarm/ arm/ lib/ +1 more | +85 | 0 replies | |
| 13/13 | arm/arm64: ITS: pending table migration testarm/ arm/ | +146 | 0 replies |
Reviews trailers per patch
9 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Thomas Huth | Zenghui Yu | Eric Auger |
|---|---|---|---|
| Series | R-b T-b | ||
| 1/13 | R-b | ||
| 2/13 | |||
| 3/13 | |||
| 4/13 | R-b | ||
| 5/13 | R-b | ||
| 6/13 | R-b | ||
| 7/13 | R-b | ||
| 8/13 | R-b | ||
| 9/13 | R-b | ||
| 10/13 | R-b | ||
| 11/13 | |||
| 12/13 | R-b | ||
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [kvm-unit-tests PATCH v8 00/13] arm/arm64: Add ITS tests
This series is a revival of an RFC series sent in Dec 2016 [1]. Given the amount of code and the lack of traction at that time, I haven't respinned until now. However a recent bug found related to the ITS migration convinced me that this work may deserve to be respinned and enhanced.
Tests exercise main ITS commands and also test migration. With the migration framework, we are able to trigger the migration from guest and that is very practical actually.
What is particular with the ITS programming is that most of the commands are passed through queues and there is real error handling. Invalid commands are just ignored and that is not really tester friendly.
The series can be fount at:
https://github.com/eauger/kut/tree/its-v8
Applies on top of arm/queue.
Best Regards
Eric
History:
v7 -> v8:
- take into account last comments from Zenghui and collected his R-bs
v6 -> v7:
- Fixed issue reported by Drew in its-migrate-unmapped-collection (a collection could be allocated twice depending on the SMP value)
- Integrated changes prepared by Drew
- Use for_each_present_cpu()
v5 -> v6:
- Took into account Zenghui's comments, mostly functional: see invidual history logs
- fix wrong assert!
v4 -> v5:
- 32b stubs moved back to arm/gic.c
- some changes reordering
- minor style issues
v3 -> v4:
- addressed comments from Drew and Zenghui
- added "page_alloc: Introduce get_order()"
- removed "arm: gic: Provide per-IRQ helper functions"
- ITS files moved to lib64
- and many more, see individual logs
v2 -> v3:
- fix 32b compilation
- take into account Drew's comments (see individual diff logs)
v1 -> v2:
- took into account Zenghui's comments
- collect R-b's from Thomas
References:
[1] [kvm-unit-tests RFC 00/15] arm/arm64: add ITS framework
https://lists.gnu.org/archive/html/qemu-devel/2016-12/msg00575.html
Execution:
x For other ITS tests:
./run_tests.sh -g its
x non migration tests can be launched invidually. For instance:
./arm-run arm/gic.flat -smp 8 -append 'its-trigger'
Eric Auger (13):
libcflat: Add other size defines
page_alloc: Introduce get_order()
arm/arm64: gic: Introduce setup_irq() helper arm/arm64: gicv3: Add some re-distributor defines arm/arm64: gicv3: Set the LPI config and pending tables arm/arm64: ITS: Introspection tests
arm/arm64: ITS: its_enable_defaults
arm/arm64: ITS: Device and collection Initialization arm/arm64: ITS: Commands
arm/arm64: ITS: INT functional tests
arm/run: Allow Migration tests
arm/arm64: ITS: migration tests
arm/arm64: ITS: pending table migration test
arm/Makefile.arm64 | 1 + arm/Makefile.common | 2 +- arm/gic.c | 454 ++++++++++++++++++++++++++++++++++-- arm/run | 2 +- arm/unittests.cfg | 38 +++ lib/alloc_page.c | 7 +- lib/alloc_page.h | 1 + lib/arm/asm/gic-v3-its.h | 27 +++ lib/arm/asm/gic-v3.h | 29 +++ lib/arm/asm/gic.h | 1 + lib/arm/asm/processor.h | 2 + lib/arm/gic-v3.c | 78 +++++++ lib/arm/gic.c | 40 +++- lib/arm/io.c | 28 +++ lib/arm64/asm/gic-v3-its.h | 174 ++++++++++++++ lib/arm64/gic-v3-its-cmd.c | 459 +++++++++++++++++++++++++++++++++++++ lib/arm64/gic-v3-its.c | 171 ++++++++++++++ lib/libcflat.h | 3 + 18 files changed, 1486 insertions(+), 31 deletions(-) create mode 100644 lib/arm/asm/gic-v3-its.h create mode 100644 lib/arm64/asm/gic-v3-its.h create mode 100644 lib/arm64/gic-v3-its-cmd.c create mode 100644 lib/arm64/gic-v3-its.c
Signature · 1 line
2.20.1