Skip to content

iotests: Remove duplicated blockdev_create()

Kevin Wolf qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10iotests: Create VM.blockdev_create()tests/qemu-iotests/iotests.py+16 -00 replies
2/10iotests: 255: Drop blockdev_create()tests/qemu-iotests/255+0 -100 replies
3/10iotests: 206: Convert to VM.blockdev_create()tests/qemu-iotests/206+111 -1210 replies
4/10iotests: 210: Convert to VM.blockdev_create()tests/qemu-iotests/210+36 -450 replies
5/10iotests: 212: Convert to VM.blockdev_create()tests/qemu-iotests/212+46 -550 replies
6/10iotests: 213: Convert to VM.blockdev_create()tests/qemu-iotests/213+52 -610 replies
7/10iotests: 237: Convert to VM.blockdev_create()tests/qemu-iotests/237+65 -740 replies
8/10iotests: 266: Convert to VM.blockdev_create()tests/qemu-iotests/266 tests/qemu-iotests/266.out+44 -390 replies
9/10iotests: 207: Remove duplication with VM.blockdev_create()tests/qemu-iotests/207+1 -70 replies
10/10iotests: 211: Remove duplication with VM.blockdev_create()tests/qemu-iotests/211+3 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] iotests: Remove duplicated blockdev_create()

We kept copying (and occasionally slightly modifying) the blockdev_create() function first added in 206. With now nine tests sharing duplicates of almost the same function (and me being about to add the tenth one), it's probably time to unify them into a single iotests.py function.

Kevin Wolf (10):
iotests: Create VM.blockdev_create()
iotests: 255: Drop blockdev_create()
iotests: 206: Convert to VM.blockdev_create()
iotests: 210: Convert to VM.blockdev_create()
iotests: 212: Convert to VM.blockdev_create()
iotests: 213: Convert to VM.blockdev_create()
iotests: 237: Convert to VM.blockdev_create()
iotests: 266: Convert to VM.blockdev_create()
iotests: 207: Remove duplication with VM.blockdev_create()
iotests: 211: Remove duplication with VM.blockdev_create()

 tests/qemu-iotests/206        | 232 ++++++++++++++++------------------
 tests/qemu-iotests/207        |   8 +-
 tests/qemu-iotests/210        |  81 ++++++------
 tests/qemu-iotests/211        |  12 +-
 tests/qemu-iotests/212        | 101 +++++++--------
 tests/qemu-iotests/213        | 113 ++++++++---------
 tests/qemu-iotests/237        | 139 ++++++++++----------
 tests/qemu-iotests/255        |  10 --
 tests/qemu-iotests/266        |  69 +++++-----
 tests/qemu-iotests/266.out    |  14 ++
 tests/qemu-iotests/iotests.py |  16 +++
 11 files changed, 374 insertions(+), 421 deletions(-)
Signature · 1 line
2.20.1