Skip to content

net: sched: unify __gnet_stats_copy_xxx() for percpu and non-percpu

Dust Li netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: sched: keep __gnet_stats_copy_xxx() same semantics for percpu statsnet/core/gen_stats.c net/sched/sch_mq.c net/sched/sch_mqprio.c+35 -380 replies
2/2net: sched: fix wrong class stats dumping in sch_mqprionet/sched/sch_mqprio.c+16 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: sched: unify __gnet_stats_copy_xxx() for percpu and non-percpu

Currently, __gnet_stats_copy_xxx() will overwrite the return value when percpu stats are not enabled. But when percpu stats are enabled, it will add the percpu stats to the result. This inconsistency brings confusion to its callers.

This patch series unify the behaviour of __gnet_stats_copy_basic() and __gnet_stats_copy_queue() for percpu and non-percpu stats and fix an incorrect statistic for mqprio class.

- Patch 1 unified __gnet_stats_copy_xxx() for both percpu and non-percpu
- Patch 2 depending on Patch 1, fixes the problem that 'tc class show' for mqprio class is always 0.

Dust Li (2):
net: sched: keep __gnet_stats_copy_xxx() same semantics for percpu
stats
net: sched: fix wrong class stats dumping in sch_mqprio

 net/core/gen_stats.c   |  2 ++
 net/sched/sch_mq.c     | 35 ++++++++++++-------------
 net/sched/sch_mqprio.c | 59 +++++++++++++++++++++++-------------------
 3 files changed, 51 insertions(+), 45 deletions(-)
Signature · 1 line
2.19.1.3.ge56e4f7