Skip to content

block: Fix external snapshot with VM state

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: Activate recursively even for already active nodesblock.c+24 -262 replies
2/3hmp: Allow using qdev ID for qemu-io commandhmp-commands.hx monitor/hmp-cmds.c+23 -130 replies
3/3iotests: Test external snapshot with VM statetests/qemu-iotests/280 tests/qemu-iotests/280.out tests/qemu-iotests/group+134 -06 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMax Reitz
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] block: Fix external snapshot with VM state

This fixes bdrv_invalidate_cache_all() for some kinds of graphs where part of the nodes are active and others are inactive. This is a scenario that happens when libvirt takes an external snapshot with VM state.

This was reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=1781637
('qemu crashed when do mem and disk snapshot')

Based-on: <[email protected]> ('iotests: Remove duplicated blockdev_create()')

Kevin Wolf (3):
block: Activate recursively even for already active nodes
hmp: Allow using qdev ID for qemu-io command
iotests: Test external snapshot with VM state

 block.c                    | 50 +++++++++++------------
 monitor/hmp-cmds.c         | 28 ++++++++-----
 hmp-commands.hx            |  8 ++--
 tests/qemu-iotests/280     | 83 ++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/280.out | 50 +++++++++++++++++++++++
 tests/qemu-iotests/group   |  1 +
 6 files changed, 181 insertions(+), 39 deletions(-)
 create mode 100755 tests/qemu-iotests/280
 create mode 100644 tests/qemu-iotests/280.out
Signature · 1 line
2.20.1