Skip to content

complete typeof support

Pablo Neira Ayuso netfilter-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11meta: add parse and build userdata interfacesrc/expression.c src/meta.c+53 -20 replies
2/11exthdr: add exthdr_desc_id enum and use itinclude/exthdr.h src/exthdr.c+43 -00 replies
3/11exthdr: add parse and build userdata interfacesrc/expression.c src/exthdr.c+75 -00 replies
4/11socket: add parse and build userdata interfacesrc/expression.c src/socket.c+52 -00 replies
5/11osf: add parse and build userdata interfacesrc/expression.c src/osf.c+14 -00 replies
6/11ct: add parse and build userdata interfacesrc/ct.c src/expression.c+57 -00 replies
7/11numgen: add parse and build userdata interfacesrc/expression.c src/numgen.c+63 -00 replies
8/11hash: add parse and build userdata interfacesrc/expression.c src/hash.c+73 -00 replies
9/11rt: add parse and build userdata interfacesrc/expression.c src/rt.c+52 -00 replies
10/11fib: add parse and build userdata interfacesrc/expression.c src/fib.c+59 -20 replies
11/11xfrm: add parse and build userdata interfacesrc/expression.c src/xfrm.c+62 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nft 00/11] complete typeof support

Hi Florian,

This completes your patchset adding typeof support for the remaining primary expression.

Feel free to apply and push this out on top of your patchset.

P.S: testcases/maps/typeof_maps_0 fails:

/dev/stdin:14:28-30: Error: datatype mismatch, map expects string, mapping expression has type IPv4 address
ct mark set ip daddr map @m1
~~~~~~~~ ^^^

There is a typo in the map definition:

/dev/stdin:14:28-30: Error: datatype mismatch, map expects string, mapping expression has type IPv4 address
ct mark set ip daddr map @m1
~~~~~~~~ ^^^

This should be

ct mark set osf name map @m1

dump file also needs an adjustment, you can fix this before pushing this out.

Thanks!

P.S: I might follow up at some point to expose this userdata attributes through libnftnl, later. Meanwhile, I have just pushed out the libnftnl nesting dependencies.

Pablo Neira Ayuso (11):
meta: add parse and build userdata interface
exthdr: add exthdr_desc_id enum and use it
exthdr: add parse and build userdata interface
socket: add parse and build userdata interface
osf: add parse and build userdata interface
ct: add parse and build userdata interface
numgen: add parse and build userdata interface
hash: add parse and build userdata interface
rt: add parse and build userdata interface
fib: add parse and build userdata interface
xfrm: add parse and build userdata interface

 include/exthdr.h |  15 ++++++++
 src/ct.c         |  56 ++++++++++++++++++++++++++++++
 src/expression.c |  13 +++++--
 src/exthdr.c     | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/fib.c        |  60 ++++++++++++++++++++++++++++++--
 src/hash.c       |  72 +++++++++++++++++++++++++++++++++++++++
 src/meta.c       |  51 ++++++++++++++++++++++++++++
 src/numgen.c     |  62 +++++++++++++++++++++++++++++++++
 src/osf.c        |  13 +++++++
 src/rt.c         |  51 ++++++++++++++++++++++++++++
 src/socket.c     |  51 ++++++++++++++++++++++++++++
 src/xfrm.c       |  61 +++++++++++++++++++++++++++++++++
 12 files changed, 603 insertions(+), 4 deletions(-)
Signature · 1 line
2.11.0