Skip to content

Fix more GCC9 -O3 warnings

Philippe Mathieu-Daudé qemu-arm qemu-devel qemu-trivial 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 13 repliesIn review
  2. v16 patches 20 repliesSuperseded

Changes in v2 from the cover letter

- addressed Thomas and Aleksandar comments
- dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
- dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6audio/audio: Add missing fall through commentaudio/audio.c+1 -02 replies
2/6hw/display/tcx: Add missing fall through commentshw/display/tcx.c+2 -02 replies
3/6hw/timer/aspeed_timer: Add a fall through commenthw/timer/aspeed_timer.c+1 -10 replies
4/6hw/net/imx_fec: Rewrite fall through commentshw/net/imx_fec.c+2 -11 reply
5/6hw/net/imx_fec: Remove unuseful FALLTHROUGH commentshw/net/imx_fec.c+2 -23 replies
6/6hw/pci-host/designware: Remove unuseful FALLTHROUGH commenthw/pci-host/designware.c+1 -14 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonCédric Le GoaterAleksandar MarkovicThomas HuthMark Cave-AylandGerd Hoffmann
1/6R-b R-b R-b
2/6R-b R-b R-b
3/6R-b R-b
4/6R-b R-b R-b
5/6R-b R-b R-b
6/6R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] Fix more GCC9 -O3 warnings

Fix some trivial warnings when building with -O3.

v2:
- addressed Thomas and Aleksandar comments
- dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
- dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'

Philippe Mathieu-Daudé (6):
audio/audio: Add missing fall through comment hw/display/tcx: Add missing fall through comments hw/timer/aspeed_timer: Add a fall through comment hw/net/imx_fec: Rewrite fall through comments hw/net/imx_fec: Remove unuseful FALLTHROUGH comments hw/pci-host/designware: Remove unuseful FALLTHROUGH comment

 audio/audio.c            | 1 +
 hw/display/tcx.c         | 2 ++
 hw/net/imx_fec.c         | 7 ++++---
 hw/pci-host/designware.c | 2 +-
 hw/timer/aspeed_timer.c  | 2 +-
 5 files changed, 9 insertions(+), 5 deletions(-)
Cc Aleksandar Markovic <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Andrey Smirnov <[email protected]>
Cc "Cédric Le Goater" <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Jason Wang <[email protected]>
Cc Joel Stanley <[email protected]>
Cc "Kővágó, Zoltán" <[email protected]>
Cc Mark Cave-Ayland <[email protected]>
Cc Markus Armbruster <[email protected]>
Cc Olivier Danet <[email protected]>
Cc Peter Chubb <[email protected]>
Cc Peter Maydell <[email protected]>
Signature · 1 line
2.21.0