Skip to content

drm/i915/tgl: Render/media decompression support

Imre Deak dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15drm/framebuffer: Format modifier for Intel Gen-12 render compressioninclude/uapi/drm/drm_fourcc.h+11 -03 replies
1/15drm/framebuffer: Format modifier for Intel Gen-12 render compressioninclude/uapi/drm/drm_fourcc.h+11 -00 replies
2/15drm/i915: Use intel_tile_height() instead of re-implementingdrivers/gpu/drm/i915/display/intel_display.c+1 -12 replies
3/15drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignmentdrivers/gpu/drm/i915/display/intel_display.c+16 -152 replies
4/15drm/i915: Extract framebufer CCS offset checks into a functiondrivers/gpu/drm/i915/display/intel_display.c+40 -304 replies
5/15drm/i915: Add helpers to select correct ccs/aux planesdrivers/gpu/drm/i915/display/intel_display.c+50 -135 replies
6/15drm/i915/tgl: Gen-12 render decompressiondrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_sprite.c drivers/gpu/drm/i915/i915_reg.h+169 -404 replies
7/15drm/i915/tgl: Make sure FBs have a correct CCS plane stridedrivers/gpu/drm/i915/display/intel_display.c+15 -03 replies
8/15drm/i915: Skip rotated offset adjustment for unsupported modifiersdrivers/gpu/drm/i915/display/intel_display.c+5 -12 replies
9/15drm/i915: Make sure Y slave planes get all the required statedrivers/gpu/drm/i915/display/intel_display.c+2 -11 reply
10/15drm/i915: Make sure CCS YUV semiplanar format checks workdrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h +2 more+32 -142 replies
11/15drm/framebuffer: Format modifier for Intel Gen-12 media compressioninclude/uapi/drm/drm_fourcc.h+13 -01 reply
11/15drm/framebuffer: Format modifier for Intel Gen-12 media compressioninclude/uapi/drm/drm_fourcc.h+13 -00 replies
12/15drm/fb: Extend format_info member arrays to handle four planesinclude/drm/drm_fourcc.h+4 -41 reply
12/15drm/fb: Extend format_info member arrays to handle four planesinclude/drm/drm_fourcc.h+4 -40 replies
13/15drm/i915/tgl: Gen-12 display can decompress surfaces compressed by the media enginedrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/display/intel_display_types.h +2 more+188 -552 replies
14/15drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Colorinclude/uapi/drm/drm_fourcc.h+19 -01 reply
14/15drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Colorinclude/uapi/drm/drm_fourcc.h+19 -00 replies
15/15drm/i915/tgl: Add Clear Color support for TGL Render Decompressiondrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_sprite.c +1 more+88 -52 replies

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by.

PatchMatt RoperMika KaholaRadhakrishna Sripada
1/15R-b R-b
1/15R-b R-b
2/15R-b R-b
3/15R-b R-b
4/15R-b
5/15R-b R-b
6/15R-b R-b R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b R-b
11/15R-b R-b
12/15R-b R-b
12/15R-b R-b
13/15R-b R-b
14/15R-b R-b
14/15R-b R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [Intel-gfx] [PATCH 00/15] drm/i915/tgl: Render/media decompression support

This is an updated version of DK's and RK's patchset enabling render/media decompression. The fixes in this version apply mostly to get YUV formats working. Wrt. RK's last patchset the order of planes in semiplanar YUV FBs has changed, see patch 11 for details.

I tested the normal and panned (non-zero FB source coords) scan out of the following formats: RGB32, YUYV, NV12, P0xx. I'll follow up for the actual IGT tests for these.

Cc Dhinakaran Pandiyan <[email protected]>
Cc Radhakrishna Sripada <[email protected]>
Cc Ville Syrjala <[email protected]>
Cc Nanley G Chery <[email protected]>
Cc Mika Kahola <[email protected]>

Dhinakaran Pandiyan (9):
drm/framebuffer: Format modifier for Intel Gen-12 render compression drm/i915: Use intel_tile_height() instead of re-implementing drm/i915: Move CCS stride alignment W/A inside
intel_fb_stride_alignment
drm/i915: Extract framebufer CCS offset checks into a function drm/i915/tgl: Gen-12 render decompression
drm/i915: Skip rotated offset adjustment for unsupported modifiers drm/framebuffer: Format modifier for Intel Gen-12 media compression drm/fb: Extend format_info member arrays to handle four planes drm/i915/tgl: Gen-12 display can decompress surfaces compressed by the
media engine

Imre Deak (4):
drm/i915: Add helpers to select correct ccs/aux planes drm/i915/tgl: Make sure FBs have a correct CCS plane stride drm/i915: Make sure Y slave planes get all the required state drm/i915: Make sure CCS YUV semiplanar format checks work

Radhakrishna Sripada (2):
drm/framebuffer: Format modifier for Intel Gen 12 render compression
with Clear Color
drm/i915/tgl: Add Clear Color support for TGL Render Decompression

 .../gpu/drm/i915/display/intel_atomic_plane.c |   2 +-
 drivers/gpu/drm/i915/display/intel_display.c  | 581 ++++++++++++++----
 drivers/gpu/drm/i915/display/intel_display.h  |   5 +
 .../drm/i915/display/intel_display_types.h    |   9 +-
 drivers/gpu/drm/i915/display/intel_sprite.c   |  87 ++-
 drivers/gpu/drm/i915/i915_reg.h               |  14 +
 drivers/gpu/drm/i915/intel_pm.c               |   7 +-
 include/drm/drm_fourcc.h                      |   8 +-
 include/uapi/drm/drm_fourcc.h                 |  43 ++
 9 files changed, 615 insertions(+), 141 deletions(-)
Signature · 6 lines
2.22.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx