Skip to content

NVIDIA Tegra USB2 drivers clean up

Dmitry Osipenko linux-tegra linux-usb lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest20 patches 2 repliesIn review
  2. v316 patches 10 repliesSuperseded
  3. v210 patches 17 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches9 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20dt-binding: usb: ci-hdrc-usb2: Document NVIDIA Tegra supportDocumentation/devicetree/bindings/usb/ci-hdrc-usb2.txt+4 -00 replies
2/20usb: host: ehci-tegra: Correct teardown order of driver's removaldrivers/usb/host/ehci-tegra.c+1 -70 replies
3/20usb: phy: tegra: Clean up ulpi_phy_power_offdrivers/usb/phy/phy-tegra-usb.c+13 -20 replies
4/20usb: phy: tegra: Keep track of power on-off statedrivers/usb/phy/phy-tegra-usb.c include/linux/usb/tegra_usb_phy.h+27 -40 replies
5/20usb: phy: tegra: Hook up init/shutdown callbacksdrivers/usb/phy/phy-tegra-usb.c+110 -700 replies
6/20usb: phy: tegra: Perform general clean up of the codedrivers/usb/phy/phy-tegra-usb.c+254 -2310 replies
7/20usb: phy: tegra: Clean up included headersdrivers/usb/phy/phy-tegra-usb.c+11 -90 replies
8/20usb: phy: tegra: Use relaxed versions of readl/writeldrivers/usb/phy/phy-tegra-usb.c+98 -970 replies
9/20usb: phy: tegra: Use generic stub for a missing VBUS regulatordrivers/usb/phy/phy-tegra-usb.c+9 -190 replies
10/20usb: ulpi: Add resource-managed variant of otg_ulpi_create()drivers/usb/phy/phy-ulpi.c include/linux/usb/ulpi.h+50 -90 replies
11/20usb: phy: tegra: Use devm_otg_ulpi_create()drivers/usb/phy/phy-tegra-usb.c+6 -160 replies
12/20usb: phy: tegra: Use u32 for hardware register variablesdrivers/usb/phy/phy-tegra-usb.c+15 -130 replies
13/20usb: phy: tegra: Use device-tree notion of reset-GPIO's active-statedrivers/usb/phy/phy-tegra-usb.c include/linux/usb/tegra_usb_phy.h+18 -550 replies
14/20usb: phy: tegra: Disable VBUS regulator on tegra_usb_phy_init failuredrivers/usb/phy/phy-tegra-usb.c+8 -40 replies
15/20usb: phy: tegra: Move utmip_pad_count checking under lockdrivers/usb/phy/phy-tegra-usb.c+11 -100 replies
16/20usb: phy: tegra: Keep CPU interrupts enableddrivers/usb/phy/phy-tegra-usb.c+4 -60 replies
17/20usb: chipidea: tegra: Stop managing PHY's powerdrivers/usb/chipidea/ci_hdrc_tegra.c+0 -90 replies
18/20usb: chipidea: tegra: Add USB_TEGRA_PHY to driver's dependenciesdrivers/usb/chipidea/Kconfig+1 -00 replies
19/20usb: host: ehci-tegra: Stop managing PHY's powerdrivers/usb/host/ehci-tegra.c+0 -60 replies
20/20usb: host: ehci-tegra: Remove unused fields from tegra_ehci_hcddrivers/usb/host/ehci-tegra.c+0 -22 replies

Reviews trailers per patch

5 of 20 patches have a Reviewed-by or Acked-by.

PatchPeter ChenThierry RedingRob HerringAlan Stern
1/20A-b A-b A-b
2/20
3/20
4/20
5/20A-b A-b
6/20A-b
7/20
8/20A-b
9/20
10/20
11/20
12/20
13/20
14/20
15/20
16/20
17/20
18/20
19/20
20/20A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/20] NVIDIA Tegra USB2 drivers clean up

Hello,

This patch series brings the NVIDIA Tegra USB2 PHY driver into a better shape by refactoring code to match upstream standards, the ChipIdea/Tegra UDC driver also gets a minor update. Please review and apply, thanks in advance!

Changelog:

v4: - Dropped the request_module() from "Add USB_TEGRA_PHY to driver's
dependencies" because it resulted in a bit too many questions during review and since it won't be needed once Tegra EHCI driver will be squashed into the CI anyways.

- Factored out clean up of ulpi_phy_power_off into a separate patch and improved it a bit move by disabling clock *after* asserting reset:

usb: phy: tegra: Clean up ulpi_phy_power_off

- Cleaned up ULPI reset-GPIO changes that were messed up a tad in v3, thanks to Michał Mirosław for reviewing it in v3.

- Dropped the "Assert reset on ULPI close instead of deasserting it" patch because turned out that the problem was introduced by an earlier patch in this series, which is fixed now.

- Added missed tegra_usb_phy_power_off to tegra_usb_phy_shutdown() in the "Hook up init/shutdown callbacks" patch.

- I found out that PHY-enable refcount is broken after drivers reloading, added these new patches in a result:

usb: phy: tegra: Keep track of power on-off state
usb: host: ehci-tegra: Stop managing PHY's power

- Added patch to clean up included headers in the PHY driver:

usb: phy: tegra: Clean up included headers

v3: - The "Perform general clean up of the code" patch now cleans up couple
more minor crumbs.

- Added more "clean up" patches:

usb: phy: tegra: Disable VBUS regulator on tegra_usb_phy_init failure
usb: phy: tegra: Move utmip_pad_count checking under lock
usb: phy: tegra: Keep CPU interrupts enabled
usb: host: ehci-tegra: Remove unused fields from tegra_ehci_hcd

- I noticed that ULPI's reset is getting erroneously deasserted on PHY's shutdown, this is fixed in these new patches:

usb: phy: tegra: Assert reset on ULPI close instead of deasserting it
usb: phy: tegra: Use device-tree notion of reset-GPIO's active-state

v2: - The "usb: phy: tegra: Hook up init/shutdown callbacks" patch was
updated and now it does a better job in regards to checking whether PHY is initialized before it is started to be used and whether there is a double init/shutdown. This allows to factor out the ChipIdea's driver change into a separate patch, which was requested by Peter Chen in a review comment to v1. In a result there is this new patch:

usb: chipidea: tegra: Stop managing PHY's power

- Added few more new patches:

usb: phy: tegra: Use generic stub for a missing VBUS regulator

I noticed that VBUS regulator usage could be cleaned up a tad as well.

usb: ulpi: Add resource-managed variant of otg_ulpi_create()
usb: phy: tegra: Use devm_otg_ulpi_create()
usb: phy: tegra: Use u32 for hardware register variables

These patches are made in response to review comments that were made by Thierry Reding to v1.

I also noticed that phy_tegra_usb isn't getting auto-loaded while it should be. This is fixed in this new patch:

usb: chipidea: tegra: Add USB_TEGRA_PHY to driver's dependencies

Dmitry Osipenko (20):
dt-binding: usb: ci-hdrc-usb2: Document NVIDIA Tegra support
usb: host: ehci-tegra: Correct teardown order of driver's removal
usb: phy: tegra: Clean up ulpi_phy_power_off
usb: phy: tegra: Keep track of power on-off state
usb: phy: tegra: Hook up init/shutdown callbacks
usb: phy: tegra: Perform general clean up of the code
usb: phy: tegra: Clean up included headers
usb: phy: tegra: Use relaxed versions of readl/writel
usb: phy: tegra: Use generic stub for a missing VBUS regulator
usb: ulpi: Add resource-managed variant of otg_ulpi_create()
usb: phy: tegra: Use devm_otg_ulpi_create()
usb: phy: tegra: Use u32 for hardware register variables
usb: phy: tegra: Use device-tree notion of reset-GPIO's active-state
usb: phy: tegra: Disable VBUS regulator on tegra_usb_phy_init failure
usb: phy: tegra: Move utmip_pad_count checking under lock
usb: phy: tegra: Keep CPU interrupts enabled
usb: chipidea: tegra: Stop managing PHY's power
usb: chipidea: tegra: Add USB_TEGRA_PHY to driver's dependencies
usb: host: ehci-tegra: Stop managing PHY's power
usb: host: ehci-tegra: Remove unused fields from tegra_ehci_hcd

 .../devicetree/bindings/usb/ci-hdrc-usb2.txt  |   4 +
 drivers/usb/chipidea/Kconfig                  |   1 +
 drivers/usb/chipidea/ci_hdrc_tegra.c          |   9 -
 drivers/usb/host/ehci-tegra.c                 |  16 +-
 drivers/usb/phy/phy-tegra-usb.c               | 896 +++++++++---------
 drivers/usb/phy/phy-ulpi.c                    |  48 +-
 include/linux/usb/tegra_usb_phy.h             |   4 +-
 include/linux/usb/ulpi.h                      |  11 +
 8 files changed, 530 insertions(+), 459 deletions(-)
Signature · 1 line
2.24.0