Skip to content

openat2: minor uapi cleanups

Aleksa Sarai linux-api linux-fsdevel linux-kselftest lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2uapi: split openat2(2) definitions from fcntl.hMAINTAINERS include/uapi/linux/fcntl.h include/uapi/linux/openat2.h+43 -365 replies
1/2uapi: split openat2(2) definitions from fcntl.hMAINTAINERS include/uapi/linux/fcntl.h include/uapi/linux/openat2.h+43 -360 replies
2/2openat2: drop open_how->__padding fieldfs/open.c include/uapi/linux/openat2.h tools/testing/selftests/openat2/helpers.h +1 more+10 -221 reply
2/2openat2: drop open_how->__padding fieldfs/open.c include/uapi/linux/openat2.h tools/testing/selftests/openat2/helpers.h +1 more+10 -220 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchChristian Brauner
1/2
1/2
2/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] openat2: minor uapi cleanups

While openat2(2) is still not yet in Linus's tree, we can take this opportunity to iron out some small warts that weren't noticed earlier:

* A fix was suggested by Florian Weimer, to separate the openat2 definitions so glibc can use the header directly. I've put the maintainership under VFS but let me know if you'd prefer it belong ot the fcntl folks.

* Having heterogenous field sizes in an extensible struct results in "padding hole" problems when adding new fields (in addition the correct error to use for non-zero padding isn't entirely clear ). The simplest solution is to just copy clone(3)'s model -- always use u64s. It will waste a little more space in the struct, but it removes a possible future headache.

Aleksa Sarai (2):
uapi: split openat2(2) definitions from fcntl.h
openat2: drop open_how->__padding field

 MAINTAINERS                                   |  1 +
 fs/open.c                                     |  2 -
 include/uapi/linux/fcntl.h                    | 37 +----------------
 include/uapi/linux/openat2.h                  | 40 +++++++++++++++++++
 tools/testing/selftests/openat2/helpers.h     |  3 +-
 .../testing/selftests/openat2/openat2_test.c  | 24 ++++-------
 6 files changed, 51 insertions(+), 56 deletions(-)
 create mode 100644 include/uapi/linux/openat2.h

base-commit: 912dfe068c43fa13c587b8d30e73d335c5ba7d44

Signature · 1 line
2.24.0