Skip to content

Add support for block disk resize notification

Balbir Singh linux-block linux-nvme lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 5 repliesIn review
  2. v25 patches 6 repliesSuperseded
  3. v1 posting 2/25 patches 32 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC posting 1/25 patches3 repliesSuperseded

Changes in v3 from the cover letter

- Repost after rebasing
- Trim details of the subsystem/files in the subject Changelog v2:
- Rename disk_set_capacity to set_capacity_revalidate_and_notify
- set_capacity_revalidate_and_notify can call revalidate disk if needed, a new bool parameter is passed (suggested by Bob Liu)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block/genhd: Notify udev about capacity changeblock/genhd.c include/linux/genhd.h+26 -01 reply
2/5virtio_blk.c: Convert to use set_capacity_revalidate_and_notifydrivers/block/virtio_blk.c+1 -41 reply
3/5xen-blkfront.c: Convert to use set_capacity_revalidate_and_notifydrivers/block/xen-blkfront.c+1 -51 reply
4/5nvme: Convert to use set_capacity_revalidate_and_notifydrivers/nvme/host/core.c+1 -11 reply
5/5scsi: Convert to use set_capacity_revalidate_and_notifydrivers/scsi/sd.c+2 -11 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchBob LiuKeith BuschSagi GrimbergChristoph Hellwig
1/5R-b R-b
2/5
3/5R-b
4/5A-b R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] Add support for block disk resize notification

Allow block/genhd to notify user space about disk size changes using a new helper set_capacity_revalidate_and_notify(), which is a wrapper on top of set_capacity(). set_capacity_revalidate_and_notify() will only notify iff the current capacity or the target capacity is not zero and the capacity really changes.

Background:

As a part of a patch to allow sending the RESIZE event on disk capacity change, Christoph ([email protected]) requested that the patch be made generic and the hacks for virtio block and xen block devices be removed and merged via a generic helper.

This series consists of 5 changes. The first one adds the basic support for changing the size and notifying. The follow up patches are per block subsystem changes. Other block drivers can add their changes as necessary on top of this series. Since not all devices are resizable, the default was to add a new API and let users slowly convert over as needed.

Testing:
1. I did some basic testing with an NVME device, by resizing it in the backend and ensured that udevd received the event.

Changelog v3:
- Repost after rebasing
- Trim details of the subsystem/files in the subject Changelog v2:
- Rename disk_set_capacity to set_capacity_revalidate_and_notify
- set_capacity_revalidate_and_notify can call revalidate disk if needed, a new bool parameter is passed (suggested by Bob Liu)

Balbir Singh (5):
block/genhd: Notify udev about capacity change virtio_blk.c: Convert to use set_capacity_revalidate_and_notify xen-blkfront.c: Convert to use set_capacity_revalidate_and_notify
nvme: Convert to use set_capacity_revalidate_and_notify
scsi: Convert to use set_capacity_revalidate_and_notify

 block/genhd.c                | 24 ++++++++++++++++++++++++
 drivers/block/virtio_blk.c   |  5 +----
 drivers/block/xen-blkfront.c |  6 +-----
 drivers/nvme/host/core.c     |  2 +-
 drivers/scsi/sd.c            |  3 ++-
 include/linux/genhd.h        |  2 ++
 6 files changed, 31 insertions(+), 11 deletions(-)
Signature · 1 line
2.16.6