Skip to content

platform/x86: Rework intel_scu_ipc and intel_pmc_ipc drivers

Mika Westerberg lkml platform-driver-x86 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest20 patches 4 repliesIn review
  2. v819 patches 8 repliesSuperseded
  3. v719 patches 8 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v619 patches10 repliesSuperseded
v518 patches18 repliesSuperseded
v438 patches30 repliesSuperseded
v336 patches16 repliesSuperseded
v236 patches44 repliesSuperseded
v137 patches9 repliesSuperseded

Changes in v9 from the cover letter

* Rebased on top of v5.7-rc1.
* Added Lee's Acked-for-MFD-by to patch 1.
* There is a new patch (14/20) from Heikki to convert the newly introduced Intel PMC Mux driver over to this new SCU IPC API.
* Call PMC API directly from iTCO_wdt and drop the ->update_no_reboot_bit

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20platform/x86: intel_scu_ipc: Split out SCU IPC functionality from the SCU driverarch/x86/Kconfig arch/x86/include/asm/intel_scu_ipc.h drivers/mfd/Kconfig +4 more+208 -680 replies
2/20platform/x86: intel_scu_ipc: Log more information if SCU IPC command failsdrivers/platform/x86/intel_scu_ipc.c+11 -60 replies
3/20platform/x86: intel_scu_ipc: Move legacy SCU IPC API to a separate headerarch/x86/include/asm/intel_scu_ipc.h arch/x86/include/asm/intel_scu_ipc_legacy.h+63 -550 replies
4/20platform/x86: intel_scu_ipc: Introduce new SCU IPC APIarch/x86/include/asm/intel_scu_ipc.h arch/x86/include/asm/intel_scu_ipc_legacy.h drivers/platform/x86/intel_scu_ipc.c+252 -610 replies
5/20platform/x86: intel_mid_powerbtn: Convert to use new SCU IPC APIdrivers/platform/x86/intel_mid_powerbtn.c+11 -40 replies
6/20watchdog: intel-mid_wdt: Convert to use new SCU IPC APIdrivers/watchdog/intel-mid_wdt.c+37 -160 replies
7/20platform/x86: intel_scu_ipcutil: Convert to use new SCU IPC APIdrivers/platform/x86/intel_scu_ipcutil.c+39 -40 replies
8/20platform/x86: intel_scu_ipc: Add managed function to register SCU IPCarch/x86/include/asm/intel_scu_ipc.h drivers/platform/x86/intel_scu_ipc.c+72 -00 replies
9/20platform/x86: intel_pmc_ipc: Start using SCU IPCdrivers/platform/x86/Kconfig drivers/platform/x86/intel_pmc_ipc.c+40 -2640 replies
10/20mfd: intel_soc_pmic: Add SCU IPC member to struct intel_soc_pmicinclude/linux/mfd/intel_soc_pmic.h+15 -00 replies
11/20mfd: intel_soc_pmic_bxtwc: Convert to use new SCU IPC APIarch/x86/include/asm/intel_pmc_ipc.h drivers/mfd/intel_soc_pmic_bxtwc.c+17 -200 replies
12/20mfd: intel_soc_pmic_mrfld: Convert to use new SCU IPC APIdrivers/mfd/intel_soc_pmic_mrfld.c+8 -20 replies
13/20platform/x86: intel_telemetry: Convert to use new SCU IPC APIarch/x86/include/asm/intel_pmc_ipc.h arch/x86/include/asm/intel_telemetry.h drivers/platform/x86/intel_telemetry_pltdrv.c+49 -500 replies
14/20usb: typec: mux: Convert the Intel PMC Mux driver to use new SCU IPC APIdrivers/usb/typec/mux/Kconfig drivers/usb/typec/mux/intel_pmc_mux.c+9 -50 replies
15/20platform/x86: intel_pmc_ipc: Drop intel_pmc_ipc_command()arch/x86/include/asm/intel_pmc_ipc.h drivers/platform/x86/intel_pmc_ipc.c+0 -280 replies
16/20x86/platform/intel-mid: Add empty stubs for intel_scu_devices_[create|destroy]()arch/x86/include/asm/intel-mid.h+6 -30 replies
17/20platform/x86: intel_pmc_ipc: Move PCI IDs to intel_scu_pcidrv.cdrivers/platform/x86/Kconfig drivers/platform/x86/intel_pmc_ipc.c drivers/platform/x86/intel_scu_pcidrv.c+27 -680 replies
18/20platform/x86: intel_telemetry: Add telemetry_get_pltdata()arch/x86/include/asm/intel_telemetry.h drivers/platform/x86/intel_telemetry_core.c drivers/platform/x86/intel_telemetry_debugfs.c+8 -140 replies
19/20platform/x86: intel_pmc_ipc: Convert to MFDDocumentation/ABI/obsolete/sysfs-driver-intel_pmc_bxt arch/x86/include/asm/intel_pmc_ipc.h arch/x86/include/asm/intel_telemetry.h +12 more+602 -7203 replies
20/20MAINTAINERS: Update entry for Intel Broxton PMC driverMAINTAINERS+14 -90 replies

Reviews trailers per patch

19 of 20 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoLee JonesGuenter Roeck
1/20R-b Acked-for-MFD-by
2/20R-b
3/20R-b
4/20R-b
5/20R-b
6/20R-b A-b
7/20R-b
8/20R-b
9/20R-b
10/20R-b Acked-for-MFD-by
11/20R-b Acked-for-MFD-by
12/20R-b Acked-for-MFD-by
13/20R-b
14/20
15/20R-b
16/20R-b
17/20R-b
18/20R-b
19/20R-b Acked-for-MFD-by
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [PATCH v9 00/20] platform/x86: Rework intel_scu_ipc and intel_pmc_ipc drivers

Hi all,

Currently both intel_scu_ipc.c and intel_pmc_ipc.c implement the same SCU IPC communications with minor differences. This duplication does not make much sense so this series reworks the two drivers so that there is only a single implementation of the SCU IPC. In addition to that the API will be updated to take SCU instance pointer as an argument, and most of the callers will be converted to this new API. The old API is left there but the plan is to get rid the callers and then the old API as well.

The intel_pmc_ipc.c is then moved under MFD which suits better for this kind of a driver that pretty much sets up the SCU IPC and then creates a bunch of platform devices for the things sitting behind the PMC. The driver is renamed to intel_pmc_bxt.c which should follow the existing conventions under drivers/mfd (and it is only meant for Intel Broxton derivatives).

Changes from v8:

* Rebased on top of v5.7-rc1.
* Added Lee's Acked-for-MFD-by to patch 1.
* There is a new patch (14/20) from Heikki to convert the newly introduced Intel PMC Mux driver over to this new SCU IPC API.
* Call PMC API directly from iTCO_wdt and drop the ->update_no_reboot_bit

    callback and the ->no_reboot_priv from the iTCO_wdt platform data

* Fill the MFD cells directly, do not take copies.

Changes from v7:

* Added Lee's Acked-for-MFD-by to patches 10, 11 and 12.
* In patch 18 use same four-digit value for SMI_EN_OFFSET and TCO_BASE_OFFSET to be consistent with others.
* Drop comma after PMC_DEVICE_MAX in patch 18.

Changes from v6:

* Added Reviewed-by tag from Andy
* Expanded PMC, IPC and IA acronyms
* Drop TCO_DEVICE_NAME, PUNIT_DEVICE_NAME and TELEMETRY_DEVICE_NAME
* Move struct intel_pmc_dev into include/linux/mfd/intel_pmc_bxt.h
* Add PMC_DEVICE_MAX to the enum and use it
* Add kernel-docs for simplecmd_store() and northpeak_store()
* Use if (ret) return ret; over the ternary operator
* Drop "This is index X" from comments
* Use acpi_has_watchdog() to determine whether iTCO_wdt is added or not.
* Rename intel_scu_ipc_pdata -> intel_scu_ipc_data to make it less confusing wrt. platform data for platform drivers.

Previous versions can be found:

v8: https://www.spinics.net/lists/platform-driver-x86/msg21062.html
v7: https://www.spinics.net/lists/platform-driver-x86/msg21020.html
v6: https://www.spinics.net/lists/platform-driver-x86/msg20896.html
v5: https://www.spinics.net/lists/platform-driver-x86/msg20841.html
v4: https://www.spinics.net/lists/platform-driver-x86/msg20658.html
v3: https://www.spinics.net/lists/platform-driver-x86/msg20583.html
v2: https://www.spinics.net/lists/platform-driver-x86/msg20446.html
v1: https://www.spinics.net/lists/platform-driver-x86/msg20359.html

Heikki Krogerus (1):
usb: typec: mux: Convert the Intel PMC Mux driver to use new SCU IPC API

Mika Westerberg (19):
platform/x86: intel_scu_ipc: Split out SCU IPC functionality from the SCU driver platform/x86: intel_scu_ipc: Log more information if SCU IPC command fails platform/x86: intel_scu_ipc: Move legacy SCU IPC API to a separate header platform/x86: intel_scu_ipc: Introduce new SCU IPC API platform/x86: intel_mid_powerbtn: Convert to use new SCU IPC API
watchdog: intel-mid_wdt: Convert to use new SCU IPC API platform/x86: intel_scu_ipcutil: Convert to use new SCU IPC API platform/x86: intel_scu_ipc: Add managed function to register SCU IPC platform/x86: intel_pmc_ipc: Start using SCU IPC
mfd: intel_soc_pmic: Add SCU IPC member to struct intel_soc_pmic
mfd: intel_soc_pmic_bxtwc: Convert to use new SCU IPC API
mfd: intel_soc_pmic_mrfld: Convert to use new SCU IPC API platform/x86: intel_telemetry: Convert to use new SCU IPC API platform/x86: intel_pmc_ipc: Drop intel_pmc_ipc_command() x86/platform/intel-mid: Add empty stubs for intel_scu_devices_[create|destroy]() platform/x86: intel_pmc_ipc: Move PCI IDs to intel_scu_pcidrv.c platform/x86: intel_telemetry: Add telemetry_get_pltdata() platform/x86: intel_pmc_ipc: Convert to MFD
MAINTAINERS: Update entry for Intel Broxton PMC driver

 .../ABI/obsolete/sysfs-driver-intel_pmc_bxt   |  22 +
 MAINTAINERS                                   |  23 +-
 arch/x86/Kconfig                              |   2 +-
 arch/x86/include/asm/intel-mid.h              |   9 +-
 arch/x86/include/asm/intel_pmc_ipc.h          |  59 --
 arch/x86/include/asm/intel_scu_ipc.h          | 114 ++-
 arch/x86/include/asm/intel_scu_ipc_legacy.h   |  91 ++
 arch/x86/include/asm/intel_telemetry.h        |   6 +-
 drivers/mfd/Kconfig                           |  20 +-
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/intel_pmc_bxt.c                   | 468 +++++++++
 drivers/mfd/intel_soc_pmic_bxtwc.c            |  34 +-
 drivers/mfd/intel_soc_pmic_mrfld.c            |  10 +-
 drivers/platform/x86/Kconfig                  |  46 +-
 drivers/platform/x86/Makefile                 |   2 +-
 drivers/platform/x86/intel_mid_powerbtn.c     |  15 +-
 drivers/platform/x86/intel_pmc_ipc.c          | 949 ------------------
 drivers/platform/x86/intel_scu_ipc.c          | 447 +++++++--
 drivers/platform/x86/intel_scu_ipcutil.c      |  43 +-
 drivers/platform/x86/intel_scu_pcidrv.c       |  68 ++
 drivers/platform/x86/intel_telemetry_core.c   |  17 +-
 .../platform/x86/intel_telemetry_debugfs.c    |  15 +-
 drivers/platform/x86/intel_telemetry_pltdrv.c |  97 +-
 drivers/usb/typec/mux/Kconfig                 |   2 +-
 drivers/usb/typec/mux/intel_pmc_mux.c         |  12 +-
 drivers/usb/typec/tcpm/Kconfig                |   2 +-
 drivers/watchdog/iTCO_wdt.c                   |  25 +-
 drivers/watchdog/intel-mid_wdt.c              |  53 +-
 include/linux/mfd/intel_pmc_bxt.h             |  53 +
 include/linux/mfd/intel_soc_pmic.h            |  15 +
 include/linux/platform_data/itco_wdt.h        |  11 +-
 31 files changed, 1411 insertions(+), 1320 deletions(-)
 create mode 100644 Documentation/ABI/obsolete/sysfs-driver-intel_pmc_bxt
 delete mode 100644 arch/x86/include/asm/intel_pmc_ipc.h
 create mode 100644 arch/x86/include/asm/intel_scu_ipc_legacy.h
 create mode 100644 drivers/mfd/intel_pmc_bxt.c
 delete mode 100644 drivers/platform/x86/intel_pmc_ipc.c
 create mode 100644 drivers/platform/x86/intel_scu_pcidrv.c
 create mode 100644 include/linux/mfd/intel_pmc_bxt.h
Signature · 1 line
2.25.1