Skip to content

Enable protocol v2 by default

Jonathan Nieder git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fetch test: use more robust test for filtered objectst/t5500-fetch-pack.sh+13 -51 reply
2/5config doc: protocol.version is not experimentalDocumentation/config/protocol.txt+4 -50 replies
3/5test: request GIT_TEST_PROTOCOL_VERSION=0 when appropriatet/t5400-send-pack.sh t/t5500-fetch-pack.sh t/t5512-ls-remote.sh +8 more+30 -279 replies
4/5protocol test: let protocol.version override GIT_TEST_PROTOCOL_VERSIONprotocol.c t/README+7 -80 replies
5/5fetch: default to protocol version 2Documentation/config/protocol.txt protocol.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Enable protocol v2 by default

Hi,

The Git users at $DAYJOB have been using protocol v2 as a default for ~1.5 years now and others have been also reporting good experiences with it, so it seems like a good time to propose bumping the default version. It produces a significant performance improvement when fetching from repositories with many refs, such as
https://chromium.googlesource.com/chromium/src.

This only affects the client, not the server. (The server already defaults to supporting protocol v2.)

This could go in 2.25 (most of the "next" population is likely already using protocol.version=2, so the -rc period would be one of the better ways to expand the user population using this) or could cook in "next" for a cycle. Either is fine by me.

Thoughts of all kinds welcome, as always.

Jonathan Nieder (5):
fetch test: use more robust test for filtered objects config doc: protocol.version is not experimental
test: request GIT_TEST_PROTOCOL_VERSION=0 when appropriate protocol test: let protocol.version override GIT_TEST_PROTOCOL_VERSION
fetch: default to protocol version 2

 Documentation/config/protocol.txt    |  9 ++++-----
 protocol.c                           | 11 +++++------
 t/README                             |  4 ++--
 t/t5400-send-pack.sh                 |  2 +-
 t/t5500-fetch-pack.sh                | 23 ++++++++++++++++-------
 t/t5512-ls-remote.sh                 | 10 +++++-----
 t/t5515-fetch-merge-logic.sh         |  3 ++-
 t/t5516-fetch-push.sh                | 12 ++++++------
 t/t5539-fetch-http-shallow.sh        |  2 +-
 t/t5541-http-push-smart.sh           |  4 ++--
 t/t5551-http-fetch-smart.sh          | 12 ++++++------
 t/t5552-skipping-fetch-negotiator.sh |  2 +-
 t/t5700-protocol-v1.sh               |  3 ++-
 t/t7406-submodule-update.sh          |  2 +-
 14 files changed, 54 insertions(+), 45 deletions(-)

base-commit: 12029dc57db23baef008e77db1909367599210ee