Skip to content

bpftool/libbpf: Add probe for large INSN limit

Michal Rostecki bpf lkml netdev 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesApplied
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 1 replySuperseded

Changes in v3 from the cover letter

- Remove the "complexity" word from probe's description.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2libbpf: Add probe for large INSN limittools/lib/bpf/libbpf.h tools/lib/bpf/libbpf.map tools/lib/bpf/libbpf_probes.c+23 -00 replies
2/2bpftool: Add misc section and probe for large INSN limittools/bpf/bpftool/feature.c+18 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel BorkmannQuentin Monnet
SeriesR-b
1/2Co-authored-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf-next v3 0/2] bpftool/libbpf: Add probe for large INSN limit

This series implements a new BPF feature probe which checks for the commit c04c0d2b968a ("bpf: increase complexity limit and maximum program size"), which increases the maximum program size to 1M. It's based on the similar check in Cilium, although Cilium is already aiming to use bpftool checks and eventually drop all its custom checks.

Examples of outputs:

# bpftool feature probe
[...]
Scanning miscellaneous eBPF features...
Large complexity limit and maximum program size (1M) is available
# bpftool feature probe macros
[...]
/*** eBPF misc features ***/
#define HAVE_HAVE_LARGE_INSN_LIMIT
# bpftool feature probe -j | jq '.["misc"]'
{
  "have_large_insn_limit": true
}

v1 -> v2:
- Test for 'BPF_MAXINSNS + 1' number of total insns.
- Remove info about current 1M limit from probe's description.

v2 -> v3:
- Remove the "complexity" word from probe's description.

Michal Rostecki (2):
libbpf: Add probe for large INSN limit
bpftool: Add misc section and probe for large INSN limit

 tools/bpf/bpftool/feature.c   | 18 ++++++++++++++++++
 tools/lib/bpf/libbpf.h        |  1 +
 tools/lib/bpf/libbpf.map      |  1 +
 tools/lib/bpf/libbpf_probes.c | 21 +++++++++++++++++++++
 4 files changed, 41 insertions(+)
Signature · 1 line
2.16.4