tcp: Add support for L3 domains to MD5 auth
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | ipv4/tcp: Use local variable for tcp_md5_addrnet/ | +26 | 0 replies | |
| 2/9 | ipv6/tcp: Pass dif and sdif to tcp_v6_inbound_md5_hashnet/ | +9 | 0 replies | |
| 3/9 | ipv4/tcp: Pass dif and sdif to tcp_v4_inbound_md5_hashnet/ | +8 | 0 replies | |
| 4/9 | tcp: Add l3index to tcp_md5sig_key and md5 functionsinclude/ net/ net/ | +113 | 0 replies | |
| 5/9 | net: Add device index to tcp_md5siginclude/ net/ net/ | +40 | 0 replies | |
| 6/9 | nettest: Return 1 on MD5 failure for server modetools/ | +1 | 0 replies | |
| 7/9 | nettest: Add support for TCP_MD5 extensionstools/ | +69 | 0 replies | |
| 8/9 | fcnal-test: Add TCP MD5 teststools/ | +145 | 0 replies | |
| 9/9 | fcnal-test: Add TCP MD5 tests for VRFtools/ | +313 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next 0/9] tcp: Add support for L3 domains to MD5 auth
From: David Ahern <[email protected]>
With VRF, the scope of network addresses is limited to the L3 domain the device is associated. MD5 keys are based on addresses, so proper VRF support requires an L3 domain to be considered for the lookups.
Leverage the new TCP_MD5SIG_EXT option to add support for a device index
to MD5 keys. The __tcpm_pad entry in tcp_md5sig is renamed to tcpm_ifindex and a new flag, TCP_MD5SIG_FLAG_IFINDEX, in tcpm_flags determines if the entry is examined. This follows what was done for MD5 and prefixes with commits
8917a777be3b ("tcp: md5: add TCP_MD5SIG_EXT socket option to set a key address prefix") 6797318e623d ("tcp: md5: add an address prefix for key lookup")
Handling both a device AND L3 domain is much more complicated for the response paths. This set focuses only on L3 support - requiring the device index to be an l3mdev (ie, VRF). Support for slave devices can be added later if desired, much like the progression of support for sockets bound to a VRF and then bound to a device in a VRF. Kernel code is setup to explicitly call out that current lookup is for an L3 index, while the uapi just references a device index allowing its meaning to include other devices in the future.
David Ahern (9):
ipv4/tcp: Use local variable for tcp_md5_addr ipv6/tcp: Pass dif and sdif to tcp_v6_inbound_md5_hash ipv4/tcp: Pass dif and sdif to tcp_v4_inbound_md5_hash
tcp: Add l3index to tcp_md5sig_key and md5 functions
net: Add device index to tcp_md5sig
nettest: Return 1 on MD5 failure for server mode
nettest: Add support for TCP_MD5 extensions
fcnal-test: Add TCP MD5 tests
fcnal-test: Add TCP MD5 tests for VRF
include/net/tcp.h | 24 +- include/uapi/linux/tcp.h | 5 +- net/ipv4/tcp_ipv4.c | 126 +++++--- net/ipv6/tcp_ipv6.c | 105 +++++-- tools/testing/selftests/net/fcnal-test.sh | 458 ++++++++++++++++++++++++++++++ tools/testing/selftests/net/nettest.c | 84 +++++- 6 files changed, 715 insertions(+), 87 deletions(-)
Signature · 1 line
2.11.0