Skip to content

ext4: extents.c cleanups

Eric Biggers linux-ext4 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ext4: remove ext4_{ind,ext}_calc_metadata_amount()fs/ext4/ext4.h fs/ext4/extents.c fs/ext4/indirect.c +1 more+0 -800 replies
2/8ext4: clean up len and offset checks in ext4_fallocate()fs/ext4/extents.c+13 -150 replies
3/8ext4: remove redundant S_ISREG() checks from ext4_fallocate()fs/ext4/extents.c fs/ext4/inode.c+0 -120 replies
4/8ext4: make some functions static in extents.cfs/ext4/ext4.h fs/ext4/ext4_extents.h fs/ext4/extents.c+15 -180 replies
5/8ext4: fix documentation for ext4_ext_try_to_merge()fs/ext4/extents.c+4 -30 replies
6/8ext4: remove obsolete comment from ext4_can_extents_be_merged()fs/ext4/extents.c+0 -50 replies
7/8ext4: fix some nonstandard indentation in extents.cfs/ext4/extents.c+11 -110 replies
8/8ext4: add missing braces in ext4_ext_drop_refs()fs/ext4/extents.c+2 -10 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRitesh HarjaniJan Kara
SeriesR-b R-b R-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] ext4: extents.c cleanups

This series makes a few cleanups to things I noticed while reading some of the code in extents.c.

No actual changes in behavior.

Eric Biggers (8):
ext4: remove ext4_{ind,ext}_calc_metadata_amount()
ext4: clean up len and offset checks in ext4_fallocate()
ext4: remove redundant S_ISREG() checks from ext4_fallocate()
ext4: make some functions static in extents.c
ext4: fix documentation for ext4_ext_try_to_merge()
ext4: remove obsolete comment from ext4_can_extents_be_merged()
ext4: fix some nonstandard indentation in extents.c
ext4: add missing braces in ext4_ext_drop_refs()

 fs/ext4/ext4.h         |  11 ----
 fs/ext4/ext4_extents.h |   5 --
 fs/ext4/extents.c      | 143 +++++++++++++----------------------------
 fs/ext4/indirect.c     |  26 --------
 fs/ext4/inode.c        |   3 -
 fs/ext4/super.c        |   2 -
 6 files changed, 45 insertions(+), 145 deletions(-)
Signature · 1 line
2.24.1