Skip to content

Sort out overlay ino numbers

Amir Goldstein linux-unionfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ovl: fix value of i_ino for lower hardlink corner casefs/overlayfs/inode.c+3 -10 replies
2/7ovl: fix out of date comment and unreachable codefs/overlayfs/inode.c fs/overlayfs/util.c+5 -50 replies
3/7ovl: factor out helper ovl_get_root()fs/overlayfs/super.c+29 -150 replies
4/7ovl: simplify i_ino initializationfs/overlayfs/inode.c fs/overlayfs/overlayfs.h fs/overlayfs/super.c +1 more+39 -310 replies
5/7ovl: avoid possible inode number collisions with xino=onfs/overlayfs/inode.c fs/overlayfs/overlayfs.h fs/overlayfs/super.c+66 -236 replies
6/7ovl: enable xino automatically in more casesfs/overlayfs/inode.c fs/overlayfs/overlayfs.h fs/overlayfs/readdir.c +1 more+26 -110 replies
7/7ovl: document xino expected behaviorDocumentation/filesystems/overlayfs.rst+36 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Sort out overlay ino numbers

Miklos,

Most of this series is sorting out internal overlayfs messy code having to do with i_ino.

The value of i_ino was very inconsistent in different setups, so this series also sorts this out and adds documentation of expected values for st_ino/d_ino/i_ino in different setups.

Patch #5 fixes a potential inode number collision bug (st_ino;st_dev). It happens with the "less tested" case of xino bits overflow. I have recently posted [1] some xfstests which also test overlay i_ino. They require a /proc/locks fix that was merged to v5.5-rc4. The test overlay/071 also tests a case of xino bits overflow.

Patch #6 includes a change of behavior, which auto enables xino for tmpfs/xfs.

The series is available on branch ovl-ino on my github [2] and depends on the previously posted ovl-layers pathces [3].

[1] https://lore.kernel.org/fstests/[email protected]
[2] https://github.com/amir73il/linux/commits/ovl-ino
[3] https://marc.info/?l=linux-unionfs&m=157700209100564&w=2

Amir Goldstein (7):
ovl: fix value of i_ino for lower hardlink corner case
ovl: fix out of date comment and unreachable code
ovl: factor out helper ovl_get_root()
ovl: simplify i_ino initialization
ovl: avoid possible inode number collisions with xino=on
ovl: enable xino automatically in more cases
ovl: document xino expected behavior

 Documentation/filesystems/overlayfs.rst |  38 ++++++++-
 fs/overlayfs/inode.c                    | 101 ++++++++++++++++++------
 fs/overlayfs/overlayfs.h                |  21 ++++-
 fs/overlayfs/readdir.c                  |  17 ++--
 fs/overlayfs/super.c                    |  83 ++++++++++++-------
 fs/overlayfs/util.c                     |  20 -----
 6 files changed, 198 insertions(+), 82 deletions(-)
Signature · 1 line
2.17.1