eal: cleanup resources on shutdown
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 3 repliesIn review
- v2 posting 2/28 patches 0 repliesSuperseded
- v2 posting 1/20 of 9 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 14 patches | 19 replies | Superseded |
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | eal: log: close on cleanuplib/ lib/ lib/ +1 more | +40 | 0 replies | |
| 2/8 | eal: log: free dynamic state on cleanuplib/ | +20 | 0 replies | |
| 3/8 | eal: alarm: close file on cleanuplib/ lib/ lib/ +2 more | +30 | 0 replies | |
| 4/8 | eal: cleanup threadslib/ | +13 | 0 replies | |
| 5/8 | eal: mp: end the multiprocess thread during cleanuplib/ | +12 | 0 replies | |
| 6/8 | eal: vfio: cleanup the mp sync handlelib/ lib/ lib/ | +12 | 0 replies | |
| 7/8 | eal: hotplug: cleanup multiprocess resourceslib/ lib/ lib/ | +12 | 0 replies | |
| 8/8 | eal: malloc: cleanup mp resourceslib/ lib/ lib/ +2 more | +25 | 0 replies |
Reviews trailers per patch
4 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Aaron Conole | Anatoly Burakov |
|---|---|---|
| Series | A-b A-b A-b A-b A-b A-b A-b A-b A-b | |
| 1/8 | ||
| 2/8 | ||
| 3/8 | ||
| 4/8 | A-b | |
| 5/8 | A-b | |
| 6/8 | A-b | |
| 7/8 | ||
| 8/8 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [dpdk-dev] [PATCH v3 0/8] eal: cleanup resources on shutdown
Started using valgrind with DPDK, and there are lots of leftover memory and file descriptors. This makes it hard to find application leaks versus DPDK leaks.
The DPDK has a function that applications can use to tell it to cleanup resources on shutdown (rte_eal_cleanup). But the current coverage of that API is spotty. Many internal parts of DPDK leave files and allocated memory behind.
This patch set is a first step at getting the sub-parts of DPDK to cleanup after themselves. These are the easier ones, the harder and more critical ones are in the drivers and the memory subsystem.
There are no new exposed API or ABI changes here.
v3
- fix a couple of minor checkpatch complaints
v2
- rebase after 20.05 file renames
- incorporate review comment feedback
- hold off some of the more involved patches for later
Stephen Hemminger (8):
eal: log: close on cleanup
eal: log: free dynamic state on cleanup
eal: alarm: close file on cleanup
eal: cleanup threads
eal: mp: end the multiprocess thread during cleanup
eal: vfio: cleanup the mp sync handle
eal: hotplug: cleanup multiprocess resources
eal: malloc: cleanup mp resources
lib/librte_eal/common/eal_common_log.c | 33 ++++++++++++++++++++++++- lib/librte_eal/common/eal_common_proc.c | 17 +++++++++---- lib/librte_eal/common/eal_private.h | 20 +++++++++++++++ lib/librte_eal/common/hotplug_mp.c | 5 ++++ lib/librte_eal/common/hotplug_mp.h | 6 +++++ lib/librte_eal/common/malloc_heap.c | 6 +++++ lib/librte_eal/common/malloc_heap.h | 3 +++ lib/librte_eal/common/malloc_mp.c | 12 +++++++++ lib/librte_eal/common/malloc_mp.h | 3 +++ lib/librte_eal/freebsd/eal.c | 1 + lib/librte_eal/freebsd/eal_alarm.c | 10 ++++++++ lib/librte_eal/linux/eal.c | 20 +++++++++++++++ lib/librte_eal/linux/eal_alarm.c | 11 +++++++++ lib/librte_eal/linux/eal_log.c | 14 +++++++++++ lib/librte_eal/linux/eal_vfio.h | 1 + lib/librte_eal/linux/eal_vfio_mp_sync.c | 8 ++++++ 16 files changed, 164 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1