Skip to content

drivers base: transport component error propagation

Gabriel Krisman Bertazi linux-scsi lkml 1 version Applied

Status from this message: Applied to 5.6/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3drivers: base: Support atomic version of attribute_container_device_triggerdrivers/base/attribute_container.c include/linux/attribute_container.h+110 -01 reply
2/3drivers: base: Propagate errors through the transport componentdrivers/base/transport_class.c include/linux/transport_class.h+11 -61 reply
3/3iscsi: Fail session and connection on transport registration failuredrivers/scsi/scsi_transport_iscsi.c+16 -20 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchGreg Kroah-Hartman
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] drivers base: transport component error propagation

Hi,

This small series improves error propagation on the transport component to prevent an inconsistent state in the iscsi module. The bug that motivated this patch results in a hanging iscsi connection that cannot be used or removed by userspace, since the session is in an inconsistent state.

That said, I tested it using the TCP iscsi transport (and forcing errors on the triggered function), which doesn't require a particularly complex container structure, so it is not the best test for finding corner cases on the atomic attribute_container_device trigger version.

Please let me know what you think.

Gabriel Krisman Bertazi (3):
drivers: base: Support atomic version of
attribute_container_device_trigger
drivers: base: Propagate errors through the transport component
iscsi: Fail session and connection on transport registration failure

 drivers/base/attribute_container.c  | 103 ++++++++++++++++++++++++++++
 drivers/base/transport_class.c      |  11 ++-
 drivers/scsi/scsi_transport_iscsi.c |  18 ++++-
 include/linux/attribute_container.h |   7 ++
 include/linux/transport_class.h     |   6 +-
 5 files changed, 137 insertions(+), 8 deletions(-)
Signature · 1 line
2.24.1