Skip to content

perf: Refactor the block info implementation

Jin Yao lkml 5 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 1 replyApplied
  2. v54 patches 3 repliesSuperseded
  3. v44 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v34 patches2 repliesSuperseded
v23 patches4 repliesSuperseded

Changes in v6 from the cover letter

---
Use __block_info__cmp to replace block_pair_cmp according to Arnaldo's suggestions. Fix some issues found in block_info__cmp.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/4perf util: Fix wrong block address comparison in block_info__cmptools/perf/util/block-info.c+6 -150 replies
2/4perf util: Use __block_info__cmp to replace block_pair_cmptools/perf/builtin-diff.c tools/perf/util/block-info.c tools/perf/util/block-info.h+11 -210 replies
3/4perf util: Flexible to set block info output formatstools/perf/builtin-report.c tools/perf/util/block-info.c tools/perf/util/block-info.h+59 -200 replies
4/4perf util: Support color ops to print block percents in colortools/perf/util/block-info.c+15 -101 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/4] perf: Refactor the block info implementation

This patch series refactors the block info functionalities to let them be used by other builtins and allow setting the output fmts flexibly.

It also supports the 'Sampled Cycles%' and 'Avg Cycles%' printed in colors.

v6:
---
Use __block_info__cmp to replace block_pair_cmp according to Arnaldo's suggestions. Fix some issues found in block_info__cmp.

New patches:
------------
perf util: Fix wrong block address comparison in block_info__cmp perf util: Use __block_info__cmp to replace block_pair_cmp

Unchanged patches:
------------------
perf util: Flexible to set block info output formats perf util: Support color ops to print block percents in color

v5:
---
Only change the patch "perf util: Flexible to set block info output formats". Other patches are not changed.

Jin Yao (4):
perf util: Fix wrong block address comparison in block_info__cmp perf util: Use __block_info__cmp to replace block_pair_cmp perf util: Flexible to set block info output formats perf util: Support color ops to print block percents in color

 tools/perf/builtin-diff.c    |  21 +------
 tools/perf/builtin-report.c  |  21 ++++++-
 tools/perf/util/block-info.c | 106 +++++++++++++++++++++--------------
 tools/perf/util/block-info.h |   9 ++-
 4 files changed, 91 insertions(+), 66 deletions(-)
Signature · 1 line
2.17.1