Skip to content

bpf: Introduce global functions

Alexei Starovoitov bpf netdev 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyApplied
  2. v27 patches 6 repliesSuperseded
  3. v16 patches 24 repliesSuperseded

Changes in v3 from the cover letter

- cleaned up a check spotted by Song.
- rebased and dropped patch 2 that was trying to improve BTF based on ELF.
- added one more unit test for scalar return value from global func.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6libbpf: Sanitize global functionstools/include/uapi/linux/btf.h tools/lib/bpf/libbpf.c+40 -10 replies
2/6bpf: Introduce function-by-function verificationinclude/linux/bpf.h include/linux/bpf_verifier.h include/uapi/linux/btf.h +2 more+366 -840 replies
3/6selftests/bpf: Add fexit-to-skb test for global funcstools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c tools/testing/selftests/bpf/progs/fexit_bpf2bpf.c tools/testing/selftests/bpf/progs/test_pkt_access.c+44 -00 replies
4/6selftests/bpf: Add a test for a large global functiontools/testing/selftests/bpf/prog_tests/bpf_verif_scale.c tools/testing/selftests/bpf/progs/pyperf.h tools/testing/selftests/bpf/progs/pyperf_global.c+14 -20 replies
5/6selftests/bpf: Modify a test to check global functionstools/testing/selftests/bpf/progs/test_xdp_noinline.c+2 -20 replies
6/6selftests/bpf: Add unit tests for global functionstools/testing/selftests/bpf/prog_tests/test_global_funcs.c tools/testing/selftests/bpf/progs/test_global_func1.c tools/testing/selftests/bpf/progs/test_global_func2.c +5 more+280 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchSong Liu
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 bpf-next 0/6] bpf: Introduce global functions

v2->v3:
- cleaned up a check spotted by Song.
- rebased and dropped patch 2 that was trying to improve BTF based on ELF.
- added one more unit test for scalar return value from global func.

v1->v2:
- addressed review comments from Song, Andrii, Yonghong
- fixed memory leak in error path
- added modified ctx check
- added more tests in patch 7

v1:
Introduce static vs global functions and function by function verification. This is another step toward dynamic re-linking (or replacement) of global functions. See patch 2 for details.

Alexei Starovoitov (6):
libbpf: Sanitize global functions
bpf: Introduce function-by-function verification selftests/bpf: Add fexit-to-skb test for global funcs selftests/bpf: Add a test for a large global function selftests/bpf: Modify a test to check global functions selftests/bpf: Add unit tests for global functions

 include/linux/bpf.h                           |   7 +-
 include/linux/bpf_verifier.h                  |  10 +-
 include/uapi/linux/btf.h                      |   6 +
 kernel/bpf/btf.c                              | 175 +++++++++---
 kernel/bpf/verifier.c                         | 252 ++++++++++++++----
 tools/include/uapi/linux/btf.h                |   6 +
 tools/lib/bpf/libbpf.c                        |  35 ++-
 .../bpf/prog_tests/bpf_verif_scale.c          |   2 +
 .../selftests/bpf/prog_tests/fexit_bpf2bpf.c  |   1 +
 .../bpf/prog_tests/test_global_funcs.c        |  82 ++++++
 .../selftests/bpf/progs/fexit_bpf2bpf.c       |  15 ++
 tools/testing/selftests/bpf/progs/pyperf.h    |   9 +-
 .../selftests/bpf/progs/pyperf_global.c       |   5 +
 .../selftests/bpf/progs/test_global_func1.c   |  45 ++++
 .../selftests/bpf/progs/test_global_func2.c   |   4 +
 .../selftests/bpf/progs/test_global_func3.c   |  65 +++++
 .../selftests/bpf/progs/test_global_func4.c   |   4 +
 .../selftests/bpf/progs/test_global_func5.c   |  31 +++
 .../selftests/bpf/progs/test_global_func6.c   |  31 +++
 .../selftests/bpf/progs/test_global_func7.c   |  18 ++
 .../selftests/bpf/progs/test_pkt_access.c     |  28 ++
 .../selftests/bpf/progs/test_xdp_noinline.c   |   4 +-
 22 files changed, 746 insertions(+), 89 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/test_global_funcs.c
 create mode 100644 tools/testing/selftests/bpf/progs/pyperf_global.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_global_func1.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_global_func2.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_global_func3.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_global_func4.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_global_func5.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_global_func6.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_global_func7.c
Signature · 1 line
2.23.0