Skip to content

efi/libstub/x86: two more tweaks for the EFI stub startup code

Ard Biesheuvel linux-efi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2efi/libstub/x86: use const attribute for efi_is_64bit()arch/x86/boot/compressed/eboot.c arch/x86/boot/compressed/head_64.S arch/x86/include/asm/efi.h+10 -134 replies
2/2efi/libstub/x86: use mandatory 16-byte stack alignment in mixed modearch/x86/boot/compressed/efi_thunk_64.S+13 -330 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] efi/libstub/x86: two more tweaks for the EFI stub startup code

Two final cleanups for the x86 startup code, one that helps the compiler generate better code, by annotating a helper function with the 'const' function attribute, and one that fixes the misalignment of the stack in mixed mode.

There are no known issues regarding entering the 32-bit firmware from the 64-bit kernel with the stack misaligned, and the 32-bit kernel does so all the time, but it is better to comply with the UEFI spec.

Ard Biesheuvel (2):
efi/libstub/x86: use const attribute for efi_is_64bit() efi/libstub/x86: use mandatory 16-byte stack alignment in mixed mode

 arch/x86/boot/compressed/eboot.c        | 14 +++---
 arch/x86/boot/compressed/efi_thunk_64.S | 46 ++++++--------------
 arch/x86/boot/compressed/head_64.S      |  7 ++-
 arch/x86/include/asm/efi.h              |  2 +-
 4 files changed, 23 insertions(+), 46 deletions(-)
Signature · 1 line
2.20.1