Skip to content

Support CPUID/MSR data in migration streams

Andrew Cooper xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 19 repliesIn review
  2. v1 RFC1 patch 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17tools/libxl: Remove libxl_cpuid_{set, apply_policy}() from the APItools/libxl/libxl.h tools/libxl/libxl_cpuid.c tools/libxl/libxl_dom.c +2 more+34 -121 reply
2/17tools/libxl: Simplify callback handling in libxl-save-helpertools/libxl/libxl_save_helper.c tools/libxl/libxl_save_msgs_gen.pl+7 -111 reply
3/17tools/migration: Drop IHDR_VERSION constant from libxc and pythontools/libxc/xc_sr_restore.c tools/libxc/xc_sr_save.c tools/libxc/xc_sr_stream_format.h +3 more+12 -145 replies
4/17docs/migration Specify migration v3 and STATIC_DATA_ENDdocs/specs/libxc-migration-stream.pandoc tools/libxc/xc_sr_common.c tools/libxc/xc_sr_stream_format.h +1 more+40 -30 replies
5/17python/migration: Update validation logic to understand a v3 streamtools/python/xen/migration/libxc.py+22 -41 reply
6/17libxc/restore: Support v3 streams and handle STATIC_DATA_ENDtools/libxc/include/xenguest.h tools/libxc/xc_sr_common.h tools/libxc/xc_sr_restore.c+33 -21 reply
7/17libxc/restore: STATIC_DATA_END inference for v2 compatibilitytools/libxc/include/xenguest.h tools/libxc/xc_sr_common.h tools/libxc/xc_sr_restore.c +1 more+48 -35 replies
8/17libxc/save: Write a v3 streamtools/libxc/xc_sr_common.h tools/libxc/xc_sr_save.c tools/libxc/xc_sr_save_x86_hvm.c +2 more+47 -80 replies
9/17tools/libxl: Provide a static_data_done callback for domain restoretools/libxl/libxl_create.c tools/libxl/libxl_save_msgs_gen.pl+13 -00 replies
10/17tools/libxl: Plumb a restore boolean down into libxl__build_pre()tools/libxl/libxl_create.c tools/libxl/libxl_dm.c tools/libxl/libxl_dom.c +1 more+13 -85 replies
11/17tools/libxl: Re-position CPUID handling during domain constructiontools/libxl/libxl_create.c tools/libxl/libxl_dom.c+19 -50 replies
11/17tools/libxl: Re-position CPUID handling during domain constructiontools/libxl/libxl_create.c tools/libxl/libxl_dom.c+11 -30 replies
12/17docs/migration: Specify X86_{CPUID, MSR}_POLICY recordsdocs/specs/libxc-migration-stream.pandoc tools/libxc/xc_sr_common.c tools/libxc/xc_sr_stream_format.h +1 more+89 -01 reply
13/17libxc/restore: Handle X86_{CPUID, MSR}_DATA recordstools/libxc/xc_sr_common.h tools/libxc/xc_sr_common_x86.c tools/libxc/xc_sr_common_x86.h +2 more+82 -00 replies
14/17libxc/save: Write X86_{CPUID, MSR}_DATA recordstools/libxc/xc_sr_common_x86.c tools/libxc/xc_sr_common_x86.h tools/libxc/xc_sr_save_x86_hvm.c +1 more+68 -22 replies
15/17tools/libx[cl]: Plumb 'missing' through static_data_done() up into libxltools/libxc/include/xenguest.h tools/libxc/xc_sr_common.h tools/libxc/xc_sr_common_x86.c +6 more+55 -80 replies
15/17tools/libx[cl]: Plumb 'missing' through static_data_done() up into libxltools/libxc/include/xenguest.h tools/libxc/xc_sr_common.h tools/libxc/xc_sr_common_x86.c +6 more+52 -61 reply
16/17tools/libxc: Restore CPUID/MSR data found in the migration streamtools/libxc/xc_cpuid_x86.c tools/libxc/xc_sr_common_x86.c+28 -62 replies
17/17docs/xl.cfg: Rewrite cpuid= sectiondocs/man/xl.cfg.5.pod.in+53 -212 replies

Reviews trailers per patch

16 of 19 patches have a Reviewed-by or Acked-by.

PatchIan Jackson
1/17
2/17A-b
3/17A-b
4/17A-b
5/17A-b
6/17A-b
7/17A-b
8/17A-b
9/17
10/17A-b
11/17A-b A-b
11/17A-b A-b
12/17A-b
13/17A-b
14/17A-b
15/17A-b
15/17A-b
16/17
17/17A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Xen-devel] [PATCH v2 00/17] Support CPUID/MSR data in migration streams

Here is v2 of the work to plumb CPUID/MSR data into the migration stream.

Patches 1 and 2 are cleanup. 3-8 are concerned with introducing the STATIC_DATA_END record. 9-11 are some libxl work to reposition CPUID construction during domain create. 12-14 are the introduction of the X86_{CPUID,MSR}_DATA records, and 15-17 are the final adjustments in libxc and libxl to use them.

This series does have a net change in behaviour for CPUID handing in migrated domains. See patch 16 for details.

Some acks are carried forwards from the v1 review. Others are not. The majority change has been to shuffle the order of actions to hopefully make the logic much more clear to follow.

~Andrew

Andrew Cooper (17):
tools/libxl: Remove libxl_cpuid_{set,apply_policy}() from the API tools/libxl: Simplify callback handling in libxl-save-helper tools/migration: Drop IHDR_VERSION constant from libxc and python docs/migration Specify migration v3 and STATIC_DATA_END python/migration: Update validation logic to understand a v3 stream libxc/restore: Support v3 streams and handle STATIC_DATA_END libxc/restore: STATIC_DATA_END inference for v2 compatibility libxc/save: Write a v3 stream
tools/libxl: Provide a static_data_done callback for domain restore tools/libxl: Plumb a restore boolean down into libxl__build_pre() tools/libxl: Re-position CPUID handling during domain construction docs/migration: Specify X86_{CPUID,MSR}_POLICY records libxc/restore: Handle X86_{CPUID,MSR}_DATA records libxc/save: Write X86_{CPUID,MSR}_DATA records tools/libx[cl]: Plumb 'missing' through static_data_done() up into libxl tools/libxc: Restore CPUID/MSR data found in the migration stream docs/xl.cfg: Rewrite cpuid= section

 docs/man/xl.cfg.5.pod.in                   |  74 +++++++++++++-----
 docs/specs/libxc-migration-stream.pandoc   |  81 ++++++++++++++++++-
 tools/libxc/include/xenguest.h             |  11 +++
 tools/libxc/xc_cpuid_x86.c                 |   8 +-
 tools/libxc/xc_sr_common.c                 |   3 +
 tools/libxc/xc_sr_common.h                 |  35 ++++++++-
 tools/libxc/xc_sr_common_x86.c             | 120 +++++++++++++++++++++++++++++
 tools/libxc/xc_sr_common_x86.h             |  25 ++++++
 tools/libxc/xc_sr_restore.c                |  61 ++++++++++++++-
 tools/libxc/xc_sr_restore_x86_hvm.c        |  10 +++
 tools/libxc/xc_sr_restore_x86_pv.c         |  27 +++++++
 tools/libxc/xc_sr_save.c                   |  20 ++++-
 tools/libxc/xc_sr_save_x86_hvm.c           |   6 ++
 tools/libxc/xc_sr_save_x86_pv.c            |  14 +++-
 tools/libxc/xc_sr_stream_format.h          |   4 +-
 tools/libxl/libxl.h                        |  26 ++++++-
 tools/libxl/libxl_cpuid.c                  |   6 +-
 tools/libxl/libxl_create.c                 |  37 ++++++++-
 tools/libxl/libxl_dm.c                     |   2 +-
 tools/libxl/libxl_dom.c                    |  20 +++--
 tools/libxl/libxl_internal.h               |  10 ++-
 tools/libxl/libxl_nocpuid.c                |   6 +-
 tools/libxl/libxl_save_helper.c            |  16 ++--
 tools/libxl/libxl_save_msgs_gen.pl         |   3 +-
 tools/python/scripts/convert-legacy-stream |  13 +++-
 tools/python/scripts/verify-stream-v2      |   2 +-
 tools/python/xen/migration/libxc.py        |  74 ++++++++++++++++--
 27 files changed, 635 insertions(+), 79 deletions(-)
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel