Skip to content

devlink region trigger support

Jacob Keller netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 20 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3devlink: add callback to trigger region snapshotsdrivers/net/ethernet/mellanox/mlx4/crdump.c drivers/net/netdevsim/dev.c include/net/devlink.h +1 more+19 -110 replies
2/3devlink: introduce command to trigger region snapshotinclude/uapi/linux/devlink.h net/core/devlink.c+36 -00 replies
3/3netdevsim: support triggering snapshot through devlinkdrivers/net/netdevsim/dev.c+26 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] devlink region trigger support

This series consists of patches to enable devlink to request a snapshot via a new DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT.

A reviewer might notice that the devlink health API already has such support for handling a similar case. However, the health API does not make sense in cases where the data is not related to an error condition.

In this case, using the health API only for the dumping feels incorrect. Regions make sense when the addressable content is not captured automatically on error conditions, but only upon request by the devlink API.

The netdevsim driver is modified to support the new trigger_snapshot callback as an example of how this can be used.

Jacob Keller (3):
devlink: add callback to trigger region snapshots
devlink: introduce command to trigger region snapshot
netdevsim: support triggering snapshot through devlink

 drivers/net/ethernet/mellanox/mlx4/crdump.c |  4 +-
 drivers/net/netdevsim/dev.c                 | 37 ++++++++++++-----
 include/net/devlink.h                       | 12 ++++--
 include/uapi/linux/devlink.h                |  2 +
 net/core/devlink.c                          | 45 +++++++++++++++++++--
 5 files changed, 80 insertions(+), 20 deletions(-)
Signature · 1 line
2.25.0.rc1