libxl: event: Fix hang for some applications
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest10 patches 1 replyIn review
- v210 patches 17 repliesSuperseded
- v18 patches 0 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | libxl: event: Rename poller.fds_changed to .fds_deregisteredtools/ tools/ | +7 | 0 replies | |
| 2/10 | libxl: event: Rename ctx.pollers_fd_changed to .pollers_activetools/ tools/ tools/ | +9 | 0 replies | |
| 3/10 | libxl: event: Introduce CTX_UNLOCK_EGC_FREEtools/ tools/ tools/ | +10 | 0 replies | |
| 4/10 | libxl: event: Make LIBXL__EVENT_DISASTER take a gc, not an egctools/ tools/ tools/ +3 more | +25 | 0 replies | |
| 5/10 | libxl: event: Make libxl__poller_wakeup take a gc, not an egctools/ tools/ | +4 | 0 replies | |
| 6/10 | libxl: event: Fix hang when mixing blocking and eventy callstools/ tools/ | +194 | 0 replies | |
| 7/10 | libxl: event: poller pipe optimisationtools/ tools/ | +4 | 0 replies | |
| 8/10 | libxl: event: Break out baton_waketools/ | +13 | 0 replies | |
| 9/10 | libxl: event: Fix possible hang with libxl_osevent_beforepolltools/ | +43 | 0 replies | |
| 10/10 | libxl: event: Move poller pipe emptying to the end of afterpolltools/ | +6 | 0 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | George Dunlap |
|---|---|
| 1/10 | R-b T-b |
| 2/10 | R-b T-b |
| 3/10 | R-b T-b |
| 4/10 | T-b R-b |
| 5/10 | R-b T-b |
| 6/10 | R-b T-b |
| 7/10 | R-b T-b |
| 8/10 | R-b T-b |
| 9/10 | R-b T-b |
| 10/10 | T-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Xen-devel] [PATCH v3 00/10] libxl: event: Fix hang for some applications
The meat here, including a description of the bug, is in:
libxl: event: Fix hang when mixing blocking and eventy calls
This is all now Reviewed-by and Tested-by George, so it is ready to be committed. But I will be away for a bit soon and reverting something of this form is probably undesirable. So I will commit this in something over a week (assuming no further comments arise).
The changes here from v2 are only to two of the commit messages (marked m in the list below).
I am not sure whether this series is a backport candidate. It is not impossible that the bug we are fixing here is affecting (say) libvirt. But if so presumably not in a significant way as we haven't seen reports. So even though this is a bugfix, I'm sceptical.
Ian Jackson (10):
libxl: event: Rename poller.fds_changed to .fds_deregistered
libxl: event: Rename ctx.pollers_fd_changed to .pollers_active
libxl: event: Introduce CTX_UNLOCK_EGC_FREE
libxl: event: Make LIBXL__EVENT_DISASTER take a gc, not an egc
m libxl: event: Make libxl__poller_wakeup take a gc, not an egc
libxl: event: Fix hang when mixing blocking and eventy calls
libxl: event: poller pipe optimisation
libxl: event: Break out baton_wake
libxl: event: Fix possible hang with libxl_osevent_beforepoll
m libxl: event: Move poller pipe emptying to the end of afterpoll
tools/libxl/libxl.c | 4 +- tools/libxl/libxl_aoutils.c | 2 +- tools/libxl/libxl_disk.c | 4 +- tools/libxl/libxl_domain.c | 2 +- tools/libxl/libxl_event.c | 286 +++++++++++++++++++++++++++++++++++-------- tools/libxl/libxl_fork.c | 17 ++- tools/libxl/libxl_internal.h | 54 +++++--- 7 files changed, 290 insertions(+), 79 deletions(-)
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel