Skip to content

Fix Exynos4210 DMA support

Guenter Roeck qemu-arm qemu-devel 3 versions – Applied

Status from this message: Applied to target-arm.next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 5 repliesApplied
  2. v27 patches 9 repliesSuperseded
  3. v16 patches 20 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8dma/pl330: Convert to support tracinghw/dma/pl330.c hw/dma/trace-events+72 -403 replies
2/8hw/core/or-irq: Increase limit of or-lines to 48include/hw/or-irq.h+1 -10 replies
3/8hw/arm/exynos4210: Fix DMA initializationhw/arm/exynos4210.c include/hw/arm/exynos4210.h+47 -80 replies
4/8hw/char/exynos4210_uart: Convert to support tracinghw/char/exynos4210_uart.c hw/char/trace-events+47 -660 replies
5/8hw/char/exynos4210_uart: Implement post_load functionhw/char/exynos4210_uart.c+10 -00 replies
6/8hw/char/exynos4210_uart: Implement Rx FIFO level triggers and timeoutshw/char/exynos4210_uart.c hw/char/trace-events+94 -260 replies
7/8hw/char/exynos4210_uart: Add receive DMA supporthw/char/exynos4210_uart.c hw/char/trace-events+26 -00 replies
8/8hw/arm/exynos4210: Connect serial port DMA busy signals with pl330hw/arm/exynos4210.c+29 -130 replies

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/8R-b
2/8
3/8R-b
4/8R-b
5/8R-b
6/8
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] Fix Exynos4210 DMA support

Commit 59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210") introduced DMA support for Exynos4210. Unfortunately, it never really worked. DMA interrupt line and polarity was wrong, and the serial port needs extra code to support DMA. This patch series fixes the problem.

The series also converts pl330 and exynos4210_uart code to support tracing. While not strictly necessary, this was very useful for debugging, and it seemed too valuable to drop it from the final series. Similar, improved support for receive FIFO handling is not strictly necessary to fix DMA handling, but I initially thought that it was and added the code. Like tracing support it seemed too valuable to drop it.

The series was tested with qemu's smdkc210 and nuri emulations and with exynos4210-smdkv310.dtb. Without the series, the emulation does not react to serial line input, and serial line output stalls when using DMA. With this series in place, serial line input is handled correctly, serial output does not stall, and DMA interrupts are observed and handled.

v3: Increased number of or-irq-lines to 48 to support the full number
of lines needed. Simplifications in handling UCON register when handling receive timeouts. Don't save timer state in VMSTATE. Added Reviewed-by: tags as received.
v2: Addressed all feedback comments but one (see last patch of series).
Please see individual patches for details.