mlxsw: Various fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 1 replyIn review
- v14 patches 2 repliesSuperseded
Changes in v2 from the cover letter
* Patches #2-#3: use skb_cow_head() instead of skb_unshare() as suggested by Jakub. Remove unnecessary check regarding headroom
* Patches #5-#6: new
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mlxsw: spectrum: Do not enforce same firmware version for multiple ASICsdrivers/ | +22 | 0 replies | |
| 2/6 | mlxsw: spectrum: Do not modify cloned SKBs during xmitdrivers/ | +6 | 0 replies | |
| 3/6 | mlxsw: switchx2: Do not modify cloned SKBs during xmitdrivers/ | +6 | 0 replies | |
| 4/6 | selftests: mlxsw: qos_mc_aware: Fix mausezahn invocationtools/ | +6 | 0 replies | |
| 5/6 | mlxsw: spectrum: Wipe xstats.backlog of down portsdrivers/ | +13 | 0 replies | |
| 6/6 | mlxsw: spectrum_qdisc: Include MC TCs in Qdisc countersdrivers/ | +23 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Pirko | Shalom Toledo |
|---|---|---|
| 1/6 | A-b | T-b |
| 2/6 | A-b | |
| 3/6 | A-b | |
| 4/6 | ||
| 5/6 | A-b | |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net v2 0/6] mlxsw: Various fixes
From: Ido Schimmel <[email protected]>
This patch set contains various fixes for mlxsw.
Patch #1 splits the init() callback between Spectrum-2 and Spectrum-3 in order to avoid enforcing the same firmware version for both ASICs, as this can't possibly work. Without this patch the driver cannot boot with the Spectrum-3 ASIC.
Patches #2-#3 fix a long standing race condition that was recently exposed while testing the driver on an emulator, which is very slow compared to the actual hardware. The problem is explained in detail in the commit messages.
Patch #4 fixes a selftest.
Patch #5 prevents offloaded qdiscs from presenting a non-zero backlog to the user when the netdev is down. This is done by clearing the cached backlog in the driver when the netdev goes down.
Patch #6 fixes qdisc statistics (backlog and tail drops) to also take into account the multicast traffic classes.
v2:
* Patches #2-#3: use skb_cow_head() instead of skb_unshare() as suggested by Jakub. Remove unnecessary check regarding headroom
* Patches #5-#6: new
Ido Schimmel (3):
mlxsw: spectrum: Do not enforce same firmware version for multiple
ASICs
mlxsw: spectrum: Do not modify cloned SKBs during xmit
mlxsw: switchx2: Do not modify cloned SKBs during xmit
Petr Machata (3):
selftests: mlxsw: qos_mc_aware: Fix mausezahn invocation
mlxsw: spectrum: Wipe xstats.backlog of down ports
mlxsw: spectrum_qdisc: Include MC TCs in Qdisc counters
.../net/ethernet/mellanox/mlxsw/spectrum.c | 54 ++++++++++++++----- .../ethernet/mellanox/mlxsw/spectrum_qdisc.c | 30 ++++++++--- .../net/ethernet/mellanox/mlxsw/switchx2.c | 17 +++--- .../drivers/net/mlxsw/qos_mc_aware.sh | 8 ++- 4 files changed, 76 insertions(+), 33 deletions(-)
Signature · 1 line
2.24.1