Skip to content

Use no_vblank property for drivers without VBLANK

Thomas Zimmermann dri-devel virtualization xen-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest15 patches 1 replyIn review
  2. v415 patches 8 repliesSuperseded
  3. v34 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 2/24 patches8 repliesSuperseded
v2 posting 1/24 patches0 repliesSuperseded

Changes in v5 from the cover letter

* documentation updates in DRM core and xen (Daniel, Emil, Oleksandr)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15drm: Initialize struct drm_crtc_state.no_vblank from device settingsdrivers/gpu/drm/drm_atomic_helper.c drivers/gpu/drm/drm_vblank.c include/drm/drm_crtc.h +2 more+70 -100 replies
2/15drm/arc: Remove sending of vblank eventdrivers/gpu/drm/arc/arcpgu_crtc.c+0 -160 replies
3/15drm/ast: Don't set struct drm_crtc_state.no_vblank explictlydrivers/gpu/drm/ast/ast_mode.c+0 -20 replies
4/15drm/bochs: Remove sending of vblank eventdrivers/gpu/drm/bochs/bochs_kms.c+0 -90 replies
5/15drm/cirrus: Remove sending of vblank eventdrivers/gpu/drm/cirrus/cirrus.c+0 -80 replies
6/15drm/gm12u320: Remove sending of vblank eventdrivers/gpu/drm/tiny/gm12u320.c+0 -90 replies
7/15drm/ili9225: Remove sending of vblank eventdrivers/gpu/drm/tiny/ili9225.c+0 -90 replies
8/15drm/mipi-dbi: Remove sending of vblank eventdrivers/gpu/drm/drm_mipi_dbi.c+0 -90 replies
9/15drm/qxl: Remove sending of vblank eventdrivers/gpu/drm/qxl/qxl_display.c+0 -140 replies
10/15drm/repaper: Remove sending of vblank eventdrivers/gpu/drm/tiny/repaper.c+0 -90 replies
11/15drm/st7586: Remove sending of vblank eventdrivers/gpu/drm/tiny/st7586.c+0 -90 replies
12/15drm/udl: Don't set struct drm_crtc_state.no_vblank explictlydrivers/gpu/drm/udl/udl_modeset.c+0 -110 replies
13/15drm/vboxvideo: Remove sending of vblank eventdrivers/gpu/drm/vboxvideo/vbox_mode.c+0 -120 replies
14/15drm/virtio: Remove sending of vblank eventdrivers/gpu/drm/virtio/virtgpu_display.c+0 -80 replies
15/15drm/xen: Explicitly disable automatic sending of vblank eventdrivers/gpu/drm/xen/xen_drm_front_kms.c+19 -01 reply

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchGerd HoffmannDaniel VetterOleksandr Andrushchenko
1/15A-b R-b
2/15A-b R-b
3/15A-b R-b
4/15A-b R-b
5/15A-b R-b
6/15A-b R-b
7/15A-b R-b
8/15A-b R-b
9/15A-b R-b
10/15A-b R-b
11/15A-b R-b
12/15A-b R-b
13/15A-b R-b
14/15A-b R-b
15/15A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/15] Use no_vblank property for drivers without VBLANK

Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over drivers.

The current implementation looks at state of a device wrt vblanking. If vblanking has been initialized for the device, the driver is responsible for sending out VBLANK events. Otherwise, DRM will send out the event. The behaviour is selected by initializing no_vblank as part of drm_atomic_helper_check_modeset().

I went through all drivers, looking for those that call send out VBLANK events but do not call drm_vblank_init(). These are converted to the new semantics. This affects tiny drivers; drivers for virtual hardware; and a few others, which do not support interrupts. Xen comes with its own VBLANK logic and now disables no_vblank explicitly.

v5:
* documentation updates in DRM core and xen (Daniel, Emil, Oleksandr)
v4:
* replaced drm_crtc_has_vblank() with drm_dev_has_vblank() (Daniel)
* squashed patches 1 and 2
* moved driver updates into separate patches
v3:
* reorder and squash patches
* set no_vblank in drm_atomic_helper_check_modeset() for *all* drivers (Daniel)
* convert all drivers to new semnatics as necessary
v2:
* document functionality (Daniel)
* cleanup ast (Daniel)
* let simple-kms handle no_vblank where possible

Thomas Zimmermann (15):
drm: Initialize struct drm_crtc_state.no_vblank from device settings drm/arc: Remove sending of vblank event
drm/ast: Don't set struct drm_crtc_state.no_vblank explictly drm/bochs: Remove sending of vblank event
drm/cirrus: Remove sending of vblank event
drm/gm12u320: Remove sending of vblank event
drm/ili9225: Remove sending of vblank event
drm/mipi-dbi: Remove sending of vblank event
drm/qxl: Remove sending of vblank event
drm/repaper: Remove sending of vblank event
drm/st7586: Remove sending of vblank event
drm/udl: Don't set struct drm_crtc_state.no_vblank explictly drm/vboxvideo: Remove sending of vblank event
drm/virtio: Remove sending of vblank event
drm/xen: Explicitly disable automatic sending of vblank event

 drivers/gpu/drm/arc/arcpgu_crtc.c        | 16 -----------
 drivers/gpu/drm/ast/ast_mode.c           |  2 --
 drivers/gpu/drm/bochs/bochs_kms.c        |  9 -------
 drivers/gpu/drm/cirrus/cirrus.c          |  8 ------
 drivers/gpu/drm/drm_atomic_helper.c      | 10 ++++++-
 drivers/gpu/drm/drm_mipi_dbi.c           |  9 -------
 drivers/gpu/drm/drm_vblank.c             | 28 +++++++++++++++++++
 drivers/gpu/drm/qxl/qxl_display.c        | 14 ----------
 drivers/gpu/drm/tiny/gm12u320.c          |  9 -------
 drivers/gpu/drm/tiny/ili9225.c           |  9 -------
 drivers/gpu/drm/tiny/repaper.c           |  9 -------
 drivers/gpu/drm/tiny/st7586.c            |  9 -------
 drivers/gpu/drm/udl/udl_modeset.c        | 11 --------
 drivers/gpu/drm/vboxvideo/vbox_mode.c    | 12 ---------
 drivers/gpu/drm/virtio/virtgpu_display.c |  8 ------
 drivers/gpu/drm/xen/xen_drm_front_kms.c  | 19 +++++++++++++
 include/drm/drm_crtc.h                   | 34 +++++++++++++++++++-----
 include/drm/drm_simple_kms_helper.h      |  7 +++--
 include/drm/drm_vblank.h                 |  1 +
 19 files changed, 89 insertions(+), 135 deletions(-)

--
2.25.0